jpmschweitzerandClaude Opus 4.8
431e26d659
Nothing has spawned tmux since D-77 moved Claude session persistence to `--resume`; Claude and terminal panes spawn `claude` or the shell directly. But the toolchain still resolved tmux and listed it in `missing`, so on mac/linux a box without tmux showed a spurious "tmux not found" warning in the welcome view + status bar. The windows-support branch had special-cased that away with a `!Platform.isWindows` guard — the tell that the requirement was dead everywhere, not platform-specific. Drop tmux from ResolvedPaths / ToolchainView / Toolchain (field, getter, `missing`, PATH resolution) on every platform, removing the Windows guards with it. Strip the testmode tmux probes and the comments / CLAUDE.md line that claimed clide spawns tmux. (The dead ToolCheck class that also gated on tmux was already deleted on main and dropped in the preceding merge.) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
79 lines
3.0 KiB
Dart
79 lines
3.0 KiB
Dart
import 'package:clide/builtin/ipc_status/ipc_status.dart';
|
|
import 'package:clide/extension/extension.dart';
|
|
import 'package:clide/kernel/kernel.dart';
|
|
import 'package:flutter/widgets.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
|
|
import '../../helpers/kernel_fixture.dart';
|
|
import '../../helpers/widget_harness.dart';
|
|
|
|
void main() {
|
|
group('IpcStatusExtension', () {
|
|
late KernelFixture f;
|
|
|
|
setUp(() async {
|
|
f = await KernelFixture.create();
|
|
});
|
|
|
|
tearDown(() async => f.dispose());
|
|
|
|
test('contributes a statusbar item', () async {
|
|
f.services.extensions.register(IpcStatusExtension());
|
|
await f.services.extensions.activateAll();
|
|
final items = f.services.panels.contributionsFor(Slots.statusbar).whereType<StatusItemContribution>().toList();
|
|
expect(items, hasLength(1));
|
|
expect(items.first.priority, 100);
|
|
});
|
|
|
|
testWidgets('renders without crashing', (tester) async {
|
|
await tester.pumpWidget(harness(f, const ToolStatusItem()));
|
|
await tester.pumpAndSettle();
|
|
expect(tester.takeException(), isNull);
|
|
});
|
|
|
|
testWidgets('unresolved toolchain renders an empty shrink', (tester) async {
|
|
// Default fixture leaves toolchain unresolved → SizedBox.shrink branch.
|
|
await tester.pumpWidget(harness(f, const ToolStatusItem()));
|
|
await tester.pumpAndSettle();
|
|
expect(find.text('application ok'), findsNothing);
|
|
});
|
|
|
|
testWidgets('all-tools-resolved shows a single "application ok" chip', (tester) async {
|
|
f.services.toolchain.applyResolved(const ResolvedPaths(git: '/usr/bin/git', pql: '/usr/bin/pql', shell: '/bin/bash'));
|
|
await tester.pumpWidget(harness(f, const ToolStatusItem()));
|
|
await tester.pumpAndSettle();
|
|
expect(find.text('application ok'), findsOneWidget);
|
|
});
|
|
|
|
testWidgets('missing tools render a warning chip per missing tool', (tester) async {
|
|
// git + pql missing, shell resolved → one chip each, nothing else.
|
|
f.services.toolchain.applyResolved(const ResolvedPaths(shell: '/bin/bash'));
|
|
await tester.pumpWidget(harness(f, const ToolStatusItem()));
|
|
await tester.pumpAndSettle();
|
|
expect(find.text('git not found'), findsOneWidget);
|
|
expect(find.text('pql not found'), findsOneWidget);
|
|
expect(find.textContaining('not found'), findsNWidgets(2));
|
|
});
|
|
|
|
testWidgets('StatusItemContribution.build returns a ToolStatusItem', (tester) async {
|
|
f.services.extensions.register(IpcStatusExtension());
|
|
await f.services.extensions.activateAll();
|
|
final item = f.services.panels.contributionsFor(Slots.statusbar).whereType<StatusItemContribution>().first;
|
|
// Pump a Builder so we have a real BuildContext to hand to .build.
|
|
late Widget produced;
|
|
await tester.pumpWidget(
|
|
harness(
|
|
f,
|
|
Builder(
|
|
builder: (ctx) {
|
|
produced = item.build(ctx);
|
|
return const SizedBox.shrink();
|
|
},
|
|
),
|
|
),
|
|
);
|
|
expect(produced, isA<ToolStatusItem>());
|
|
});
|
|
});
|
|
}
|