jpmschweitzerandClaude Opus 4.8
606d3df98f
Pre-Windows-VM hardening — the parts validatable on Linux, leaving the unrunnable FFI (Job Object, T-424) for the VM session: - Clamp PTY cols/rows to >= 2 in both backends' spawn + resize (new pty_size.dart). A 1-column ConPTY makes conhost spin emitting CRLF (microsoft/terminal#19922); 0 is invalid on both platforms. - ci/test.sh: --timeout 60s on the dart-test pty line (matches the flutter lines) so a wedged ConPTY reader fails fast instead of hanging the run. - Make windows_pty.dart's pure helpers public + testable off-Windows: quoteArg (MSVCRT quoting), composeEnvironmentBlock, and resolveExecutable (now takes an injectable existence probe). New windows_pty_args_test.dart + pty_size_test.dart give 15 cross-platform assertions over the trickiest Windows logic the on-Windows smoke suite can't reach off-platform. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
72 lines
3.8 KiB
Bash
Executable File
72 lines
3.8 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# Fast test layer — analyze + format + unit + widget + golden.
|
|
#
|
|
# Two modes (T-192):
|
|
# ci/test.sh dev inner loop — NO coverage, parallel. ~20s warm.
|
|
# ci/test.sh --coverage gate run — instrumented; writes coverage/lcov.info
|
|
# for coverage-gate. ~36s (coverage is the floor and
|
|
# is concurrency-insensitive, measured — so no
|
|
# --concurrency here; it buys nothing).
|
|
#
|
|
# Both pass `--timeout 60s` so a hung test (a stray pumpAndSettle, or a
|
|
# real-time deadlock) fails fast instead of wedging the runner for ~10 min and
|
|
# stalling the pre-push gate. (Use the pumpAsync helper in tests; never
|
|
# pumpAndSettle / Future.delayed(Duration.zero) inside testWidgets.)
|
|
set -euo pipefail
|
|
cd "$(dirname "$0")/.."
|
|
|
|
# Reporter: failures-only keeps the gate output to failing tests + a final
|
|
# pass/fail count, instead of one line per test (the `expanded` reporter the
|
|
# runner picks when stdout isn't a TTY — which buries real failures in
|
|
# thousands of pass lines). Override with TEST_REPORTER=expanded when
|
|
# debugging a specific run. (T-242)
|
|
REPORTER="${TEST_REPORTER:-failures-only}"
|
|
|
|
coverage=0
|
|
[[ "${1:-}" == "--coverage" ]] && coverage=1
|
|
|
|
echo "==> flutter analyze"
|
|
flutter analyze
|
|
|
|
echo "==> dart format (whole tree)"
|
|
dart format --set-exit-if-changed .
|
|
|
|
echo "==> dart test (pty — unreliable under the flutter test runner; serial)"
|
|
# --concurrency=1: these spawn real PTYs and compete for fds when run in
|
|
# parallel, which flaked them (registry/session). Serialize — the proper fix
|
|
# for resource-bound tests, vs. the old per-test `retry:` band-aid. (T-193)
|
|
# windows_pty_test is the ConPTY sibling of session_test; each suite
|
|
# self-skips off-platform, so the union always contributes tests.
|
|
# --timeout 60s matches the flutter lines below: a wedged PTY test (e.g. a
|
|
# ConPTY reader blocked forever in ReadFile) fails fast instead of hanging the
|
|
# whole serial run.
|
|
dart test -r "$REPORTER" --concurrency=1 --timeout 60s --tags pty test/pty/session_test.dart test/panes/registry_test.dart test/pty/windows_pty_test.dart
|
|
|
|
# The parallel pool excludes both pty (runs under dart test, above) and
|
|
# serial-tagged tests (concurrency-vulnerable — run in their own --concurrency=1
|
|
# pass below). See dart_test.yaml + T-193.
|
|
if [[ "$coverage" == 1 ]]; then
|
|
# Each pass writes its raw coverage into a per-run temp dir (via
|
|
# --coverage-path), never the shared coverage/lcov.info / lcov.parallel.info.
|
|
# So a concurrent `flutter test --coverage` — a second push gate, or a
|
|
# `make test` during a push — can't race or delete this run's intermediates
|
|
# (which crashed merge_lcov with FileNotFoundError). Only the final merged
|
|
# result lands in coverage/lcov.info, via an atomic rename within coverage/.
|
|
# (T-345)
|
|
COV_TMP="$(mktemp -d "${TMPDIR:-/tmp}/clide-cov.XXXXXX")"
|
|
trap 'rm -rf "$COV_TMP" "coverage/.lcov.$$.info"' EXIT
|
|
echo "==> flutter test --coverage (parallel pool; excludes pty + serial)"
|
|
flutter test -r "$REPORTER" --coverage --coverage-path "$COV_TMP/parallel.info" --exclude-tags "pty || serial" --timeout 60s
|
|
echo "==> flutter test --coverage (serial-tagged; --concurrency=1)"
|
|
flutter test -r "$REPORTER" --coverage --coverage-path "$COV_TMP/serial.info" --tags serial --concurrency=1 --timeout 60s
|
|
echo "==> merge coverage (parallel + serial passes → coverage/lcov.info)"
|
|
mkdir -p coverage
|
|
python3 ci/merge_lcov.py "$COV_TMP/parallel.info" "$COV_TMP/serial.info" > "coverage/.lcov.$$.info"
|
|
mv -f "coverage/.lcov.$$.info" coverage/lcov.info
|
|
else
|
|
echo "==> flutter test (dev; parallel pool, excludes pty + serial)"
|
|
flutter test -r "$REPORTER" --exclude-tags "pty || serial" --concurrency=12 --timeout 60s
|
|
echo "==> flutter test (dev; serial-tagged, --concurrency=1)"
|
|
flutter test -r "$REPORTER" --tags serial --concurrency=1 --timeout 60s
|
|
fi
|