4 Commits

Include renames

Author	SHA1	Message	Date
jpmschweitzerandClaude Opus 4.7	f46ab50ff9	test sweep: cover terminal_view IME / focus tail paths (T-91) ... Three tests for the lines the existing TerminalView suite didn't quite touch: the deleteDetection backspace flow (CustomTextEdit.onDelete → scrollToBottom + Terminal.keyInput), the hardwareKeyboardOnly tap that requests focus directly (_onTapUp's else-branch when there's no CustomTextEdit), and the single-char IME insert path where the character maps to a TerminalKey (_onInsert's key != null branch). Coverage: terminal_view.dart 180/188 -> 187/188 (99.5%). The 1 remaining line is _scrollToBottom's jumpTo call — unreachable in current wiring since the tree has no Scrollable; _scrollableKey .currentState is always null and the guard short-circuits. Note: infinite_scroll_view.dart stays at 90% — the 4 uncovered lines are the position-setter's value-changed branch, only reachable when the inner Scrollable swaps its ViewportOffset. The widget doesn't expose ScrollController or physics, so there's no public surface to drive that path from a test. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-11 18:04:48 +02:00
jpmschweitzerandClaude Opus 4.7	2216092ef4	test sweep: cover gesture_handler / gesture_detector selection paths (T-91) ... Adds three widget tests under TerminalView — selection gestures: double-tap selects a word; long-press (touch) selects a word and keeps the selection across move-update; mouse drag selects characters across drag-start and drag-update. Each verifies the side-effect on the externally-supplied TerminalController. Coverage: gesture_detector.dart 42/50 -> 50/50; gesture_handler.dart 39/59 -> 55/59. The 4 remaining uncovered lines (147, 148, 151, 152) are the dead tertiary-tap state methods filed as T-95 — same shape as T-93 but on middle-click. Floor stays at 69 (69.79% measured; integer threshold unchanged). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-08 18:16:07 +02:00
jpmschweitzerandClaude	6b7290dc42	fix dead-wired TerminalView.onTapUp callback (T-93) ... `TerminalView.onTapUp` was documented as "Callback for when the user taps on the terminal" but was wired to a code path nothing ever invoked: - `TerminalView.build` passed it via `onTapUp:` to `TerminalGestureHandler`, - which forwarded via `onTapUp:` to `TerminalGestureDetector`, - whose `onTapUp` field was declared and accepted but never called by `_handleTapUp` (which only fires `onSingleTapUp`). Net: every caller that registered an `onTapUp` callback on `TerminalView` got silent failure. zero in-tree callers depended on it (clide_pty_view.dart is the only TerminalView callsite and doesn't pass any tap callback), but the public API said one thing and did another. Fix: wire `_onTapUp` (the cell-resolving state-method) through the detector's working `onSingleTapUp` slot. The user-facing semantics ("fires on confirmed single tap with the resolved cell offset") match the only sane interpretation of the docstring, and don't overlap with the existing `onSecondaryTap*` (which were already correctly wired through TapGestureRecognizer's secondary callbacks). Also drops the dead surface that surfaced the bug: - `TerminalGestureHandler.onTapUp` parameter + field — no caller passes it after the fix; was only used to forward into the dead detector field. - `TerminalGestureDetector.onTapUp` parameter + field — never invoked by `_handleTapUp`. Pure dead code. Tests: extends `terminal_view_test.dart` with a primary-tap regression case + paired tests for selection-clearing and secondary-tap callback routing. The double-tap recognizer's 300 ms timer is flushed via `pump(const Duration(seconds: 1))` (pumpAndSettle waits for animations, not arbitrary timers). Coverage delta: - terminal_view.dart: 151/188 → 180/188 (95.7%; remaining gaps are IME `_onComposing`/`_onEditableRect`/`_onKeyboardShow` body branches that need deeper IME mocking). - gesture_handler.dart: 18/60 → 39/59. - gesture_detector.dart: 30/50 → 42/50. - Total project: 65.76% → 66.97%; coverage_floor 65 → 66. Co-Authored-By: Claude <noreply@anthropic.com>	2026-05-07 08:49:09 +02:00
jpmschweitzerandClaude	fb85dfa6f9	test sweep: cover TerminalView widget (T-91) ... Adds test/terminal/terminal_view_test.dart — 14 widget tests covering the StatefulWidget that wires gesture / keyboard / scroll plumbing around a `Terminal`: - Construction smoke tests (default, externally-supplied controller / focusNode / scrollController, hardwareKeyboardOnly, readOnly + hardwareKeyboardOnly). - Pointer-signal handling: PointerScrollEvent → PgUp/PgDown keyInput; non-scroll PointerSignalEvent ignored. - didUpdateWidget swap of focusNode / controller / scrollController (auto-created previous instance gets disposed cleanly). - Hardware key event flowing through to Terminal.keyInput. - cursorRect / globalCursorRect after layout. - requestKeyboard / closeKeyboard as no-ops when no edit state is mounted; hasInputConnection false when no input connection is open. - Selection survival when the widget unmounts but an externally-owned controller stays alive. Coverage delta: - terminal_view.dart: 0/188 → 151/188 (80.3%). - Total project: 59.82% → 65.76%; coverage_floor bumped 59 → 65. The remaining ~20% in terminal_view.dart sits in gesture / IME / keyboard-event plumbing (`_onTapUp`, `_onTapDown`, secondary-tap callbacks, `_onInsert`, `_onComposing`, `_handleKeyEvent` shortcut path, `_onKeyboardShow`, `_onEditableRect`, `_scrollToBottom`). These are reachable only through full pointer / IME simulation that's better suited to `integration_test/` than widget tests — leaving them for a later integration-test pass rather than papering over with brittle gesture mocking. Co-Authored-By: Claude <noreply@anthropic.com>	2026-05-07 08:25:44 +02:00