jpmschweitzer/clide
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
681 Commits 1 Branch 17 Tags
db6ecbd5dfe79e07e1fd0fe98dc1d574a6cd3d8b
Commit Graph
4 Commits
Author SHA1 Message Date
jpmschweitzerandClaude Opus 4.8 635ae04dae fix Esc closing the editor instead of returning to Vim normal mode 
panel.focusMode.exit is bound to Escape in the contributions layer, which
outranks the active preset. In Vim insert/visual mode that shadowed the
vim preset's `escape → vim.mode.normal` binding, so Esc closed the editor
instead of returning to normal mode.

Add an optional when-clause to a CommandContribution's defaultBinding
(plumbed through to KeymapService.registerCommandBinding, which already
accepts one) and guard focusMode.exit's escape with
`!vim.insert && !vim.visual` — symmetric with vim.yaml's vim.mode.normal.
Esc still exits focus / closes the editor in normal and non-Vim modes.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
 2026-06-06 20:58:14 +02:00
jpmschweitzerandClaude Opus 4.7 3339d3fcb5 test sweep: cover default_layout commands (T-91)
test / unit + widget + golden + a11y (push) Failing after 31s
test / integration_test (xvfb) (push) Has been skipped
test / bundle smoke (xvfb 5s) (push) Has been skipped
test / daemon subprocess + web WASM smoke (push) Has been skipped
test / dart doc (lib API) (push) Failing after 1m1s 
Eight new tests in test/builtin/default_layout/widget_test.dart
covering the DefaultLayoutExtension command handlers the existing
four-test suite didn't reach:

- All commands return the _notActivated() error pre-activate (sweeps
  every command's defensive null-context branch in one loop).
- palette.toggle flips the palette's open state.
- sidebar.collapse + context.collapse toggle their slots.
- panel.focus.left / .middle / .right — including the auto-expand
  branches when a focused side is collapsed.
- panel.focusMode toggles focus mode on the active slot.
- panel.focusMode.exit unwinds in order: focus mode → editor → palette,
  with the empty-data no-op fallback.
- editor.open + editor.close including the close-already-closed
  no-op.
- sidebar.section.N: auto-expand sidebar + no-op when no tabs are
  contributed.

Coverage: builtin/default_layout/src/extension.dart 60/167 -> 139/167
(83%). Remaining 28 lines are the _restoreLayout / _persistLayout
persistence paths and the section-activation happy path, which need
a populated tab list + a projectDir on settings to exercise — out
of scope for this batch.

Total coverage 79.80% -> 80.81%; floor bumped to 80.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
 2026-05-13 07:30:52 +02:00
jpmschweitzerandClaude b45699ccd1 fix test suite — green on make test 
tabsFor() sorts by contribution priority when no user order is
set. Test expectations updated for sidebar defaultSize 400 and
decision ID D-1 (no zero-padding). PTY tests tagged forkpty and
run via dart test (forkpty output unreliable inside flutter test
runner). CI script adds --no-fatal-infos and --exclude-tags.

Co-Authored-By: Claude <noreply@anthropic.com>
 2026-05-03 21:52:39 +02:00
jpmschweitzerandClaude Opus 4.6 46329700d5 dissolve app/ into repo root (D-056) 
Single Flutter package at the repo root. All code, tests, assets,
and platform directories moved from app/ to root. Package renamed
from clide_app to clide — all imports rewritten. Merged pubspec
combines core (ffi) and app (flutter, yaml, xterm) dependencies.
Makefile simplified: no APP_PRESENT conditionals, no cd, no daemon
lifecycle. 317 tests pass.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-23 00:37:20 +02:00