Commit Graph
2 Commits
Author SHA1 Message Date
jpmschweitzerandClaude Opus 4.8 6d0ebab721 chore: adopt Dart 3.9 toolchain — honest floor + tall-style reformat (T-353)
Raise the declared minimums in pubspec.yaml to what our deps already
require: Flutter >=3.35.0 / Dart >=3.9.0 (was 3.19.0 / 3.5.0). alchemist
0.12 needs Flutter 3.32; Dart 3.9 first ships in Flutter 3.35, so 3.35 is
the binding floor. Pin the exact build toolchain in .fvmrc (Flutter
3.44.1).

Moving to the Dart 3.9 language level switches `dart format` to the new
"tall" style and enables two new lints. This commit is the resulting
mechanical churn, isolated from any behaviour change:
  - whole-tree `dart format` reformat (tall style)
  - `dart fix` for unnecessary_underscores + use_null_aware_elements

No runtime behaviour change; `make test` green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-11 12:11:53 +02:00
jpmschweitzerandClaude Opus 4.7 aa29f5f3e8 test sweep: cover WelcomeView open-project dialog (T-91) — crosses 90%
test / unit + widget + golden + a11y (push) Failing after 33s
test / integration_test (xvfb) (push) Has been skipped
test / bundle smoke (xvfb 5s) (push) Has been skipped
test / daemon subprocess + web WASM smoke (push) Has been skipped
test / dart doc (lib API) (push) Failing after 1m2s
Four widget tests in test/builtin/welcome/dialog_test.dart driving
the WelcomeView open-folder fallback dialog. Uses a custom harness
that wraps the standard widget harness in a DialogHost so the
kernel.dialog.show() call inside _openFolder actually renders.

- MissingPluginException on pickDirectory → _OpenProjectDialog
  appears with the expected title / hint / Cancel / Open chrome.
- Cancel dismisses the modal cleanly.
- Open with an empty path is a no-op (early return in _submit).
- Open with a non-repo path keeps the dialog (project.open returns
  false, _loading flag flips back).

Coverage clears the **90% T-91 target**: 89.93% -> 90.53%. Floor
bumped to 90.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-14 10:08:40 +02:00