Commit Graph
16 Commits
Author SHA1 Message Date
jpmschweitzerandClaude Opus 4.7 dc86fac85e test sweep: cover SettingsStore project + ext scopes + YAML emitter (T-91)
test / unit + widget + golden + a11y (push) Failing after 32s
test / integration_test (xvfb) (push) Has been skipped
test / bundle smoke (xvfb 5s) (push) Has been skipped
test / daemon subprocess + web WASM smoke (push) Has been skipped
test / dart doc (lib API) (push) Failing after 1m3s
Seven new tests in test/kernel/src/settings_test.dart covering the
SettingsStore branches the existing 6-test suite didn't reach:

- project-scoped set + get round-trip when projectDir is configured
  (covers the project-file readFile branch + the project-scope set
  path).
- setting a project key without a project throws StateError.
- ext.* keys default to app scope; project overrides app when both
  are set (covers the project-overrides-app branch in _lookup).
- setProjectDir(null) clears the in-memory project values.
- YAML emitter handles every scalar branch: bool, num, string
  (simple + special-chars + empty), list (mixed types incl null),
  and round-trips through reload (covers _emitScalar + _emit
  branches for null / List / unknown types).
- load tolerates a malformed YAML file (_readFile catch path).
- load returns empty when file is missing or blank.

Coverage: kernel/src/settings.dart 104/123 -> 112/123 (91%).
Remaining lines are a couple of corner-case formatting paths in
_emit when the top-level value isn't a Map (the public API always
serializes a Map, so they're effectively unreachable through normal
use).

Total coverage 83.85% -> 83.92%.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-13 08:27:04 +02:00
jpmschweitzerandClaude Opus 4.7 e2d98445f5 test sweep: cover ExtensionManager contribution branches + ctx (T-91)
test / unit + widget + golden + a11y (push) Failing after 31s
test / integration_test (xvfb) (push) Has been skipped
test / bundle smoke (xvfb 5s) (push) Has been skipped
test / daemon subprocess + web WASM smoke (push) Has been skipped
test / dart doc (lib API) (push) Failing after 1m2s
Five new tests in test/kernel/src/extensions_manager_test.dart
covering the contribution-type case branches and the _ExtensionContext
passthrough surface that the existing 8-test suite didn't reach:

- TrayItemContribution lands in TrayRegistry on activate; deactivate
  removes it.
- StatusItem + ToolbarButton contributions activate/deactivate
  cleanly through PanelRegistry.
- LayoutPresetContribution exercises the no-kernel-side-wiring case
  branch (consumed by default-layout's own activate()).
- Every _ExtensionContext getter (log / events / messages / settings
  / theme / i18n / panels / arrangement / commands / palette /
  clipboard / files / notify / dialog / tray / secrets / os / net /
  focus / project / ipc) returns the same instance the kernel
  exposes — locks in the passthrough contract.

Coverage: kernel/src/extensions_manager.dart 85/130 -> 122/130
(94%). Remaining 8 lines are the disabled-by-default + persisted-
disabled paths plus the deactivate-during-failed-activate cleanup —
edge cases reachable only when extensions throw.

Total coverage 83.39% -> 83.85%.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-13 08:22:33 +02:00
jpmschweitzerandClaude Opus 4.7 2a7875e1a9 remove OsBridge openURL/reveal tests — they spawn OS popups
test / unit + widget + golden + a11y (push) Failing after 29s
test / integration_test (xvfb) (push) Has been skipped
test / bundle smoke (xvfb 5s) (push) Has been skipped
test / daemon subprocess + web WASM smoke (push) Has been skipped
test / dart doc (lib API) (push) Failing after 1m2s
services_bigger_test.dart's openURL + reveal tests called the real
OsBridge methods, which Process.run xdg-open / open / explorer.
On a desktop session the OS dispatcher (KIO on KDE, etc.) surfaces
a "Could not read file …" error dialog for the bogus URL, owned by
the desktop session not the test process — it persists after the
test exits and a fresh run spawns another one. The user has to
manually close each popup, blocking CI from running unattended.

Coverage value was minimal (anyOf(true, false)). Leaving fire() and
the rest of the OsBridge bus-event surface; command-shape coverage
of openURL/reveal can come from integration tests where a real OS
dispatcher is desired.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-13 08:02:37 +02:00
jpmschweitzerandClaude Opus 4.7 7ba0500f75 test sweep: cover kernel toolchain + medium services (T-91)
test / unit + widget + golden + a11y (push) Failing after 30s
test / bundle smoke (xvfb 5s) (push) Has been skipped
test / integration_test (xvfb) (push) Has been skipped
test / daemon subprocess + web WASM smoke (push) Has been skipped
test / dart doc (lib API) (push) Failing after 1m1s
Two test files chasing the bigger kernel residuals:

- test/kernel/src/toolchain_test.dart (10 tests): Toolchain defaults
  + missing list, applyResolved with full / partial paths,
  waitForResolution sync + async, Toolchain.resolvePaths against the
  current workspace + dugite detection + PATH fallback,
  resolveToolchainPaths top-level matches the static.
- test/kernel/src/services_bigger_test.dart (15 tests): DialogRouter
  show/dismiss/queue/notify, FileServices.pick* UnimplementedError
  trio + notifyDropped event, OsBridge openURL / reveal / fire,
  WindowControls setStyle idempotency + MissingPlugin-safe
  platform-channel methods + isMaximized success path,
  SchedulerTier intervals + SchedulerTick payload + start/dispose.

Coverage: kernel/src/toolchain.dart 37/95 -> 67/95 (71%);
dialog.dart 20/47 -> 27/47 (remaining is the DialogHost widget,
needs a real overlay tree); files.dart 1/16 -> 14/16 (88%);
os.dart 1/26 -> 19/26 (73%); window_controls.dart 2/25 -> 25/25
(100%); scheduler.dart 14/41 -> 18/41 (remaining is the isolate
ticker entry point, only fires after a real project-open event).

Total coverage 82.43% -> 83.57%; floor bumped to 83.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-13 08:00:23 +02:00
jpmschweitzerandClaude Opus 4.7 8efcf186e6 test sweep: cover kernel ProjectManager + RecentProject (T-91)
test / unit + widget + golden + a11y (push) Failing after 31s
test / integration_test (xvfb) (push) Has been skipped
test / bundle smoke (xvfb 5s) (push) Has been skipped
test / daemon subprocess + web WASM smoke (push) Has been skipped
test / dart doc (lib API) (push) Failing after 1m3s
18 tests in test/kernel/src/project_test.dart driving ProjectManager
with an injected onValidateProject hook so the manager doesn't shell
out to git in tests. Covers:

- RecentProject: relativePath HOME collapsing, timeAgo bucketing
  (minutes / hours / yesterday / days / weeks / months), toJson /
  fromJson round-trip, fromJson tolerance for missing fields.
- ProjectManager.open: non-git path (returns false), valid path
  (sets current, emits ProjectOpened, registers in recents),
  re-open deduplication, recents capped at 10.
- ProjectManager.close: resets current, emits ProjectClosed, no-op
  when already closed.
- ProjectManager.loadRecents: happy path, malformed-value tolerance,
  no-setting clears to empty.
- ProjectManager.openLast: no-stored, stored-but-missing,
  stored-and-exists.
- ProjectManager.resolveProject without injected validator falls
  back to Process.run.

Coverage: kernel/src/project.dart 2/72 -> 66/72 (92%). Remaining
6 lines are the _currentBranch helper + ProjectOpened-event-time
branch shake (need a real git in the sandbox to materialise the
branch).

Total coverage 81.64% -> 82.42%; floor bumped to 82.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-13 07:40:12 +02:00
jpmschweitzerandClaude Opus 4.7 2d123681be test sweep: cover kernel Tier-0 service stubs (T-91)
test / unit + widget + golden + a11y (push) Failing after 30s
test / integration_test (xvfb) (push) Has been skipped
test / bundle smoke (xvfb 5s) (push) Has been skipped
test / daemon subprocess + web WASM smoke (push) Has been skipped
test / dart doc (lib API) (push) Failing after 1m1s
19 tests in test/kernel/src/services_stubs_test.dart covering six
small Tier-0 service classes: ClideClipboard (typed write + readAs,
bounded LIFO history, typed history miss, writePlain/readPlain via
mocked platform channel, write-with-toPlain OS sync, clear),
FocusTracker (setActive flip + same-value no-op + clear), NetworkStatus
(default + setState idempotency), SecretsVault (per-extension
isolation, read/write/delete/deleteAll), TrayRegistry (add/remove +
priority sort + unknown-id no-op), Notifications (info/warn/error/
success levels, dismiss + unknown-id no-op).

Coverage: kernel/src/clipboard.dart 1/23 -> 23/23; focus.dart 1/12
-> 12/12; net.dart 0/6 -> 6/6; secrets.dart 0/8 -> 8/8; tray.dart
0/7 -> 7/7; notify.dart 4/23 -> 23/23. All six files now at 100%.

Total coverage 80.81% -> 81.64%; floor bumped to 81.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-13 07:36:22 +02:00
jpmschweitzerandClaude Opus 4.7 3175b7a633 test sweep: cover kernel/src/syntax (T-91)
test / unit + widget + golden + a11y (push) Failing after 31s
test / integration_test (xvfb) (push) Has been skipped
test / bundle smoke (xvfb 5s) (push) Has been skipped
test / daemon subprocess + web WASM smoke (push) Has been skipped
test / dart doc (lib API) (push) Failing after 1m2s
Two test files covering the pure-Dart and fallback paths of the
tree-sitter integration. The native-FFI parsing depth stays
untested — DynamicLibrary.open('libtree-sitter.so') doesn't resolve
under the flutter test runner because the bundled lib sits at
native/linux-x64/ rather than on the linker search path. Real
parsing coverage would need an integration-test harness that copies
or symlinks the lib into the runner's working directory.

- test/kernel/src/syntax/language_map_test.dart (6 tests): every
  branch of grammarForPath — common extensions, case-insensitive
  matching, special filenames (Makefile / Dockerfile / .gitignore /
  justfile), no-dot/no-special-match fallthrough, unknown extension.
- test/kernel/src/syntax/tree_sitter_service_test.dart (9 tests):
  graceful-fallback paths of TreeSitterService when the library
  can't load — hasGrammar / languageFor / highlight all short-
  circuit cleanly, plus SyntaxResult.empty and SyntaxSpan field
  storage.

Coverage: language_map.dart 0/7 -> 7/7; tree_sitter_service.dart
1/131 -> 22/131 (the rest is deep FFI work); tree_sitter_ffi.dart
0/15 -> 1/15 (init entry only).

Total coverage 75.11% -> 75.42%.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-13 06:41:14 +02:00
jpmschweitzerandClaude Opus 4.7 7ad427bd88 test sweep: cover I18n locale getters (T-91)
Adds one test covering the currentLocale / defaultLocale /
availableLocales getters on the I18n class. Existing suite exercised
the lookup behaviour but never read back the three locale fields,
leaving them as the last reachable gaps in lib/kernel/src/i18n/.

Coverage: kernel/src/i18n/i18n.dart 54/58 -> 57/58. The 1 remaining
line is the I18nReplacer const-constructor body (lcov phantom).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-12 11:21:24 +02:00
jpmschweitzerandClaude Opus 4.7 eeb2ee4b82 test sweep: mop up kernel/src/theme residuals (T-91)
test / unit + widget + golden + a11y (push) Failing after 30s
test / integration_test (xvfb) (push) Has been skipped
test / bundle smoke (xvfb 5s) (push) Has been skipped
test / daemon subprocess + web WASM smoke (push) Has been skipped
test / dart doc (lib API) (push) Failing after 1m2s
10 small tests in test/kernel/src/theme/mop_up_test.dart covering the
scattered last-mile gaps across the theme subsystem:

- ClideTheme.of and ClideTheme.controllerOf inherited-widget lookups
  (both happy path + the FlutterError-throw branch when no ancestor).
- contrast._composite alpha-mix branch via a partially-transparent
  foreground in contrastRatio.
- ContrastFailure.toString format with embedded pair name / ratio /
  minimum.
- ThemeLoader.fromYamlString FormatException on a non-map root.
- ThemeLoader.fromFile happy path with a tempdir YAML.
- Palette.names and SemanticRoles.roles iterables.

Coverage: theme/controller.dart 37/42 -> 42/42; theme/contrast.dart
54/64 -> 62/64 (remaining 2 lines are the failingPairs add-to-list
path, needs a constructed-broken SurfaceTokens to fire);
theme/loader.dart 48/54 -> 53/54 (1 const-ctor phantom);
theme/palette.dart 9/10 -> 10/10; theme/semantic.dart 2/3 -> 3/3.

Total coverage 74.55% -> 74.79%.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-12 09:13:43 +02:00
jpmschweitzerandClaude Opus 4.7 c3033fe304 test sweep: cover i18n catalog loaders + theme_picker _pick (T-91)
test / unit + widget + golden + a11y (push) Failing after 32s
test / integration_test (xvfb) (push) Has been skipped
test / bundle smoke (xvfb 5s) (push) Has been skipped
test / daemon subprocess + web WASM smoke (push) Has been skipped
test / dart doc (lib API) (push) Failing after 1m1s
Two test files / batches:

- test/kernel/src/i18n/catalog_loader_test.dart (11 tests): all three
  CatalogLoader implementations end-to-end. AssetCatalogLoader against
  an in-memory AssetBundle covers happy path, FlutterError catch
  (missing asset), FormatException catch (malformed JSON), blank
  asset, non-object JSON. FileCatalogLoader against a tempdir covers
  happy path, missing file, malformed, blank. InMemoryCatalogLoader
  covers lookup + namespace-miss.

- Extends test/builtin/theme_picker/widget_test.dart with two tests
  for the _pick command callback: defensive not-activated branch
  (drive the contribution's run() before activate runs, _ctx is still
  null) and the dialog-resolution happy path (register + activate,
  invoke theme.pick, manually drive dialog.dismiss('forest'), assert
  IpcResponse data['selected']).

Coverage: kernel/src/i18n/catalog_loader.dart 14/26 -> 26/26;
builtin/theme_picker/src/extension.dart 9/18 -> 15/18 (remaining 3
lines are the dialog builder body — needs a DialogHost in the test
harness, out of scope).

Total coverage 74.08% -> 74.55%; floor bumped to 74.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-12 09:03:29 +02:00
jpmschweitzerandClaude Opus 4.7 889058db1b test sweep: cover kernel/src/{events,ipc} (T-91)
test / unit + widget + golden + a11y (push) Failing after 28s
test / integration_test (xvfb) (push) Has been skipped
test / bundle smoke (xvfb 5s) (push) Has been skipped
test / daemon subprocess + web WASM smoke (push) Has been skipped
test / dart doc (lib API) (push) Failing after 1m2s
Three new test files + a small DaemonClient dispose-safety fix:

- test/kernel/src/events/types_test.dart (7 tests): every ClideEvent
  subclass's subsystem / kind / payload contract + the
  ClideEventEnvelope v1 JSON shape.
- test/kernel/src/events/message_bus_test.dart (6 tests): Message
  shape, MessageBus publish/subscribe/dispose, filter-by-publisher,
  filter-by-channel, intersection.
- test/kernel/src/ipc/client_test.dart (9 tests): real Unix-socket
  roundtrip via a _TestDaemon helper — connect + correlate request/
  response, event forwarding to the DaemonBus, malformed-line skip,
  daemon-disconnect failing pending requests, stop cleanup, dispose,
  connect-failure-then-reconnect, daemon-sent-Request warn-and-skip,
  DaemonConnectionChanged emission.

Fix in lib/kernel/src/ipc/client.dart: _setConnected now skips
notifyListeners / event emit when _disposed. The socket stream's
onDone can fire after dispose runs, which previously hit
ChangeNotifier's "used after disposed" assertion. State flip stays
unconditional so stop()'s explicit transition still works.

Coverage: ipc/client.dart 14% -> 92% (79/86; remaining 7 lines are
the socket onError callback + 1 const ctor phantom); events/types
.dart 95% (37/39 — 2 const-ctor phantoms); events/message_bus.dart
100%; events/bus.dart stays 100%.

Total coverage 71.93% -> 73.34%; floor bumped to 73.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-11 19:06:17 +02:00
jpmschweitzerandClaude a5221792ba fix sidebar order and ptyc status bar warning
test / unit + widget + golden + a11y (push) Failing after 29s
test / integration_test (xvfb) (push) Has been skipped
test / bundle smoke (xvfb 5s) (push) Has been skipped
test / daemon subprocess + web WASM smoke (push) Has been skipped
Revert priority sort in tabsFor() — registration order in
main.dart is the intended sidebar order, not priority. The
priority fields on extensions were dead code.

Remove ptyc from toolchain missing list since NativePty
replaced it.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-05-03 22:22:23 +02:00
jpmschweitzerandClaude b45699ccd1 fix test suite — green on make test
tabsFor() sorts by contribution priority when no user order is
set. Test expectations updated for sidebar defaultSize 400 and
decision ID D-1 (no zero-padding). PTY tests tagged forkpty and
run via dart test (forkpty output unreliable inside flutter test
runner). CI script adds --no-fatal-infos and --exclude-tags.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-05-03 21:52:39 +02:00
jpmschweitzerandClaude 9c7ec008dc dart format whole tree
Co-Authored-By: Claude <noreply@anthropic.com>
2026-05-03 21:51:59 +02:00
jpmschweitzerandClaude Opus 4.6 3e1bb27432 split EventBus into DaemonBus + MessageBus
DaemonBus (was EventBus): typed events for system/IPC layer.
MessageBus: channel-based pub/sub for UI/extension coordination.
Messages carry publisher (auto-stamped from extension ID),
channel (required), timestamp, and payload. Subscribe by
publisher, channel, or both — zero collision across extensions.

Extension context gains publish() and subscribe() convenience
methods that auto-stamp the extension's ID as publisher.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-23 15:25:07 +02:00
jpmschweitzerandClaude Opus 4.6 46329700d5 dissolve app/ into repo root (D-056)
Single Flutter package at the repo root. All code, tests, assets,
and platform directories moved from app/ to root. Package renamed
from clide_app to clide — all imports rewritten. Merged pubspec
combines core (ffi) and app (flutter, yaml, xterm) dependencies.
Makefile simplified: no APP_PRESENT conditionals, no cd, no daemon
lifecycle. 317 tests pass.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-23 00:37:20 +02:00