5 Commits

Include renames

Author	SHA1	Message	Date
jpmschweitzerandClaude Opus 4.8	9a8175903b	pql: retry transient db-busy so sidebar panes don't stick (T-350) ... The pql-backed sidebar panes fetch once on first build. If that fetch fired too early — the planning DB still settling at startup, or a db-busy SQLite lock under concurrent pql writes (pql exits 69) — the pane showed "pql … failed" and stayed there until a manual refresh re-fired it. Retry transient failures at the single chokepoint, PqlClient._run: on a busy/locked signal (exit 69, or stderr mentioning database is locked / busy) retry a few times with short backoff before throwing. Genuine errors aren't busy, so they still surface immediately. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-06-10 20:20:36 +02:00
jpmschweitzerandClaude Opus 4.8	ceaa8392d7	serialize real-pql tests to fix parallel db contention ... The pql integration tests (test/pql/client_test.dart) and pql.* daemon handler tests (test/daemon/pql_commands_test.dart) each spawn a real `pql` process against the shared on-disk .pql/pql.db. In the parallel test pool, concurrent invocations contend for the SQLite lock and flake with PqlException(69) (db busy) — surfaced reliably by the pql 1.10 record_id migration. They pass one-at-a-time, so isolation is the fix. Tag both files @Tags(['serial']) and add a --concurrency=1 serial pass to ci/test_core.sh (pty + serial together), mirroring ci/test.sh's existing serial handling. The error-path companion uses a fake binary, so it stays parallel. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-06-10 10:01:15 +02:00
jpmschweitzerandClaude Opus 4.7	70ce6c270e	fix untrusted-workspace RCE in dugite git resolution (T-98) ... Drop the workspaceRoot parameter from resolveToolchainPaths / Toolchain.resolvePaths entirely. The old code resolved \`<workspaceRoot>/native/dugite/bin/git\` as the git binary before falling back to PATH — a malicious repo could commit an executable at that path and clide would run it on the first auto-fired git.status (which fires automatically on workspace open). Dugite now resolves against trusted locations only: 1. CLIDE_DUGITE_DIR env var (dev override). 2. <exe-parent>/dugite/bin/git (production bundle). 3. <exe-parent>/lib/dugite/bin/git (alternate bundle layout). Test plants `native/dugite/bin/git` in a temp workspace and asserts the resolved git path is NOT inside the workspace. Callers updated (8 sites): main.dart, backend_entry.dart twice, test_app.dart three times (compute now wraps a no-arg call), plus five test fixtures. backend.dart's now-vestigial hintRoot left in the struct for cleanup under T-99. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-17 20:56:02 +02:00
jpmschweitzerandClaude	5cad98224f	keep the clide.dart barrel Flutter-free ... `lib/kernel/src/toolchain.dart` is a `ChangeNotifier`, so it pulls in `package:flutter/foundation.dart`. `GitClient` and `PqlClient` imported it for the resolved binary paths, which leaked Flutter through the `package:clide/clide.dart` barrel — breaking `dart test` on every core subsystem suite (`ci/test_core.sh`), since pure Dart can't compile Flutter packages. Split the Flutter-free pieces into `toolchain_paths.dart`: `ResolvedPaths`, `resolveToolchainPaths`, and a new read-only `ToolchainView` interface with a `ToolchainView.resolved()` const factory. `Toolchain` now implements `ToolchainView`; the clients depend on the interface. Core test setups that built a `Toolchain` just to call `applyResolved` switch to the factory. Co-Authored-By: Claude <noreply@anthropic.com>	2026-05-14 21:21:09 +02:00
jpmschweitzerandClaude Opus 4.7	8d98efc900	test sweep: cover src/pql/client.dart (T-91) ... 18 integration tests in test/pql/client_test.dart driving the real pql 1.4.30 binary against the clide vault. Covers the methods the existing test/daemon/pql_commands_test suite didn't reach: backlinks, tags, query, search, decisionValidate, decisionRead, decisionList with filters, decisionShow with --with-refs / --with-tickets, ticketList with status / team / assigned / decision filters, ticketShow with --with-context / --with-blockers, ticketBoard with --team. Plus PqlException.toString and the two error paths in _run (ProcessException from a bad binary path, non-zero exit code from the validator). Coverage: src/pql/client.dart 43/92 -> 89/92 (97%). The 3 remaining lines are an unreachable null-coalesce branch in _runList and PqlException's field initialisers (lcov phantom). Total coverage 73.34% -> 73.88%. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-11 19:11:52 +02:00