4 Commits

Include renames

Author	SHA1	Message	Date
jpmschweitzerandClaude Opus 4.8	6d0ebab721	chore: adopt Dart 3.9 toolchain — honest floor + tall-style reformat (T-353) ... Raise the declared minimums in pubspec.yaml to what our deps already require: Flutter >=3.35.0 / Dart >=3.9.0 (was 3.19.0 / 3.5.0). alchemist 0.12 needs Flutter 3.32; Dart 3.9 first ships in Flutter 3.35, so 3.35 is the binding floor. Pin the exact build toolchain in .fvmrc (Flutter 3.44.1). Moving to the Dart 3.9 language level switches `dart format` to the new "tall" style and enables two new lints. This commit is the resulting mechanical churn, isolated from any behaviour change: - whole-tree `dart format` reformat (tall style) - `dart fix` for unnecessary_underscores + use_null_aware_elements No runtime behaviour change; `make test` green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-06-11 12:11:53 +02:00
jpmschweitzerandClaude Opus 4.7	e430a87569	test sweep: kernel commands + widgets coverage, ratchet floor to 93 ... Add tests for `keybindings.dart` (KeyEvent → Keybinding mapping, parse-error edges, resolver entries view), `toolchain_paths.dart` (the Flutter-free `ToolchainView.resolved` static view), and several `widgets/src/` primitives: tooltip hover/overlay, palette filter + submit, multitab controller `copyWith` + size getters, and additional markdown branches (h3–h6 headings, tables, strikethrough, default block fallback, record-link tap). Unfreezes the pre-push coverage floor that was held at 90 on 2026-05-14 by mistake and ratchets to 93. Tidies eight test files that had accumulated unused imports flagged by `unnecessary_import`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-17 20:20:37 +02:00
jpmschweitzerandClaude	5cad98224f	keep the clide.dart barrel Flutter-free ... `lib/kernel/src/toolchain.dart` is a `ChangeNotifier`, so it pulls in `package:flutter/foundation.dart`. `GitClient` and `PqlClient` imported it for the resolved binary paths, which leaked Flutter through the `package:clide/clide.dart` barrel — breaking `dart test` on every core subsystem suite (`ci/test_core.sh`), since pure Dart can't compile Flutter packages. Split the Flutter-free pieces into `toolchain_paths.dart`: `ResolvedPaths`, `resolveToolchainPaths`, and a new read-only `ToolchainView` interface with a `ToolchainView.resolved()` const factory. `Toolchain` now implements `ToolchainView`; the clients depend on the interface. Core test setups that built a `Toolchain` just to call `applyResolved` switch to the factory. Co-Authored-By: Claude <noreply@anthropic.com>	2026-05-14 21:21:09 +02:00
jpmschweitzerandClaude Opus 4.7	91128a8f7f	test sweep: cover daemon pql/git command exception branches (T-91) ... Two fault-injection test files driving every pql.* and git.* daemon handler with a Client whose toolchain points at a non-existent binary. Each underlying Process.run throws ProcessException → wrapped as PqlException / GitException → the handler's catch branch fires and surfaces a toolError IpcResponse. - pql_commands_errors_test (18 cases): every pql.* command lands in the catch + _pqlError helper. - git_commands_errors_test (14 cases): every git.* command lands in the catch + _gitError helper. Skipped: stage-hunk + unstage-hunk which go through GitClient._applyPatch (uses Process.start, throws ProcessException directly without rewrapping in GitException). Coverage: src/daemon/pql_commands.dart 105/149 -> 148/149 (99%); src/daemon/git_commands.dart 122/146 -> 142/146 (97%). Total coverage 91.59% -> 92.33%; floor bumped to 92. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-14 13:14:20 +02:00