Commit Graph
13 Commits
Author SHA1 Message Date
jpmschweitzerandClaude Opus 4.7 e430a87569 test sweep: kernel commands + widgets coverage, ratchet floor to 93
Add tests for `keybindings.dart` (KeyEvent → Keybinding mapping,
parse-error edges, resolver entries view), `toolchain_paths.dart`
(the Flutter-free `ToolchainView.resolved` static view), and several
`widgets/src/` primitives: tooltip hover/overlay, palette filter +
submit, multitab controller `copyWith` + size getters, and additional
markdown branches (h3–h6 headings, tables, strikethrough, default
block fallback, record-link tap).

Unfreezes the pre-push coverage floor that was held at 90 on
2026-05-14 by mistake and ratchets to 93. Tidies eight test files
that had accumulated unused imports flagged by `unnecessary_import`.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-17 20:20:37 +02:00
jpmschweitzerandClaude Opus 4.7 aa29f5f3e8 test sweep: cover WelcomeView open-project dialog (T-91) — crosses 90%
test / unit + widget + golden + a11y (push) Failing after 33s
test / integration_test (xvfb) (push) Has been skipped
test / bundle smoke (xvfb 5s) (push) Has been skipped
test / daemon subprocess + web WASM smoke (push) Has been skipped
test / dart doc (lib API) (push) Failing after 1m2s
Four widget tests in test/builtin/welcome/dialog_test.dart driving
the WelcomeView open-folder fallback dialog. Uses a custom harness
that wraps the standard widget harness in a DialogHost so the
kernel.dialog.show() call inside _openFolder actually renders.

- MissingPluginException on pickDirectory → _OpenProjectDialog
  appears with the expected title / hint / Cancel / Open chrome.
- Cancel dismisses the modal cleanly.
- Open with an empty path is a no-op (early return in _submit).
- Open with a non-repo path keeps the dialog (project.open returns
  false, _loading flag flips back).

Coverage clears the **90% T-91 target**: 89.93% -> 90.53%. Floor
bumped to 90.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-14 10:08:40 +02:00
jpmschweitzerandClaude Opus 4.7 3339d3fcb5 test sweep: cover default_layout commands (T-91)
test / unit + widget + golden + a11y (push) Failing after 31s
test / integration_test (xvfb) (push) Has been skipped
test / bundle smoke (xvfb 5s) (push) Has been skipped
test / daemon subprocess + web WASM smoke (push) Has been skipped
test / dart doc (lib API) (push) Failing after 1m1s
Eight new tests in test/builtin/default_layout/widget_test.dart
covering the DefaultLayoutExtension command handlers the existing
four-test suite didn't reach:

- All commands return the _notActivated() error pre-activate (sweeps
  every command's defensive null-context branch in one loop).
- palette.toggle flips the palette's open state.
- sidebar.collapse + context.collapse toggle their slots.
- panel.focus.left / .middle / .right — including the auto-expand
  branches when a focused side is collapsed.
- panel.focusMode toggles focus mode on the active slot.
- panel.focusMode.exit unwinds in order: focus mode → editor → palette,
  with the empty-data no-op fallback.
- editor.open + editor.close including the close-already-closed
  no-op.
- sidebar.section.N: auto-expand sidebar + no-op when no tabs are
  contributed.

Coverage: builtin/default_layout/src/extension.dart 60/167 -> 139/167
(83%). Remaining 28 lines are the _restoreLayout / _persistLayout
persistence paths and the section-activation happy path, which need
a populated tab list + a projectDir on settings to exercise — out
of scope for this batch.

Total coverage 79.80% -> 80.81%; floor bumped to 80.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-13 07:30:52 +02:00
jpmschweitzerandClaude Opus 4.7 3a6e906dc1 test sweep: cover welcome_view tail paths (T-91)
test / unit + widget + golden + a11y (push) Failing after 31s
test / integration_test (xvfb) (push) Has been skipped
test / bundle smoke (xvfb 5s) (push) Has been skipped
test / daemon subprocess + web WASM smoke (push) Has been skipped
test / dart doc (lib API) (push) Failing after 1m2s
Eight new widget tests in test/builtin/welcome/widget_test.dart
covering the WelcomeView paths the existing render-it test didn't
reach:

- TIPS card visibility: shown when viewport height > 640, hidden
  when shorter (LayoutBuilder branch).
- Status line tri-state: "checking…" before toolchain resolution,
  "application ok" when all tools present, missing-tools listing
  when some are absent.
- Theme-name link tap fires the theme.pick command via the registry.
- Open folder tap with no native picker (returns null, function
  returns early) and with MissingPluginException (falls through to
  the path dialog via kernel.dialog.show).

Coverage: builtin/welcome/src/welcome_view.dart 84/221 -> 120/221
(54%). Remaining 101 lines are inside the _OpenProjectDialog,
_NotARepoDialog, and recent-project rows — they need either a
DialogHost in the test harness or a populated recents list, which
is materially more setup than the rest of this batch's pattern.

Total coverage 79.34% -> 79.80%.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-13 07:25:17 +02:00
jpmschweitzerandClaude Opus 4.7 c3033fe304 test sweep: cover i18n catalog loaders + theme_picker _pick (T-91)
test / unit + widget + golden + a11y (push) Failing after 32s
test / integration_test (xvfb) (push) Has been skipped
test / bundle smoke (xvfb 5s) (push) Has been skipped
test / daemon subprocess + web WASM smoke (push) Has been skipped
test / dart doc (lib API) (push) Failing after 1m1s
Two test files / batches:

- test/kernel/src/i18n/catalog_loader_test.dart (11 tests): all three
  CatalogLoader implementations end-to-end. AssetCatalogLoader against
  an in-memory AssetBundle covers happy path, FlutterError catch
  (missing asset), FormatException catch (malformed JSON), blank
  asset, non-object JSON. FileCatalogLoader against a tempdir covers
  happy path, missing file, malformed, blank. InMemoryCatalogLoader
  covers lookup + namespace-miss.

- Extends test/builtin/theme_picker/widget_test.dart with two tests
  for the _pick command callback: defensive not-activated branch
  (drive the contribution's run() before activate runs, _ctx is still
  null) and the dialog-resolution happy path (register + activate,
  invoke theme.pick, manually drive dialog.dismiss('forest'), assert
  IpcResponse data['selected']).

Coverage: kernel/src/i18n/catalog_loader.dart 14/26 -> 26/26;
builtin/theme_picker/src/extension.dart 9/18 -> 15/18 (remaining 3
lines are the dialog builder body — needs a DialogHost in the test
harness, out of scope).

Total coverage 74.08% -> 74.55%; floor bumped to 74.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-12 09:03:29 +02:00
jpmschweitzerandClaude Opus 4.7 5dcd76a9a9 test sweep: cover builtin/ipc_status (T-91)
test / unit + widget + golden + a11y (push) Failing after 29s
test / integration_test (xvfb) (push) Has been skipped
test / bundle smoke (xvfb 5s) (push) Has been skipped
test / daemon subprocess + web WASM smoke (push) Has been skipped
test / dart doc (lib API) (push) Failing after 1m2s
Four new widget tests in test/builtin/ipc_status/widget_test.dart
covering the toolchain-state branches of ToolStatusItem and the
StatusItemContribution build callback:

- unresolved toolchain → SizedBox.shrink (no chip text rendered)
- all tools resolved → single "application ok" chip
- some tools missing → one warning chip per missing tool
- StatusItemContribution.build returns a ToolStatusItem widget

Coverage: builtin/ipc_status/src/status_item.dart 9/22 -> 22/22;
builtin/ipc_status/src/extension.dart 6/7 -> 7/7. Both at 100%.
Total 73.88% -> 73.99%.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-11 22:23:17 +02:00
jpmschweitzerandClaude 26cc1b3154 drop redundant single-symbol imports across the tree
12 imports flagged by `unnecessary_import` because the symbols
they bring in are also re-exported by the umbrella import already
present in the same file:

- bin/clide.dart: src/git/client.dart, src/pql/client.dart
  (covered by package:clide/clide.dart).
- lib/builtin/decisions/, lib/builtin/tickets/ (4 files):
  kernel/src/events/message_bus.dart (covered by kernel.dart).
- lib/kernel/src/ipc/in_process.dart: src/daemon/dispatcher.dart
  (covered by clide.dart).
- lib/main.dart: kernel/src/toolchain.dart (covered by kernel.dart).
- test/builtin/ipc_status/widget_test.dart:
  builtin/ipc_status/src/status_item.dart (covered by
  ipc_status.dart).
- test/daemon/{git,pql}_commands_test.dart: src/git/client.dart and
  src/pql/client.dart (covered by clide.dart).
- test/widgets/multitab_pane_test.dart: widgets/src/icons/x.dart
  (covered by widgets.dart).

Mechanical change — every removed line was already a no-op for
symbol resolution; the umbrella imports define the public surface
each file is actually using.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-05-06 23:46:24 +02:00
jpmschweitzerandClaude 6601056972 finish T-87: cold-start reap, kill-all-sessions, helper tests
Three remaining acceptance criteria for T-87:

1. Cold-start reap. The Claude extension's activate() now kills
   every leftover secondary tmux session for the current repo
   before any new spawn. activate runs before any UI mounts, so
   _nextSecondary's starting value of 1 is correct even when a
   previous run died abruptly (kill -9, OOM, force-quit). The
   deactivate() hook also calls reapSecondaries as a courtesy on
   explicit extension teardown — but Flutter's deactivate doesn't
   fire on app quit, so activate is the load-bearing path.

2. claude.kill-all-sessions actually kills server-side. The
   command previously called pane.close on every claude pane,
   which only kills the tmux client. It now also calls
   tmux.killAllForRepo to kill the sessions on the clide socket.

3. Tests. test/builtin/claude/tmux_session_test.dart covers
   killSession, listClideSessions, reapSecondaries, and
   killAllForRepo via the TmuxRunner override — no real shell-out
   in tests.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-05-06 16:48:06 +02:00
jpmschweitzerandClaude 5f162a6668 rename tagline to "IDE for Claude Code CLI"
clide is an IDE for the Claude Code CLI. The previous tagline
"Flutter desktop IDE for Claude Code" overemphasized the host
toolkit (Flutter is implementation detail, immediately obvious to
contributors) and was ambiguous about whether the integration
target is the CLI specifically.

Updates the welcome subtitle (i18n catalog + widget test + view),
the project description in pubspec.yaml, README and CLAUDE.md, the
CLI banner, and the web manifest/index.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-05-06 11:06:41 +02:00
jpmschweitzerandClaude b45699ccd1 fix test suite — green on make test
tabsFor() sorts by contribution priority when no user order is
set. Test expectations updated for sidebar defaultSize 400 and
decision ID D-1 (no zero-padding). PTY tests tagged forkpty and
run via dart test (forkpty output unreliable inside flutter test
runner). CI script adds --no-fatal-infos and --exclude-tags.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-05-03 21:52:39 +02:00
jpmschweitzerandClaude 9c7ec008dc dart format whole tree
Co-Authored-By: Claude <noreply@anthropic.com>
2026-05-03 21:51:59 +02:00
jpmschweitzerandClaude Opus 4.6 3df0a3f026 replace daemon indicator with ptyc/pql tool status
The status bar now shows whether ptyc and pql are findable on PATH
(green = found, amber = missing) instead of the obsolete daemon
connection state. Per D-056 there is no daemon to connect to.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-23 00:43:18 +02:00
jpmschweitzerandClaude Opus 4.6 46329700d5 dissolve app/ into repo root (D-056)
Single Flutter package at the repo root. All code, tests, assets,
and platform directories moved from app/ to root. Package renamed
from clide_app to clide — all imports rewritten. Merged pubspec
combines core (ffi) and app (flutter, yaml, xterm) dependencies.
Makefile simplified: no APP_PRESENT conditionals, no cd, no daemon
lifecycle. 317 tests pass.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-23 00:37:20 +02:00