4 Commits

Include renames

Author	SHA1	Message	Date
jpmschweitzerandClaude	c4bccd35a3	T-124: unix-domain IPC server, wired into Flutter app boot ... First slice of T-99 (the D-56-path-a IPC server). What this lands: * lib/src/ipc/paths.dart rewritten — `workspaceSocketPath(root)` returns the per-workspace path per D-70 (FNV-1a 64-bit hash, hex, no crypto dep — D-70 amended in this commit to record the hash choice). Old `defaultSocketPath()` removed; the lone fallback in facade.dart kept with a clear placeholder pending T-127. * lib/src/ipc/server.dart — IpcServer class. ServerSocket.listen accept loop (D-72), 0600 socket + 0700 parent (D-71), stale-node probe + unlink on start, refuses to clobber a live listener. * lib/main.dart — IpcServer started after the first dispatcher is built and swapped on project open (workspace path changes). Failure logged but non-fatal so the UI still works without IPC. * 11 server tests + 5 path tests cover socket modes, multi-conn, stale unlink, live-conflict, idempotent start/stop. T-99 children downstream of T-124 (T-125 / T-126 / T-127 / T-130) are now unblocked. Co-Authored-By: Claude <noreply@anthropic.com>	2026-05-18 14:51:35 +02:00
jpmschweitzerandClaude	2b93bb1cb2	D-70/71/72: lock in the T-99 IPC server architecture choices ... Three architectural commitments T-124 needs settled before any code: * D-70 — socket path is per-workspace and deterministic (`$XDG_RUNTIME_DIR/clide/<sha256(workspace)[:16]>.sock`). No env override; matches the per-repo tmux socket pattern (D-41) so users see one consistent shape across clide's process boundaries. * D-71 — file permissions are the only gate: `0600` on the socket, `0700` on the parent. Capability-token auth stays a Tier-6 concern tracked by Q-1. * D-72 — multi-connection accept loop, serial dispatch on the main Flutter isolate. Per-handler isolate offload (the NativePty / SchedulerService pattern) is available where it matters; the IPC layer doesn't impose isolate-safety across every subsystem. T-124's description updated to inline the three decisions so the implementer starts with the contract, not a discovery pass. Co-Authored-By: Claude <noreply@anthropic.com>	2026-05-18 14:43:09 +02:00
jpmschweitzerandClaude Opus 4.7	8074bf4201	replace forkpty() with posix_openpt() + posix_spawn() (T-96) ... `forkpty` calls `fork()` underneath. `fork()` in a multithreaded process is unsafe: only the calling thread survives in the child, but libc locks held by other threads remain "locked forever." With the multi-threaded Dart VM as parent, ~5% of spawns deadlocked in the child before `execve` (forensic probe: child stuck in S state with comm=`DartWorker`, master fd never sees POLLIN). `posix_spawn` uses `vfork` on glibc/musl/macOS, keeping the parent suspended until execve completes — no Dart code runs in the child. Pty pair built via the POSIX-standard `posix_openpt` / `grantpt` / `unlockpt` / `ptsname` sequence. Probed: zero hangs in 300 sequential spawns vs ~5% before. Behavior change: missing executable / missing workingDirectory now surface as a `PtyException` thrown by `NativePty.start` rather than a diagnostic written from the child to the slave PTY. Cleaner error path for callers. Side benefit: drops the `libutil.so.1` dynamic-library dependency. PTY now resolves entirely against libc via `DynamicLibrary.process()`. Splits the library-level `@Tags(['forkpty'])` on session_test.dart into a per-test tag, so the now-runnable-under-flutter-test cases contribute to coverage. `dart_test.yaml` declares the tag so the exclude-tags filters honor it. Drops the `retry: 2` workaround from the formerly-flaky registry test. D-5 amended. Trims session-introduced CHANGELOG entries that were over-verbose for the Keep-a-Changelog format. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-17 20:21:41 +02:00
jpmschweitzerandClaude	63195d1ec8	migrate DQR tree to governance/ layout (pql D-21) ... pql 1.4.30 introduces a per-type subdirectory layout for decision records: governance/{decisions,questions,rejected}/<domain>.md. The parser infers record type from the parent subdir and domain from the filename stem, replacing the flat decisions/<file>.md layout with questions-X and rejected prefixes. Moves: - 6 D-files to governance/decisions/ (accessibility, architecture, extensions, process, testing, tooling) - 5 Q-files to governance/questions/ (stripped the questions- prefix) - rejected.md split by domain to governance/rejected/{architecture (5), process (4), accessibility (1), testing (1)}.md — split per cross-reference target. Drops: - decisions/README.md (auto-regenerated as governance/README.md by pql init below the records marker) - decisions/questions.md (hand-curated index pointing at the per- domain files; redundant once pql generates the index, and the "load-bearing" curation was already present in each Q-record's Context field). Convention-driven; not a clide-specific change. Counts unchanged across migration: 106 decisions, 95 tickets, 134 refs, 0 broken. Co-Authored-By: Claude <noreply@anthropic.com>	2026-05-11 18:34:20 +02:00