3 Commits

Include renames

Author	SHA1	Message	Date
jpmschweitzerandClaude	b6eef3fc2b	add a serial test lane for concurrency-vulnerable tests ... Generalizes the pty split into an explicit "parallel=false" opt-out: a `serial` tag (declared in dart_test.yaml). The parallel flutter run now excludes `pty || serial`; a separate `flutter test --tags serial --concurrency=1` pass runs the vulnerable ones. For the coverage gate the two passes are real-merged by ci/merge_lcov.py (union DA, max hits, recompute LF/LH) — a plain concat would double-count and corrupt the total. Tag transcript_publisher's bus-republish test serial (it flaked in the parallel pool). Gate verified green end-to-end at 95.08%. T-193. Co-Authored-By: Claude <noreply@anthropic.com>	2026-05-31 19:26:17 +02:00
jpmschweitzerandClaude Opus 4.7	b224502658	rename stale forkpty test tag to pty ... forkpty was replaced by posix_openpt + posix_spawn in T-96, but the test tag, ci/test.sh segregation, and dart_test.yaml comment kept the forkpty name. The segregation is still required — verified the PTY tests fail under the flutter-test runner (the master fd doesn't reliably deliver output there) but pass under dart test — only the name was wrong. Rename to `pty` and correct the rationale comment. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-23 08:49:13 +02:00
jpmschweitzerandClaude Opus 4.7	8074bf4201	replace forkpty() with posix_openpt() + posix_spawn() (T-96) ... `forkpty` calls `fork()` underneath. `fork()` in a multithreaded process is unsafe: only the calling thread survives in the child, but libc locks held by other threads remain "locked forever." With the multi-threaded Dart VM as parent, ~5% of spawns deadlocked in the child before `execve` (forensic probe: child stuck in S state with comm=`DartWorker`, master fd never sees POLLIN). `posix_spawn` uses `vfork` on glibc/musl/macOS, keeping the parent suspended until execve completes — no Dart code runs in the child. Pty pair built via the POSIX-standard `posix_openpt` / `grantpt` / `unlockpt` / `ptsname` sequence. Probed: zero hangs in 300 sequential spawns vs ~5% before. Behavior change: missing executable / missing workingDirectory now surface as a `PtyException` thrown by `NativePty.start` rather than a diagnostic written from the child to the slave PTY. Cleaner error path for callers. Side benefit: drops the `libutil.so.1` dynamic-library dependency. PTY now resolves entirely against libc via `DynamicLibrary.process()`. Splits the library-level `@Tags(['forkpty'])` on session_test.dart into a per-test tag, so the now-runnable-under-flutter-test cases contribute to coverage. `dart_test.yaml` declares the tag so the exclude-tags filters honor it. Drops the `retry: 2` workaround from the formerly-flaky registry test. D-5 amended. Trims session-introduced CHANGELOG entries that were over-verbose for the Keep-a-Changelog format. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-17 20:21:41 +02:00