route editor config through a source-agnostic EditorSettings model (T-29)

Introduce EditorSettings as the effective, source-agnostic editor configuration
the editor and save path obey. .editorconfig is demoted to one *source*
(editorconfig.dart now returns EditorSettings); editor_settings_resolver.dart is
the single composition seam where future sources — a settings panel, a clide
settings file — layer in via merge() without the editor changing.

The registry resolves settings on buffer load and, when a .editorconfig is saved
in-app, re-resolves every open buffer and emits editor.settings-changed (a hook
in save, not a filesystem watcher — the realistic case, cheaply). Buffer JSON
carries editorSettings. 100% line coverage on the new model + resolver.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-06-09 09:15:49 +02:00
co-authored by Claude Opus 4.8
parent 55c66601c3
commit d4b39e430a
10 changed files with 438 additions and 277 deletions
+21 -4
View File
@@ -153,13 +153,13 @@ void main() {
});
group('.editorconfig (T-29)', () {
test('open resolves the editorconfig for the file', () async {
test('open resolves the settings for the file', () async {
await File('${sandbox.path}/.editorconfig').writeAsString('root = true\n[*]\nindent_style = space\nindent_size = 2\n');
final buf = await reg.open('README.md');
expect(buf.editorConfig.indentStyle, 'space');
expect(buf.editorConfig.indentSize, 2);
expect(buf.settings.indentStyle, 'space');
expect(buf.settings.indentSize, 2);
// Exposed over IPC for the UI.
expect(buf.toJson()['editorConfig'], {'indent_style': 'space', 'indent_size': 2, 'tab_width': 2});
expect(buf.toJson()['editorSettings'], {'indent_style': 'space', 'indent_size': 2, 'tab_width': 2});
});
test('save trims trailing whitespace + adds a final newline on disk', () async {
@@ -197,5 +197,22 @@ void main() {
expect(sink.ofKind('editor.edited'), isEmpty); // nothing to reconcile
expect(sink.ofKind('editor.saved'), hasLength(1));
});
test('saving a .editorconfig re-resolves open buffers and notifies', () async {
// README opens with no rules in effect.
final readme = await reg.open('README.md');
expect(readme.settings.indentSize, isNull);
// Author a .editorconfig in the editor and save it.
final cfg = await reg.open('.editorconfig');
reg.setContent(cfg.id, 'root = true\n[*]\nindent_size = 4\n');
sink.events.clear();
await reg.save(cfg.id);
// The open README picks up the new rules without reopening.
expect(readme.settings.indentSize, 4);
final changed = sink.ofKind('editor.settings-changed');
expect(changed.map((e) => e.data['id']), contains(readme.id));
});
});
}