jpmschweitzer/clide
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(ipc): sweep dead orphan sockets from the runtime dir on startup (T-247)

Browse Source 
The runtime socket dir accumulated orphaned *.sock nodes from crashed
instances — only the current workspace's own path was ever cleaned. Add a
best-effort startup sweep that probes every *.sock in the dir and unlinks
only the dead ones; live instances (something answers) and unresponsive
nodes (possibly hung) are left alone. Runs before bind, alongside the
existing per-workspace stale-unlink. Never blocks our own startup on a
sweep failure.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
jpmschweitzer
2026-06-27 08:15:05 +02:00
co-authored by Claude Opus 4.8
parent 6af980f31c
commit ceab497ba8
3 changed files with 64 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/ipc/server_test.dart
+24
View File
@@ -146,6 +146,30 @@ void main() {
expect(() async => other.start(), throwsA(isA<StateError>()));
});
test('startup sweeps dead orphan sockets from the runtime dir, keeps live ones (T-247)', () async {
final socketDir = Directory(File(workspaceSocketPath(workRoot)).parent.path);
socketDir.createSync(recursive: true);
final uniq = DateTime.now().microsecondsSinceEpoch;
// A dead orphan (a socket node with no listener) and a live orphan
// (a real listener for some other "workspace"). Unique names so the
// assertions don't depend on whatever else is in the shared runtime dir.
final dead = File('${socketDir.path}/clide-sweep-dead-$uniq.sock')..writeAsBytesSync([]);
final livePath = '${socketDir.path}/clide-sweep-live-$uniq.sock';
final live = await ServerSocket.bind(InternetAddress(livePath, type: InternetAddressType.unix), 0);
addTearDown(() async {
await live.close();
for (final p in [livePath, dead.path]) {
if (File(p).existsSync()) File(p).deleteSync();
}
});
server = IpcServer(dispatcher: dispatcher, workspaceRoot: workRoot, log: _silentLog());
await server.start();
expect(dead.existsSync(), isFalse, reason: 'a dead orphan should be swept on startup');
expect(File(livePath).existsSync(), isTrue, reason: 'a live instance must be left untouched');
});
test('start is idempotent: second call on the same instance is a no-op', () async {
server = IpcServer(dispatcher: dispatcher, workspaceRoot: workRoot, log: _silentLog());
await server.start();