vim ctrl+w window-command family + global multi-chord matcher (T-404)
The structural piece: a global SequenceMatcher in root_shell, at the HardwareKeyboard level so a focused editor/pane can't swallow the second chord. It only STARTS on a modified chord that prefixes a sequence (ctrl+w), so bare-key sequences (gg, dd) stay editor/pane-local and single-chord presets are untouched; bare ctrl+w still fires editor.close after the D-82 timeout. vim.yaml binds the window family under vim.normal||vim.visual: ctrl+w h/l → panel.focus.left/right, j → dock.toggle, w / ctrl+w → focus.nextPanel, shift+w → focus.previousPanel, o → panel.focusMode, q/c → editor.close. Tests: ctrl+w sequence resolution at the keymap layer, plus app-level integration (ctrl+w o toggles focus mode; bare ctrl+w closes the editor after the timeout; a bare g is not grabbed globally). This is the global matcher T-405 part 2 (gt/gT) was waiting on — though bare-g sequences need more thought (g is editor-local), noted for that follow-up. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -236,6 +236,58 @@ void main() {
|
||||
expect(tester.takeException(), isNull);
|
||||
});
|
||||
|
||||
testWidgets('ctrl+w o fires a window command via the global matcher, not editor.close (T-404)', (tester) async {
|
||||
await tester.runAsync(() => f.services.keymap.setPreset('vim'));
|
||||
f.services.keymap.setScopeFlag('vim.normal', true);
|
||||
addTearDown(() => f.services.keymap.clearScopeFlag('vim.normal'));
|
||||
await pumpApp(tester);
|
||||
expect(f.services.arrangement.isInFocusMode, isFalse);
|
||||
|
||||
// ctrl+w (chord) then a BARE o → panel.focusMode. The second chord is
|
||||
// consumed at the hardware level, so a focused pane can't swallow it.
|
||||
await tester.sendKeyDownEvent(LogicalKeyboardKey.controlLeft);
|
||||
await tester.sendKeyEvent(LogicalKeyboardKey.keyW);
|
||||
await tester.sendKeyUpEvent(LogicalKeyboardKey.controlLeft);
|
||||
await tester.sendKeyEvent(LogicalKeyboardKey.keyO);
|
||||
await tester.pump();
|
||||
|
||||
expect(f.services.arrangement.isInFocusMode, isTrue);
|
||||
});
|
||||
|
||||
testWidgets('bare ctrl+w closes the editor after the ambiguity timeout (T-404)', (tester) async {
|
||||
await tester.runAsync(() => f.services.keymap.setPreset('vim'));
|
||||
f.services.keymap.setScopeFlag('vim.normal', true);
|
||||
addTearDown(() => f.services.keymap.clearScopeFlag('vim.normal'));
|
||||
await pumpApp(tester);
|
||||
f.services.arrangement.openEditor();
|
||||
expect(f.services.arrangement.editorOpen, isTrue);
|
||||
|
||||
// ctrl+w with no completing chord: pends, then the timeout flushes the
|
||||
// exact bare-ctrl+w binding (editor.close from the contributions layer).
|
||||
await tester.sendKeyDownEvent(LogicalKeyboardKey.controlLeft);
|
||||
await tester.sendKeyEvent(LogicalKeyboardKey.keyW);
|
||||
await tester.sendKeyUpEvent(LogicalKeyboardKey.controlLeft);
|
||||
await tester.pump(const Duration(milliseconds: 450));
|
||||
|
||||
expect(f.services.arrangement.editorOpen, isFalse);
|
||||
});
|
||||
|
||||
testWidgets('a bare-key sequence prefix (g) is not grabbed by the global matcher (T-404)', (tester) async {
|
||||
await tester.runAsync(() => f.services.keymap.setPreset('vim'));
|
||||
f.services.keymap.setScopeFlag('vim.normal', true);
|
||||
addTearDown(() => f.services.keymap.clearScopeFlag('vim.normal'));
|
||||
await pumpApp(tester);
|
||||
f.services.arrangement.openEditor();
|
||||
|
||||
// `g` is a prefix (gg) but bare → editor/pane-local. The global matcher must
|
||||
// NOT consume it or fire a window command; the editor stays open.
|
||||
await tester.sendKeyEvent(LogicalKeyboardKey.keyG);
|
||||
await tester.sendKeyEvent(LogicalKeyboardKey.keyG);
|
||||
await tester.pump();
|
||||
expect(f.services.arrangement.isInFocusMode, isFalse);
|
||||
expect(f.services.arrangement.editorOpen, isTrue);
|
||||
});
|
||||
|
||||
testWidgets('window control buttons render and tap as no-ops in tests', (tester) async {
|
||||
await pumpApp(tester);
|
||||
// _RightHatContent renders ClideTappable window buttons on non-macOS;
|
||||
|
||||
@@ -126,4 +126,57 @@ void main() {
|
||||
expect(_cmd(resolve('j', visual)), 'editor.vim.down');
|
||||
});
|
||||
});
|
||||
|
||||
group('ctrl+w window family (T-404)', () {
|
||||
SequenceMatcher matcher([Keymap? k]) => SequenceMatcher(keymap: () => k ?? km, context: () => normal, captureCounts: false);
|
||||
|
||||
Intent? seq(SequenceMatcher m, List<String> chords) {
|
||||
SeqResult? r;
|
||||
for (final c in chords) {
|
||||
r = m.feed(KeyChord.parse(c));
|
||||
}
|
||||
return r?.intent;
|
||||
}
|
||||
|
||||
test('ctrl+w h/l/j/o resolve to the panel commands', () {
|
||||
expect(_cmd(seq(matcher(), ['ctrl+w', 'h'])), 'panel.focus.left');
|
||||
expect(_cmd(seq(matcher(), ['ctrl+w', 'l'])), 'panel.focus.right');
|
||||
expect(_cmd(seq(matcher(), ['ctrl+w', 'j'])), 'dock.toggle');
|
||||
expect(_cmd(seq(matcher(), ['ctrl+w', 'o'])), 'panel.focusMode');
|
||||
});
|
||||
|
||||
test('ctrl+w w and ctrl+w ctrl+w cycle panels; shift+w cycles back', () {
|
||||
expect(seq(matcher(), ['ctrl+w', 'w']), isA<FocusNextPanelIntent>());
|
||||
expect(seq(matcher(), ['ctrl+w', 'ctrl+w']), isA<FocusNextPanelIntent>());
|
||||
expect(seq(matcher(), ['ctrl+w', 'shift+w']), isA<FocusPreviousPanelIntent>());
|
||||
});
|
||||
|
||||
test('ctrl+w q and ctrl+w c close the editor', () {
|
||||
expect(_cmd(seq(matcher(), ['ctrl+w', 'q'])), 'editor.close');
|
||||
expect(_cmd(seq(matcher(), ['ctrl+w', 'c'])), 'editor.close');
|
||||
});
|
||||
|
||||
test('bare ctrl+w is a live prefix; the timeout flush fires editor.close', () {
|
||||
// editor.close's bare ctrl+w binding comes from the default-layout
|
||||
// contributions layer, which sits under the preset in the real app.
|
||||
final layered = Keymap([
|
||||
KeymapLayer.fromYaml(File('assets/keymaps/vim.yaml').readAsStringSync()),
|
||||
KeymapLayer(
|
||||
name: 'contrib',
|
||||
bindings: [KeymapBinding.chord(KeyChord.parse('ctrl+w'), intent: const InvokeCommandIntent('editor.close'))],
|
||||
),
|
||||
]);
|
||||
final m = matcher(layered);
|
||||
expect(m.feed(KeyChord.parse('ctrl+w')).outcome, SeqOutcome.pending);
|
||||
expect(_cmd(m.flush().intent), 'editor.close'); // bare ctrl+w → close, after the wait
|
||||
});
|
||||
|
||||
test('ctrl+w sequences need vim.normal/visual — inert under no vim scope', () {
|
||||
final m = SequenceMatcher(keymap: () => km, context: () => const {}, captureCounts: false);
|
||||
// With no vim scope, ctrl+w isn't a sequence prefix here, so the first
|
||||
// chord doesn't pend on the family.
|
||||
expect(m.feed(KeyChord.parse('ctrl+w')).outcome, isNot(SeqOutcome.fired));
|
||||
expect(seq(matcher(km), ['ctrl+w', 'h']), isNotNull); // but it does under vim.normal
|
||||
});
|
||||
});
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user