test sweep: cover i18n catalog loaders + theme_picker _pick (T-91) · c3033fe304 - clide

test sweep: cover i18n catalog loaders + theme_picker _pick (T-91)

test / unit + widget + golden + a11y (push) Failing after 32s

test / integration_test (xvfb) (push) Has been skipped

test / bundle smoke (xvfb 5s) (push) Has been skipped

test / daemon subprocess + web WASM smoke (push) Has been skipped

test / dart doc (lib API) (push) Failing after 1m1s

Two test files / batches:

- test/kernel/src/i18n/catalog_loader_test.dart (11 tests): all three
  CatalogLoader implementations end-to-end. AssetCatalogLoader against
  an in-memory AssetBundle covers happy path, FlutterError catch
  (missing asset), FormatException catch (malformed JSON), blank
  asset, non-object JSON. FileCatalogLoader against a tempdir covers
  happy path, missing file, malformed, blank. InMemoryCatalogLoader
  covers lookup + namespace-miss.

- Extends test/builtin/theme_picker/widget_test.dart with two tests
  for the _pick command callback: defensive not-activated branch
  (drive the contribution's run() before activate runs, _ctx is still
  null) and the dialog-resolution happy path (register + activate,
  invoke theme.pick, manually drive dialog.dismiss('forest'), assert
  IpcResponse data['selected']).

Coverage: kernel/src/i18n/catalog_loader.dart 14/26 -> 26/26;
builtin/theme_picker/src/extension.dart 9/18 -> 15/18 (remaining 3
lines are the dialog builder body — needs a DialogHost in the test
harness, out of scope).

Total coverage 74.08% -> 74.55%; floor bumped to 74.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

This commit is contained in:

jpmschweitzer

2026-05-12 09:03:29 +02:00

co-authored by

Claude Opus 4.7

parent 5dcd76a9a9

commit c3033fe304

3 changed files with 154 additions and 1 deletions

									
										pubspec.yaml
									
		+1
		-1
	
												View File
												
				@@ -18,7 +18,7 @@ repository: https://github.com/postmeridiem/clide

				# Pre-push line-coverage floor. Ratchets up only — see D-66.

				# Reading: `awk -F: '/^coverage_floor:/ {gsub(/ /,"",$2); print $2}' pubspec.yaml`.

				coverage_floor: 73

				coverage_floor: 74

				# Project metadata (was project.yaml, folded in per D-056).

				# version: above is the single source of truth. The Makefile reads