jpmschweitzer/clide
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

feat(settings): monospace font picker + bundle Fira Mono (T-471)

Browse Source 
Settings → Appearance gains a Monospace font select (JetBrains Mono / Fira
Mono) on the schema engine, writing app.mono.font. It applies live: root_shell
resolves the family into the ClideSettingsScope (D-101) and rebuilds on the
settings change, so the ~93 migrated mono sites — terminal, diffs, code, IDs —
re-read the new family at once.

Vendor Fira Mono (Regular + Bold, OFL) under assets/fonts/fira_mono/ with the
pubspec font family + licenses.yaml entry per D-42; JetBrains Mono stays the
default.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
jpmschweitzer
2026-06-17 20:59:47 +02:00
co-authored by Claude Opus 4.8
parent a7ea38acde
commit b8e6629df5
10 changed files with 139 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/builtin/theme_picker/widget_test.dart
+9 -5
View File
@@ -2,7 +2,7 @@ import 'package:clide/builtin/theme_picker/src/theme_status_item.dart';
import 'package:clide/builtin/theme_picker/theme_picker.dart';
import 'package:clide/extension/extension.dart';
import 'package:clide/kernel/kernel.dart';
import 'package:clide/widgets/widgets.dart' show kUiFontSettingKey;
import 'package:clide/widgets/widgets.dart' show kMonoFontSettingKey, kUiFontSettingKey;
import 'package:flutter/services.dart';
import 'package:flutter/widgets.dart';
import 'package:flutter_test/flutter_test.dart';
@@ -196,11 +196,15 @@ void main() {
expect(ext.contributions.whereType<SettingsControlContribution>().any((c) => c.customId == 'theme.picker'), isTrue);
});
test('Appearance includes a UI font picker (T-460)', () {
test('Appearance includes UI + monospace font pickers (T-460/T-471)', () {
final cat = ThemePickerExtension().contributions.whereType<SettingsCategoryContribution>().firstWhere((c) => c.id == 'appearance').category;
final font = cat.sections.expand((s) => s.fields).firstWhere((f) => f.key == kUiFontSettingKey);
expect(font.kind, SettingsFieldKind.select);
expect(font.options.map((o) => o.value), containsAll(['Inter', 'JosefinSans']));
final fields = cat.sections.expand((s) => s.fields).toList();
final ui = fields.firstWhere((f) => f.key == kUiFontSettingKey);
expect(ui.kind, SettingsFieldKind.select);
expect(ui.options.map((o) => o.value), containsAll(['Inter', 'JosefinSans']));
final mono = fields.firstWhere((f) => f.key == kMonoFontSettingKey);
expect(mono.kind, SettingsFieldKind.select);
expect(mono.options.map((o) => o.value), containsAll(['JetBrainsMono', 'FiraMono']));
});
testWidgets('AppearanceThemeControl lists base themes and applies a pick (T-452)', (tester) async {