fix ClidePane notifying focus listeners during build
test / unit + widget + golden + a11y (push) Failing after 34s
test / integration_test (xvfb) (push) Has been skipped
test / bundle smoke (xvfb 5s) (push) Has been skipped
test / daemon subprocess + web WASM smoke (push) Has been skipped
test / dart doc (lib API) (push) Failing after 28s

ClidePane.didChangeDependencies/didUpdateWidget run in the build phase and
called FocusTracker.setStatusWidget -> notifyListeners() synchronously,
rebuilding the focus-listening status-bar item mid-build — Flutter threw
"markNeedsBuild called during build" on every frame once a Claude pane was
focused. The convey now defers to a post-frame callback when mid-build
(re-checking focus then) and applies immediately otherwise. The T-150
widget tests missed this because no focus listener was in their tree;
added a regression test with PaneContextStatusItem present.

T-159.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-05-24 10:54:26 +02:00
co-authored by Claude Opus 4.7
parent 6e4f357c09
commit b8168d8ffe
5 changed files with 56 additions and 2 deletions
+24 -2
View File
@@ -12,6 +12,7 @@ library;
import 'package:clide/kernel/src/facade.dart';
import 'package:clide/kernel/src/focus.dart';
import 'package:flutter/scheduler.dart';
import 'package:flutter/widgets.dart';
class ClidePane extends StatefulWidget {
@@ -68,12 +69,33 @@ class _ClidePaneState extends State<ClidePane> {
// notifies (→ _sync again), but the identical-widget guard there makes
// the second pass a no-op.
void _sync() {
if (_shown) _focus?.setStatusWidget(widget.contributionId, widget.statusWidget);
if (_shown) _convey(widget.statusWidget);
}
// Push [w] to the focus tracker's status slot. setStatusWidget notifies
// focus listeners (the status-bar item rebuilds) — but didChangeDependencies
// and didUpdateWidget run during the build phase, where a synchronous notify
// would markNeedsBuild-during-build. So defer the convey to after the frame
// when we're mid-build, and re-check focus then (it may have moved).
void _convey(Widget? w) {
final focus = _focus;
if (focus == null) return;
void apply() {
if (focus.activeContributionId == widget.contributionId) {
focus.setStatusWidget(widget.contributionId, w);
}
}
if (SchedulerBinding.instance.schedulerPhase == SchedulerPhase.persistentCallbacks) {
WidgetsBinding.instance.addPostFrameCallback((_) => apply());
} else {
apply();
}
}
@override
void dispose() {
if (_shown) _focus?.setStatusWidget(widget.contributionId, null);
if (_shown) _convey(null);
_focus?.removeListener(_sync);
super.dispose();
}