rename stale forkpty test tag to pty
test / unit + widget + golden + a11y (push) Failing after 32s
test / integration_test (xvfb) (push) Has been skipped
test / bundle smoke (xvfb 5s) (push) Has been skipped
test / daemon subprocess + web WASM smoke (push) Has been skipped
test / dart doc (lib API) (push) Failing after 36s
test / unit + widget + golden + a11y (push) Failing after 32s
test / integration_test (xvfb) (push) Has been skipped
test / bundle smoke (xvfb 5s) (push) Has been skipped
test / daemon subprocess + web WASM smoke (push) Has been skipped
test / dart doc (lib API) (push) Failing after 36s
forkpty was replaced by posix_openpt + posix_spawn in T-96, but the test tag, ci/test.sh segregation, and dart_test.yaml comment kept the forkpty name. The segregation is still required — verified the PTY tests fail under the flutter-test runner (the master fd doesn't reliably deliver output there) but pass under dart test — only the name was wrong. Rename to `pty` and correct the rationale comment. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -1,7 +1,7 @@
|
||||
/// Unit tests for [PaneRegistry].
|
||||
///
|
||||
/// Exercises spawn / list / write / resize / close against the real
|
||||
/// NativePty (forkpty via FFI). Events are captured via
|
||||
/// NativePty (posix_spawn via FFI). Events are captured via
|
||||
/// [RecordingEventSink].
|
||||
library;
|
||||
|
||||
@@ -41,7 +41,7 @@ void main() {
|
||||
expect(evt.data['id'], pane.id);
|
||||
});
|
||||
|
||||
test('output events base64-encode the child bytes', tags: ['forkpty'], retry: 2, () async {
|
||||
test('output events base64-encode the child bytes', tags: ['pty'], retry: 2, () async {
|
||||
// Subscribe to the sink stream BEFORE spawn so we don't miss
|
||||
// any pane.output events that arrive between spawn and listen.
|
||||
final buf = StringBuffer();
|
||||
|
||||
Reference in New Issue
Block a user