test sweep: cover daemon editor / files / pane / pql commands (T-91)
test / unit + widget + golden + a11y (push) Failing after 31s
test / integration_test (xvfb) (push) Has been skipped
test / bundle smoke (xvfb 5s) (push) Has been skipped
test / daemon subprocess + web WASM smoke (push) Has been skipped
test / dart doc (lib API) (push) Failing after 1m1s

Extends the four existing daemon command suites with the verbs +
error paths the originals didn't reach:

- editor_commands_test (12 new): unreadable-path FileSystemException
  catch, editor.active with no buffer, editor.activate requires +
  validates id, editor.read no-active / unknown-id, editor.set-selection
  no-active / clamped, editor.set-content with + without selection,
  editor.save no-active, editor.close requires + validates id.
- files_commands_test (8 new): files.read happy + missing-path +
  empty-path + outside-root + missing-file, files.ls outside-root,
  files.watch idempotent, FilesService.atCwd resolver.
- pane_commands_test (10 new): argv-non-string rejection, unknown
  kind rejection, env passthrough, close / write / focus / resize
  missing-id and unknown-id validations, write requires bytes_b64
  or text, malformed base64 rejection.
- pql_commands_test (14 new): pql.files glob + limit, pql.backlinks
  happy, pql.outlinks missing, pql.tags, pql.query + pql.search
  happy paths + missing-arg user_error, pql.decisions.read missing
  + happy, pql.decisions.show with --with-refs / --with-tickets,
  pql.decisions.list domain filter, pql.tickets.list multi-filter,
  pql.tickets.show missing + happy, pql.tickets.status missing +
  partial-args, pql.tickets.board with team.

Coverage: src/daemon/editor_commands.dart 64/100 -> 88/100;
files_commands.dart 33/70 -> 64/70 (91%); pane_commands.dart 66/92
-> 78/92 (85%); pql_commands.dart 62/149 -> 105/149 (70% — remaining
44 lines are the per-command PqlException catch branches that only
fire when the pql subprocess itself fails mid-call).

Total coverage 77.92% -> 79.26%; floor bumped to 79.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-05-13 07:13:38 +02:00
co-authored by Claude Opus 4.7
parent 8eaf7446a1
commit b1e9abd6aa
5 changed files with 332 additions and 1 deletions
+104
View File
@@ -120,4 +120,108 @@ void main() {
expect(r.ok, isFalse);
expect(r.error!.kind, 'user_error');
});
test('pql.files with glob + limit narrows the result', () async {
final r = await call('pql.files', {'glob': 'CLAUDE.md', 'limit': 1});
expect(r.ok, isTrue);
final files = r.data['files'] as List;
expect(files.length, lessThanOrEqualTo(1));
});
test('pql.backlinks with a path returns links list', () async {
final r = await call('pql.backlinks', {'path': 'CLAUDE.md'});
expect(r.ok, isTrue);
expect(r.data['links'], isA<List>());
});
test('pql.outlinks without path returns user_error', () async {
final r = await call('pql.outlinks');
expect(r.ok, isFalse);
expect(r.error!.kind, 'user_error');
});
test('pql.tags returns a tag list (with limit)', () async {
final r = await call('pql.tags', {'limit': 5});
expect(r.ok, isTrue);
expect(r.data['tags'], isA<List>());
});
test('pql.query with a DSL string returns results', () async {
final r = await call('pql.query', {'query': 'SELECT name', 'limit': 2});
expect(r.ok, isTrue);
expect(r.data['results'], isA<List>());
});
test('pql.search with terms returns hits; missing terms is user_error', () async {
final missing = await call('pql.search');
expect(missing.ok, isFalse);
expect(missing.error!.kind, 'user_error');
final hit = await call('pql.search', {'terms': 'clide', 'limit': 2});
expect(hit.ok, isTrue);
});
test('pql.decisions.read requires id; happy path returns the body', () async {
final missing = await call('pql.decisions.read');
expect(missing.ok, isFalse);
expect(missing.error!.kind, 'user_error');
final ok = await call('pql.decisions.read', {'id': 'D-1'});
expect(ok.ok, isTrue);
expect(ok.data['id'], 'D-1');
});
test('pql.decisions.show forwards withRefs / withTickets', () async {
final r = await call('pql.decisions.show', {
'id': 'D-1',
'withRefs': true,
'withTickets': true,
});
expect(r.ok, isTrue);
expect(r.data['id'], 'D-1');
});
test('pql.decisions.list with a domain filter narrows', () async {
final r = await call('pql.decisions.list', {'domain': 'architecture'});
expect(r.ok, isTrue);
final decisions = r.data['decisions'] as List;
expect(decisions.every((d) => (d as Map)['domain'] == 'architecture'), isTrue);
});
test('pql.tickets.list with filters narrows + shows status', () async {
final r = await call('pql.tickets.list', {
'status': 'done',
'team': 'whatever',
'assigned': 'no-one',
'decision': 'D-1',
});
expect(r.ok, isTrue);
expect(r.data['tickets'], isA<List>());
});
test('pql.tickets.show requires id; happy path returns the row', () async {
final missing = await call('pql.tickets.show');
expect(missing.ok, isFalse);
expect(missing.error!.kind, 'user_error');
final ok = await call('pql.tickets.show', {
'id': 'T-1',
'withContext': true,
'withBlockers': true,
});
expect(ok.ok, isTrue);
});
test('pql.tickets.status requires ids + status', () async {
final missing = await call('pql.tickets.status');
expect(missing.ok, isFalse);
expect(missing.error!.kind, 'user_error');
// Accept both List and String for ids.
final justOne = await call('pql.tickets.status', {'ids': 'T-1'});
expect(justOne.ok, isFalse); // status still missing
expect(justOne.error!.kind, 'user_error');
});
test('pql.tickets.board with team filter', () async {
final r = await call('pql.tickets.board', {'team': 'whatever'});
expect(r.ok, isTrue);
expect(r.data['columns'], isA<List>());
});
}