remove dissolved daemon, retire ptyc, fix golden cross-platform

Complete three overdue cleanups discovered during macOS health check:

D-56 daemon dissolution: delete bin/clide.dart, DaemonServer,
and orphaned tests (test/cli/, subprocess_test, in_process_test).
Update stale "clide --daemon" references in i18n catalogs, error
messages, editor_commands, CI scripts, and decision records.

ptyc retirement: delete ptyc/ source tree, PtySession, scm_rights.
Remove from Toolchain resolution, ToolCheck gate, backend
serialization, testmode harness, Makefile, CI, and sandbox
entitlements. PTY spawning uses NativePty (Dart FFI forkpty) since
the terminal was absorbed in-tree. D-5 amended.

Golden tests: wire the existing but never-applied clideGoldenConfig
via flutter_test_config.dart. Disable CI goldens (Skia anti-aliasing
differs between macOS/Linux even with Ahem). Keep platform-keyed
goldens only — goldens/linux/ and goldens/macos/ each run on their
own OS.

Test suite: 826 pass, 0 fail on macOS (was 829 pass, 11 fail).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Jeroen Schweitzer
2026-05-07 18:40:01 +02:00
co-authored by Claude Opus 4.6
parent 6b7290dc42
commit a6eca2561b
51 changed files with 265 additions and 2719 deletions
+9 -12
View File
@@ -2,21 +2,18 @@ import 'package:alchemist/alchemist.dart';
/// Alchemist config shared across all golden tests.
///
/// * CI mode uses the Ahem font (shipped with Flutter's test harness) so
/// goldens render identically on every Linux runner and developer
/// machine. Any drift between platforms points to a real theme-token
/// regression, not a font-rendering fluke.
/// * Local mode keeps developer-machine fonts so you can eyeball
/// renders naturally; the `--update-goldens` workflow still produces
/// CI-valid goldens because CI runs the config below.
AlchemistConfig clideGoldenConfig({bool forceCiMode = false}) {
return AlchemistConfig(
/// Platform goldens only — keyed by OS (`goldens/linux/`, `goldens/macos/`).
/// CI goldens (Ahem font in `goldens/ci/`) are disabled because Skia's
/// geometric anti-aliasing differs between macOS and Linux even with Ahem,
/// producing sub-pixel diffs that fail cross-platform.
AlchemistConfig clideGoldenConfig() {
return const AlchemistConfig(
theme: null, // we're not using Material ThemeData
platformGoldensConfig: PlatformGoldensConfig(
enabled: !forceCiMode,
),
ciGoldensConfig: const CiGoldensConfig(
enabled: true,
),
ciGoldensConfig: CiGoldensConfig(
enabled: false,
),
);
}