remove dissolved daemon, retire ptyc, fix golden cross-platform
Complete three overdue cleanups discovered during macOS health check: D-56 daemon dissolution: delete bin/clide.dart, DaemonServer, and orphaned tests (test/cli/, subprocess_test, in_process_test). Update stale "clide --daemon" references in i18n catalogs, error messages, editor_commands, CI scripts, and decision records. ptyc retirement: delete ptyc/ source tree, PtySession, scm_rights. Remove from Toolchain resolution, ToolCheck gate, backend serialization, testmode harness, Makefile, CI, and sandbox entitlements. PTY spawning uses NativePty (Dart FFI forkpty) since the terminal was absorbed in-tree. D-5 amended. Golden tests: wire the existing but never-applied clideGoldenConfig via flutter_test_config.dart. Disable CI goldens (Skia anti-aliasing differs between macOS/Linux even with Ahem). Keep platform-keyed goldens only — goldens/linux/ and goldens/macos/ each run on their own OS. Test suite: 826 pass, 0 fail on macOS (was 829 pass, 11 fail). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 4.6
parent
6b7290dc42
commit
a6eca2561b
@@ -9,7 +9,6 @@ import 'dart:convert';
|
||||
import 'dart:io';
|
||||
|
||||
import 'package:clide/clide.dart';
|
||||
import 'package:clide/kernel/src/toolchain.dart';
|
||||
import 'package:clide/src/daemon/pane_commands.dart';
|
||||
import 'package:clide/src/panes/registry.dart';
|
||||
import 'package:test/test.dart';
|
||||
@@ -17,9 +16,6 @@ import 'package:test/test.dart';
|
||||
void main() {
|
||||
if (!Platform.isLinux && !Platform.isMacOS) return;
|
||||
|
||||
final toolchain = Toolchain();
|
||||
toolchain.applyResolved(Toolchain.resolvePaths(workspaceRoot: Directory.current.path));
|
||||
|
||||
group('pane.* dispatch', () {
|
||||
late DaemonDispatcher dispatcher;
|
||||
late PaneRegistry registry;
|
||||
@@ -48,7 +44,6 @@ void main() {
|
||||
final r = await call('pane.spawn', {
|
||||
'argv': const ['/bin/sh', '-c', 'sleep 0.1'],
|
||||
'kind': 'terminal',
|
||||
'ptyc_path': toolchain.ptyc,
|
||||
});
|
||||
expect(r.ok, isTrue, reason: r.error?.message);
|
||||
expect(r.data['id'], startsWith('p_'));
|
||||
@@ -58,12 +53,10 @@ void main() {
|
||||
test('pane.list shows spawned panes', () async {
|
||||
await call('pane.spawn', {
|
||||
'argv': const ['/bin/cat'],
|
||||
'ptyc_path': toolchain.ptyc,
|
||||
});
|
||||
await call('pane.spawn', {
|
||||
'argv': const ['/bin/cat'],
|
||||
'kind': 'claude',
|
||||
'ptyc_path': toolchain.ptyc,
|
||||
});
|
||||
final r = await call('pane.list', const {});
|
||||
final panes = (r.data['panes'] as List).cast<Map>();
|
||||
@@ -74,7 +67,6 @@ void main() {
|
||||
test('pane.write accepts text or bytes_b64', () async {
|
||||
final spawn = await call('pane.spawn', {
|
||||
'argv': const ['/bin/cat'],
|
||||
'ptyc_path': toolchain.ptyc,
|
||||
});
|
||||
final id = spawn.data['id']! as String;
|
||||
|
||||
@@ -98,7 +90,6 @@ void main() {
|
||||
test('pane.resize + pane.close + pane.focus round-trip', () async {
|
||||
final spawn = await call('pane.spawn', {
|
||||
'argv': const ['/bin/cat'],
|
||||
'ptyc_path': toolchain.ptyc,
|
||||
});
|
||||
final id = spawn.data['id']! as String;
|
||||
|
||||
|
||||
Reference in New Issue
Block a user