fix sidebar order and ptyc status bar warning
test / unit + widget + golden + a11y (push) Failing after 29s
test / integration_test (xvfb) (push) Has been skipped
test / bundle smoke (xvfb 5s) (push) Has been skipped
test / daemon subprocess + web WASM smoke (push) Has been skipped
test / unit + widget + golden + a11y (push) Failing after 29s
test / integration_test (xvfb) (push) Has been skipped
test / bundle smoke (xvfb 5s) (push) Has been skipped
test / daemon subprocess + web WASM smoke (push) Has been skipped
Revert priority sort in tabsFor() — registration order in main.dart is the intended sidebar order, not priority. The priority fields on extensions were dead code. Remove ptyc from toolchain missing list since NativePty replaced it. Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
@@ -31,11 +31,11 @@ void main() {
|
||||
expect(r.contributionsFor(Slots.sidebar), isEmpty);
|
||||
});
|
||||
|
||||
test('contribute appends to the slot and orders by priority', () {
|
||||
test('contribute appends to the slot in registration order', () {
|
||||
r.contribute(_tab(id: 'a', slot: Slots.sidebar, priority: 10));
|
||||
r.contribute(_tab(id: 'b', slot: Slots.sidebar, priority: -5));
|
||||
r.contribute(_tab(id: 'c', slot: Slots.sidebar, priority: 0));
|
||||
expect(r.tabsFor(Slots.sidebar).map((t) => t.id), ['b', 'c', 'a']);
|
||||
expect(r.tabsFor(Slots.sidebar).map((t) => t.id), ['a', 'b', 'c']);
|
||||
});
|
||||
|
||||
test('first tab contribution becomes the active tab', () {
|
||||
|
||||
Reference in New Issue
Block a user