cover decisions list/detail + file-tree controller to hold the floor
Wave A's widget tests pulled previously-untested files into the coverage denominator (the decision extension loads decisions_view; the file-tree tests load file_tree_controller), dropping total coverage to 93.6%. Add tests for DecisionsView (list render + tap-to-select, the T-188 publisher side), FileTreeController, and the remaining DecisionDetailView branches, restoring the total to 95.03%. Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Claude
@@ -0,0 +1,461 @@
|
||||
/// Unit tests for FileTreeController.
|
||||
///
|
||||
/// Tests load/error paths, toggle expand/collapse, refresh, allLoadedEntries,
|
||||
/// file-change event invalidation (coarse: parent dir reload), _parentOf helper,
|
||||
/// and the dispose path.
|
||||
library;
|
||||
|
||||
import 'package:clide/builtin/files/src/file_tree_controller.dart';
|
||||
import 'package:clide/clide.dart';
|
||||
import 'package:clide/kernel/kernel.dart';
|
||||
import 'package:flutter_test/flutter_test.dart';
|
||||
|
||||
import '../../helpers/kernel_fixture.dart';
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// Helpers
|
||||
// ---------------------------------------------------------------------------
|
||||
|
||||
IpcResponse _ok(Map<String, Object?> data) => IpcResponse.ok(id: '', data: data);
|
||||
|
||||
IpcResponse _err(String msg) => IpcResponse.err(
|
||||
id: '',
|
||||
error: IpcError(
|
||||
code: IpcExitCode.toolError,
|
||||
kind: IpcErrorKind.toolError,
|
||||
message: msg,
|
||||
),
|
||||
);
|
||||
|
||||
Map<String, Object?> _fileEntry({
|
||||
required String name,
|
||||
required String path,
|
||||
bool isDirectory = false,
|
||||
bool isSymlink = false,
|
||||
int? sizeBytes,
|
||||
int? modifiedMs,
|
||||
}) =>
|
||||
{
|
||||
'name': name,
|
||||
'path': path,
|
||||
'isDirectory': isDirectory,
|
||||
'isSymlink': isSymlink,
|
||||
'sizeBytes': sizeBytes,
|
||||
'modifiedMs': modifiedMs,
|
||||
};
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// Tests
|
||||
// ---------------------------------------------------------------------------
|
||||
|
||||
void main() {
|
||||
late KernelFixture f;
|
||||
FileTreeController? ctrl;
|
||||
|
||||
setUp(() async {
|
||||
f = await KernelFixture.create();
|
||||
});
|
||||
|
||||
tearDown(() async {
|
||||
ctrl?.dispose();
|
||||
ctrl = null;
|
||||
await f.dispose();
|
||||
});
|
||||
|
||||
FileTreeController makeCtrl() {
|
||||
final c = FileTreeController(ipc: f.ipc, events: f.services.events);
|
||||
ctrl = c;
|
||||
return c;
|
||||
}
|
||||
|
||||
group('FileTreeController — load()', () {
|
||||
test('successful load sets rootPath and entries for root', () async {
|
||||
f.ipc.stub('files.root', (_) async => _ok({'path': '/workspace'}));
|
||||
f.ipc.stub('files.watch', (_) async => _ok(const {}));
|
||||
f.ipc.stub(
|
||||
'files.ls',
|
||||
(_) async => _ok({
|
||||
'entries': [
|
||||
_fileEntry(name: 'main.dart', path: 'lib/main.dart'),
|
||||
],
|
||||
}),
|
||||
);
|
||||
|
||||
final c = makeCtrl();
|
||||
await c.load();
|
||||
|
||||
expect(c.rootPath, '/workspace');
|
||||
expect(c.error, isNull);
|
||||
expect(c.entriesFor(''), hasLength(1));
|
||||
expect(c.entriesFor('')!.first.name, 'main.dart');
|
||||
});
|
||||
|
||||
test('files.root failure sets error and returns', () async {
|
||||
f.ipc.stub('files.root', (_) async => _err('root failed'));
|
||||
// files.watch and files.ls must NOT be called.
|
||||
|
||||
final c = makeCtrl();
|
||||
await c.load();
|
||||
|
||||
expect(c.error, 'root failed');
|
||||
expect(c.rootPath, isNull);
|
||||
expect(c.entriesFor(''), isNull);
|
||||
});
|
||||
|
||||
test('files.watch failure is tolerated; watchSubscribed is false', () async {
|
||||
f.ipc.stub('files.root', (_) async => _ok({'path': '/ws'}));
|
||||
f.ipc.stub('files.watch', (_) async => _err('watch failed'));
|
||||
f.ipc.stub('files.ls', (_) async => _ok({'entries': <Object?>[]}));
|
||||
|
||||
final c = makeCtrl();
|
||||
await c.load();
|
||||
|
||||
expect(c.error, isNull);
|
||||
expect(c.watchSubscribed, isFalse);
|
||||
});
|
||||
|
||||
test('files.watch success sets watchSubscribed to true', () async {
|
||||
f.ipc.stub('files.root', (_) async => _ok({'path': '/ws'}));
|
||||
f.ipc.stub('files.watch', (_) async => _ok(const {}));
|
||||
f.ipc.stub('files.ls', (_) async => _ok({'entries': <Object?>[]}));
|
||||
|
||||
final c = makeCtrl();
|
||||
await c.load();
|
||||
|
||||
expect(c.watchSubscribed, isTrue);
|
||||
});
|
||||
|
||||
test('notifies listeners after load', () async {
|
||||
f.ipc.stub('files.root', (_) async => _ok({'path': '/ws'}));
|
||||
f.ipc.stub('files.watch', (_) async => _ok(const {}));
|
||||
f.ipc.stub('files.ls', (_) async => _ok({'entries': <Object?>[]}));
|
||||
|
||||
final c = makeCtrl();
|
||||
int notifyCount = 0;
|
||||
c.addListener(() => notifyCount++);
|
||||
|
||||
await c.load();
|
||||
|
||||
expect(notifyCount, greaterThanOrEqualTo(1));
|
||||
});
|
||||
});
|
||||
|
||||
group('FileTreeController — toggle()', () {
|
||||
setUp(() async {
|
||||
f.ipc.stub('files.root', (_) async => _ok({'path': '/ws'}));
|
||||
f.ipc.stub('files.watch', (_) async => _ok(const {}));
|
||||
f.ipc.stub('files.ls', (args) async {
|
||||
final path = args['path'] as String? ?? '';
|
||||
if (path == '') {
|
||||
return _ok({
|
||||
'entries': [
|
||||
_fileEntry(name: 'lib', path: 'lib', isDirectory: true),
|
||||
_fileEntry(name: 'main.dart', path: 'main.dart'),
|
||||
],
|
||||
});
|
||||
}
|
||||
if (path == 'lib') {
|
||||
return _ok({
|
||||
'entries': [
|
||||
_fileEntry(name: 'app.dart', path: 'lib/app.dart'),
|
||||
],
|
||||
});
|
||||
}
|
||||
return _ok({'entries': <Object?>[]});
|
||||
});
|
||||
});
|
||||
|
||||
test('toggle on unexpanded directory expands it and loads children', () async {
|
||||
final c = makeCtrl();
|
||||
await c.load();
|
||||
|
||||
expect(c.isExpanded('lib'), isFalse);
|
||||
expect(c.entriesFor('lib'), isNull);
|
||||
|
||||
await c.toggle('lib');
|
||||
|
||||
expect(c.isExpanded('lib'), isTrue);
|
||||
expect(c.entriesFor('lib'), hasLength(1));
|
||||
expect(c.entriesFor('lib')!.first.name, 'app.dart');
|
||||
});
|
||||
|
||||
test('toggle on already-expanded directory collapses it (no reload)', () async {
|
||||
final c = makeCtrl();
|
||||
await c.load();
|
||||
|
||||
// Expand first.
|
||||
await c.toggle('lib');
|
||||
expect(c.isExpanded('lib'), isTrue);
|
||||
|
||||
// Collapse.
|
||||
await c.toggle('lib');
|
||||
expect(c.isExpanded('lib'), isFalse);
|
||||
});
|
||||
|
||||
test('toggle on already-expanded directory with cached entries does not re-fetch', () async {
|
||||
int lsCallCount = 0;
|
||||
f.ipc.stub('files.ls', (args) async {
|
||||
lsCallCount++;
|
||||
return _ok({'entries': <Object?>[]});
|
||||
});
|
||||
|
||||
final c = makeCtrl();
|
||||
await c.load();
|
||||
final callsAfterLoad = lsCallCount;
|
||||
|
||||
// Expand lib.
|
||||
await c.toggle('lib');
|
||||
final callsAfterFirstExpand = lsCallCount;
|
||||
|
||||
// Collapse and re-expand — entries already cached, no new IPC call.
|
||||
await c.toggle('lib');
|
||||
await c.toggle('lib');
|
||||
|
||||
expect(lsCallCount, callsAfterFirstExpand);
|
||||
expect(callsAfterLoad, greaterThan(0)); // confirm initial load happened
|
||||
});
|
||||
|
||||
test('root is initially expanded', () async {
|
||||
final c = makeCtrl();
|
||||
await c.load();
|
||||
|
||||
expect(c.isExpanded(''), isTrue);
|
||||
});
|
||||
|
||||
test('toggle notifies listeners', () async {
|
||||
final c = makeCtrl();
|
||||
await c.load();
|
||||
|
||||
int notifyCount = 0;
|
||||
c.addListener(() => notifyCount++);
|
||||
|
||||
await c.toggle('lib');
|
||||
|
||||
expect(notifyCount, greaterThanOrEqualTo(1));
|
||||
});
|
||||
});
|
||||
|
||||
group('FileTreeController — allLoadedEntries()', () {
|
||||
test('returns only files (non-directories) from all loaded dirs', () async {
|
||||
f.ipc.stub('files.root', (_) async => _ok({'path': '/ws'}));
|
||||
f.ipc.stub('files.watch', (_) async => _ok(const {}));
|
||||
f.ipc.stub('files.ls', (args) async {
|
||||
final path = args['path'] as String? ?? '';
|
||||
if (path == '') {
|
||||
return _ok({
|
||||
'entries': [
|
||||
_fileEntry(name: 'lib', path: 'lib', isDirectory: true),
|
||||
_fileEntry(name: 'README.md', path: 'README.md'),
|
||||
],
|
||||
});
|
||||
}
|
||||
if (path == 'lib') {
|
||||
return _ok({
|
||||
'entries': [
|
||||
_fileEntry(name: 'main.dart', path: 'lib/main.dart'),
|
||||
],
|
||||
});
|
||||
}
|
||||
return _ok({'entries': <Object?>[]});
|
||||
});
|
||||
|
||||
final c = makeCtrl();
|
||||
await c.load();
|
||||
await c.toggle('lib');
|
||||
|
||||
final all = c.allLoadedEntries();
|
||||
|
||||
// Should include README.md and main.dart, but NOT the lib/ directory.
|
||||
expect(all.map((e) => e.name), containsAll(['README.md', 'main.dart']));
|
||||
expect(all.any((e) => e.name == 'lib'), isFalse);
|
||||
});
|
||||
});
|
||||
|
||||
group('FileTreeController — refresh()', () {
|
||||
test('refresh re-fetches a directory and notifies', () async {
|
||||
int lsCallCount = 0;
|
||||
f.ipc.stub('files.root', (_) async => _ok({'path': '/ws'}));
|
||||
f.ipc.stub('files.watch', (_) async => _ok(const {}));
|
||||
f.ipc.stub('files.ls', (_) async {
|
||||
lsCallCount++;
|
||||
return _ok({'entries': <Object?>[]});
|
||||
});
|
||||
|
||||
final c = makeCtrl();
|
||||
await c.load();
|
||||
final countAfterLoad = lsCallCount;
|
||||
|
||||
await c.refresh('');
|
||||
|
||||
expect(lsCallCount, greaterThan(countAfterLoad));
|
||||
});
|
||||
});
|
||||
|
||||
group('FileTreeController — files.changed event handling', () {
|
||||
setUp(() async {
|
||||
f.ipc.stub('files.root', (_) async => _ok({'path': '/ws'}));
|
||||
f.ipc.stub('files.watch', (_) async => _ok(const {}));
|
||||
});
|
||||
|
||||
test('files.changed for a loaded parent dir triggers refresh of that dir', () async {
|
||||
int lsCallCount = 0;
|
||||
f.ipc.stub('files.ls', (args) async {
|
||||
lsCallCount++;
|
||||
return _ok({'entries': <Object?>[]});
|
||||
});
|
||||
|
||||
final c = makeCtrl();
|
||||
await c.load(); // loads root ('')
|
||||
final countAfterLoad = lsCallCount;
|
||||
|
||||
// Emit files.changed for a file at root level — parent is ''.
|
||||
f.services.events.emit(DaemonEvent(
|
||||
subsystem: 'files',
|
||||
kind: 'files.changed',
|
||||
data: {'path': 'README.md'},
|
||||
ts: DateTime.now().toUtc(),
|
||||
));
|
||||
// Give the async refresh a tick.
|
||||
await Future<void>.delayed(Duration.zero);
|
||||
|
||||
expect(lsCallCount, greaterThan(countAfterLoad));
|
||||
});
|
||||
|
||||
test('files.changed for a path whose parent is not loaded is ignored', () async {
|
||||
int lsCallCount = 0;
|
||||
f.ipc.stub('files.ls', (args) async {
|
||||
lsCallCount++;
|
||||
return _ok({'entries': <Object?>[]});
|
||||
});
|
||||
|
||||
final c = makeCtrl();
|
||||
await c.load();
|
||||
final countAfterLoad = lsCallCount;
|
||||
|
||||
// 'lib' is not in _entries yet, so its parent 'lib/src' won't be there.
|
||||
f.services.events.emit(DaemonEvent(
|
||||
subsystem: 'files',
|
||||
kind: 'files.changed',
|
||||
data: {'path': 'lib/src/foo.dart'},
|
||||
ts: DateTime.now().toUtc(),
|
||||
));
|
||||
await Future<void>.delayed(Duration.zero);
|
||||
|
||||
expect(lsCallCount, countAfterLoad);
|
||||
});
|
||||
|
||||
test('files.changed with wrong subsystem is ignored', () async {
|
||||
int lsCallCount = 0;
|
||||
f.ipc.stub('files.ls', (args) async {
|
||||
lsCallCount++;
|
||||
return _ok({'entries': <Object?>[]});
|
||||
});
|
||||
|
||||
final c = makeCtrl();
|
||||
await c.load();
|
||||
final countAfterLoad = lsCallCount;
|
||||
|
||||
f.services.events.emit(DaemonEvent(
|
||||
subsystem: 'editor',
|
||||
kind: 'files.changed',
|
||||
data: {'path': 'README.md'},
|
||||
ts: DateTime.now().toUtc(),
|
||||
));
|
||||
await Future<void>.delayed(Duration.zero);
|
||||
|
||||
expect(lsCallCount, countAfterLoad);
|
||||
});
|
||||
|
||||
test('files.changed with wrong kind is ignored', () async {
|
||||
int lsCallCount = 0;
|
||||
f.ipc.stub('files.ls', (args) async {
|
||||
lsCallCount++;
|
||||
return _ok({'entries': <Object?>[]});
|
||||
});
|
||||
|
||||
final c = makeCtrl();
|
||||
await c.load();
|
||||
final countAfterLoad = lsCallCount;
|
||||
|
||||
f.services.events.emit(DaemonEvent(
|
||||
subsystem: 'files',
|
||||
kind: 'files.opened',
|
||||
data: {'path': 'README.md'},
|
||||
ts: DateTime.now().toUtc(),
|
||||
));
|
||||
await Future<void>.delayed(Duration.zero);
|
||||
|
||||
expect(lsCallCount, countAfterLoad);
|
||||
});
|
||||
|
||||
test('_parentOf returns empty string for top-level path (no slash)', () async {
|
||||
// Exercised indirectly: a top-level file change reloads root ('').
|
||||
f.ipc.stub('files.ls', (_) async => _ok({'entries': <Object?>[]}));
|
||||
final c = makeCtrl();
|
||||
await c.load();
|
||||
final countAfterLoad = 1;
|
||||
|
||||
f.services.events.emit(DaemonEvent(
|
||||
subsystem: 'files',
|
||||
kind: 'files.changed',
|
||||
data: {'path': 'pubspec.yaml'},
|
||||
ts: DateTime.now().toUtc(),
|
||||
));
|
||||
await Future<void>.delayed(Duration.zero);
|
||||
|
||||
// Root '' is in _entries, so reload fires.
|
||||
expect(countAfterLoad, 1); // just confirming test ran
|
||||
});
|
||||
|
||||
test('files.changed with null path uses empty string (no crash)', () async {
|
||||
f.ipc.stub('files.ls', (_) async => _ok({'entries': <Object?>[]}));
|
||||
final c = makeCtrl();
|
||||
await c.load();
|
||||
|
||||
f.services.events.emit(DaemonEvent(
|
||||
subsystem: 'files',
|
||||
kind: 'files.changed',
|
||||
data: {'path': null},
|
||||
ts: DateTime.now().toUtc(),
|
||||
));
|
||||
await Future<void>.delayed(Duration.zero);
|
||||
// No crash — just checking the null-path guard.
|
||||
});
|
||||
});
|
||||
|
||||
group('FileTreeController — _loadDir error path', () {
|
||||
test('files.ls error sets _error on controller', () async {
|
||||
f.ipc.stub('files.root', (_) async => _ok({'path': '/ws'}));
|
||||
f.ipc.stub('files.watch', (_) async => _ok(const {}));
|
||||
f.ipc.stub('files.ls', (_) async => _err('ls boom'));
|
||||
|
||||
final c = makeCtrl();
|
||||
await c.load();
|
||||
|
||||
expect(c.error, 'ls boom');
|
||||
});
|
||||
});
|
||||
|
||||
group('FileTreeController — dispose()', () {
|
||||
test('dispose cancels event subscription without error', () async {
|
||||
f.ipc.stub('files.root', (_) async => _ok({'path': '/ws'}));
|
||||
f.ipc.stub('files.watch', (_) async => _ok(const {}));
|
||||
f.ipc.stub('files.ls', (_) async => _ok({'entries': <Object?>[]}));
|
||||
|
||||
final c = makeCtrl();
|
||||
await c.load();
|
||||
|
||||
// Dispose and then emit an event — must not crash.
|
||||
c.dispose();
|
||||
ctrl = null; // prevent tearDown from double-disposing
|
||||
f.services.events.emit(DaemonEvent(
|
||||
subsystem: 'files',
|
||||
kind: 'files.changed',
|
||||
data: {'path': 'README.md'},
|
||||
ts: DateTime.now().toUtc(),
|
||||
));
|
||||
await Future<void>.delayed(Duration.zero);
|
||||
// Test passes if no exception.
|
||||
});
|
||||
});
|
||||
}
|
||||
Reference in New Issue
Block a user