jpmschweitzer/clide
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

feat(claude): account login pane — host claude login in a modal terminal (T-485)

Browse Source 
Completes the `login` verb + the UI add/re-login affordances. The
accountActionChannel 'login' action opens ClaudeLoginDialog — a modal hosting a
TerminalPane that runs `CLAUDE_CONFIG_DIR=<dir> claude login`, so the CLI drives
the OAuth browser flow and credentials land in that account's config dir (D-64:
one CLI-initiated browser flow, on explicit action).

TerminalPane gains optional argv/env/cwdOverride (default stays the login
shell), and its pane.spawn carries env when set. The login pane reuses the
TerminalPane *widget* — a code import, not a runtime dependency, since it spawns
through the always-present pane.spawn IPC rather than the terminal extension.

Tests cover the parameterized spawn args and the dialog's host wiring (title,
CLAUDE_CONFIG_DIR, close). Closes T-485.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
jpmschweitzer
2026-06-28 00:52:41 +02:00
co-authored by Claude Opus 4.8
parent 222d4ae5e3
commit 996b10d3ec
8 changed files with 199 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/builtin/terminal/terminal_pane_test.dart
+19
View File
@@ -75,6 +75,25 @@ void main() {
expect(spawnedCwd, isNot(Directory.current.path));
});
testWidgets('a caller-supplied argv + env + cwd reach pane.spawn (T-485)', (tester) async {
Map<String, Object?>? spawnArgs;
fixture.ipc.setConnected(true);
fixture.ipc.stub('pane.spawn', (args) async {
spawnArgs = args;
return IpcResponse.ok(id: 'r1', data: {'id': 'pane-1', 'pid': 1});
});
fixture.ipc.stub('pane.close', (args) async => IpcResponse.ok(id: 'r2'));
await tester.pumpWidget(
harness(fixture, const TerminalPane(argv: ['claude', 'login'], env: {'CLAUDE_CONFIG_DIR': '/home/u/.claude-work'}, cwdOverride: '/repo')),
);
await pumpAsync(tester);
expect(spawnArgs?['argv'], ['claude', 'login']);
expect(spawnArgs?['env'], {'CLAUDE_CONFIG_DIR': '/home/u/.claude-work'});
expect(spawnArgs?['cwd'], '/repo');
});
testWidgets('disposing before spawn completes sends no close', (tester) async {
final closed = <String>[];
fixture.ipc.setConnected(false); // spawn bails out: no pane id