fix theme picker integration test; one bake for build-time facts (T-116) · 7c2eae42f1 - clide

fix theme picker integration test; one bake for build-time facts (T-116)

test / unit + widget + golden + a11y (push) Failing after 31s

test / integration_test (xvfb) (push) Has been skipped

test / bundle smoke (xvfb 5s) (push) Has been skipped

test / daemon subprocess + web WASM smoke (push) Has been skipped

test / dart doc (lib API) (push) Failing after 1m1s

The test was awaiting services.commands.execute('theme.pick') whose
Future doesn't complete until the dialog is dismissed — deadlock.
Fire-and-forget around pumpAndSettle, then tap Cancel, then await
the original future. Also tear the widget tree down before
services.dispose() so listening widgets unsubscribe first.

Pre-existing layout overflow in the welcome _StatusLine surfaced
when running the test at narrower viewports. Switched to a whole-
row FittedBox(scaleDown) — uniform shrink on narrow screens, no-op
at standard widths.

User flagged the hardcoded 'clide 2.0.0-dev' string. Replaced with
one generated lib/src/build_info.g.dart (gitignored, regenerated
by `make gen-build-info` from pubspec.yaml + git short SHA + UTC
clock). The same target re-syncs assets/licenses.yaml self.version
in place — no second source. Every make build/run/test depends on
it implicitly. Welcome status line now reads `clideVersion`. Stale
fontSize literals in welcome_view swept to typography constants;
clideFontMeta=13, clideFontDialogTitle=16, clideFontWelcomeBanner=52
added to fill gaps in the scale.

Co-Authored-By: Claude <noreply@anthropic.com>

This commit is contained in:

jpmschweitzer

2026-05-18 13:22:55 +02:00

co-authored by

Claude

parent 68aa34e9dd

commit 7c2eae42f1

12 changed files with 156 additions and 81 deletions

									
										assets/licenses.yaml
									
		+4
		-1
	
												View File
												
				@@ -36,7 +36,10 @@ schema_version: 1

				# About screen can read it at runtime.

				self:

				  name: clide

				  version: "2.0.0-dev"

				  # Auto-synced from pubspec.yaml `version:` by `make gen-build-info`

				  # (runs implicitly on every build/run/test). Don't hand-edit; bump

				  # pubspec instead.

				  version: "2.1.0"

				  homepage: https://github.com/postmeridiem/clide

				  license: MIT

				  license_file: assets/LICENSE