keystroke mapper layer — intents, presets, when-clauses (T-117) · 798ba524f1 - clide

keystroke mapper layer — intents, presets, when-clauses (T-117)

Build the upstream of every keyboard-driven feature: widgets bind
to typed Intents, the keymap resolves chord+context to an Intent,
and Flutter's Actions dispatches. The widget never touches a key.

Layers (low → high precedence):
  1. preset YAML in assets/keymaps/<preset>.yaml
  2. extension-registered command bindings (via
     KeymapService.registerCommandBinding from ExtensionManager)
  3. user file at <appDir>/keybindings.yaml
  4. settings JSON overlay at app.keymap.overrides

The when-clause grammar is a tiny recursive-descent parser over
boolean expressions on a named context bag — VS-Code style
`palette.open && !textInputFocused`. Producing services publish
scope flags via setScopeFlag.

Keys reference LogicalKeyboardKey.keyId (stable across keyboard
layouts), not the locale-aware keyLabel the consultant flagged.

Ships:
  - lib/kernel/src/keymap/{key_chord, when_clause, intents, keymap,
    keymap_service}.dart
  - assets/keymaps/default.yaml (the baseline preset)
  - 90+ unit tests covering parser precedence, layering precedence,
    scope evaluation, register/unregister, settings overlay,
    malformed-input tolerance
  - app.dart root handler routes through KeymapService → Actions
  - ExtensionManager mirrors every legacy defaultBinding into the
    keymap as a contribution layer

KeybindingResolver kept temporarily as a back-compat shim for
callers we haven't migrated yet; safe to delete once the last
caller goes through Actions.

Closes T-110 (consultant: scoped Shortcuts/Actions; off keyLabel).
Annotates T-23 with what's left for T-100. Unblocks T-64 / T-65 /
T-66 (preset data tickets).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

This commit is contained in:

jpmschweitzer

2026-05-17 21:40:02 +02:00

co-authored by

Claude Opus 4.7

parent a8729db893

commit 798ba524f1

18 changed files with 1944 additions and 47 deletions

									
										lib/kernel/kernel.dart
									
		+5
		
												View File
												
				@@ -22,6 +22,11 @@ export 'src/clipboard.dart';

				export 'src/commands/keybindings.dart';

				export 'src/commands/palette.dart';

				export 'src/commands/registry.dart';

				export 'src/keymap/intents.dart';

				export 'src/keymap/key_chord.dart';

				export 'src/keymap/keymap.dart';

				export 'src/keymap/keymap_service.dart';

				export 'src/keymap/when_clause.dart';

				export 'src/dialog.dart';

				export 'src/extensions_manager.dart';

				export 'src/files.dart';