jpmschweitzer/clide
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

actually reveal the editor split on file open (T-197)

Browse Source 
The first T-197 fix flipped the wrong lever: it called
activateTab(Slots.workspace, 'editor.active'), but _WorkspaceSlot
renders its editor split off arrangement.editorOpen — not the active
tab — so clicking a file still showed nothing. Call arrangement
.openEditor() on editor.opened / active-changed(non-null), and
closeEditor() on active-changed(null) so the split collapses when the
last buffer closes. Test now asserts arrangement.editorOpen, the lever
the UI actually reads.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
jpmschweitzer
2026-06-01 18:36:48 +02:00
co-authored by Claude Opus 4.8
parent c6a8da1b3a
commit 740cc7bb7b
4 changed files with 51 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/builtin/editor/src/extension.dart
+19 -7
View File
@@ -19,17 +19,29 @@ class EditorExtension extends ClideExtension {
StreamSubscription<DaemonEvent>? _sub;
/// Reveal the editor tab when a buffer opens or becomes active.
/// `editor.open` opens the buffer daemon-side and emits the event,
/// but nothing else brings the workspace tab to front — without this
/// the editor never appears over the Claude pane (T-197). The view's
/// `hydrate()` pulls the active buffer once it mounts.
/// Reveal the editor split when a buffer opens, hide it when the last
/// one closes. `editor.open` opens the buffer daemon-side and emits the
/// event, but the workspace renders its editor split off
/// `arrangement.editorOpen` (not the active tab) — so without flipping
/// that flag the editor never appears over the Claude pane (T-197). The
/// view's `hydrate()` pulls the active buffer once it mounts.
@override
Future<void> activate(ClideExtensionContext ctx) async {
_sub = ctx.events.on<DaemonEvent>().listen((e) {
if (e.subsystem != 'editor') return;
if (e.kind != 'editor.opened' && e.kind != 'editor.active-changed') return;
ctx.panels.activateTab(Slots.workspace, 'editor.active');
switch (e.kind) {
case 'editor.opened':
ctx.arrangement.openEditor();
ctx.panels.activateTab(Slots.workspace, 'editor.active');
case 'editor.active-changed':
// A null id means the last buffer closed — collapse the split.
if (e.data['id'] == null) {
ctx.arrangement.closeEditor();
} else {
ctx.arrangement.openEditor();
ctx.panels.activateTab(Slots.workspace, 'editor.active');
}
}
});
}