jpmschweitzer/clide
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: adopt Dart 3.9 toolchain — honest floor + tall-style reformat (T-353)

Browse Source 
Raise the declared minimums in pubspec.yaml to what our deps already
require: Flutter >=3.35.0 / Dart >=3.9.0 (was 3.19.0 / 3.5.0). alchemist
0.12 needs Flutter 3.32; Dart 3.9 first ships in Flutter 3.35, so 3.35 is
the binding floor. Pin the exact build toolchain in .fvmrc (Flutter
3.44.1).

Moving to the Dart 3.9 language level switches `dart format` to the new
"tall" style and enables two new lints. This commit is the resulting
mechanical churn, isolated from any behaviour change:
  - whole-tree `dart format` reformat (tall style)
  - `dart fix` for unnecessary_underscores + use_null_aware_elements

No runtime behaviour change; `make test` green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
jpmschweitzer
2026-06-11 12:11:53 +02:00
co-authored by Claude Opus 4.8
parent bcea5f15b7
commit 6d0ebab721
444 changed files with 7587 additions and 12849 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/widgets/more_widgets_test.dart
+31 -56
View File
@@ -72,10 +72,7 @@ After.
testWidgets('record-id link fires onRecordTap callback', (tester) async {
var tapped = '';
const src = 'See [D-1](#anchor) for details.';
await tester.pumpWidget(harness(
f,
ClideMarkdown(src, onRecordTap: (id) => tapped = id),
));
await tester.pumpWidget(harness(f, ClideMarkdown(src, onRecordTap: (id) => tapped = id)));
await tester.pumpAndSettle();
// The record-link path matches D-1 / Q-N / R-N / T-N and produces
// a tappable span. We can't easily simulate a TextSpan tap from
@@ -88,9 +85,7 @@ After.
testWidgets('record-id link tap actually invokes onRecordTap', (tester) async {
var tapped = '';
const src = '[D-1](#anchor)';
await tester.pumpWidget(
harness(f, ClideMarkdown(src, onRecordTap: (id) => tapped = id)),
);
await tester.pumpWidget(harness(f, ClideMarkdown(src, onRecordTap: (id) => tapped = id)));
await tester.pumpAndSettle();
// The link renders as a ClideTappable embedded in a WidgetSpan.
await tester.tap(find.text('D-1'));
@@ -200,10 +195,7 @@ After.
});
testWidgets('handles a language whose grammar is unavailable (falls back to plain text)', (tester) async {
await tester.pumpWidget(harness(
f,
const ClideCodeBlock(source: 'fn main() {}', language: 'rust'),
));
await tester.pumpWidget(harness(f, const ClideCodeBlock(source: 'fn main() {}', language: 'rust')));
await tester.pumpAndSettle();
// TreeSitterService can't load the grammar in tests → falls back
// to plain rendering.
@@ -226,16 +218,12 @@ After.
testWidgets('collapsed accordion does not render children; tap toggles', (tester) async {
var toggled = 0;
await tester.pumpWidget(harness(
f,
ClideAccordion(
label: 'Group',
count: 2,
expanded: false,
onToggle: () => toggled++,
children: const [Text('child-one'), Text('child-two')],
await tester.pumpWidget(
harness(
f,
ClideAccordion(label: 'Group', count: 2, expanded: false, onToggle: () => toggled++, children: const [Text('child-one'), Text('child-two')]),
),
));
);
await tester.pumpAndSettle();
expect(find.text('Group · 2'), findsOneWidget);
expect(find.text('child-one'), findsNothing);
@@ -244,17 +232,9 @@ After.
});
testWidgets('expanded accordion shows children; leading widget renders', (tester) async {
await tester.pumpWidget(harness(
f,
ClideAccordion(
label: 'Open',
count: 1,
expanded: true,
onToggle: () {},
leading: const Text('LEAD'),
children: const [Text('only-child')],
),
));
await tester.pumpWidget(
harness(f, ClideAccordion(label: 'Open', count: 1, expanded: true, onToggle: () {}, leading: const Text('LEAD'), children: const [Text('only-child')])),
);
await tester.pumpAndSettle();
expect(find.text('only-child'), findsOneWidget);
expect(find.text('LEAD'), findsOneWidget);
@@ -269,36 +249,25 @@ After.
testWidgets('wraps a Scrollable child and exposes ScrollbarTheme', (tester) async {
final controller = ScrollController();
addTearDown(controller.dispose);
await tester.pumpWidget(harness(
f,
SizedBox(
height: 100,
child: ClideScrollbar(
controller: controller,
child: SingleChildScrollView(
await tester.pumpWidget(
harness(
f,
SizedBox(
height: 100,
child: ClideScrollbar(
controller: controller,
child: const SizedBox(height: 1000),
child: SingleChildScrollView(controller: controller, child: const SizedBox(height: 1000)),
),
),
),
));
);
await tester.pumpAndSettle();
expect(find.byType(ClideScrollbar), findsOneWidget);
});
test('ScrollbarTheme.updateShouldNotify detects colour changes', () {
const a = ScrollbarTheme(
slider: Color(0xFF000000),
sliderHover: Color(0xFF111111),
track: Color(0xFF222222),
child: SizedBox.shrink(),
);
const b = ScrollbarTheme(
slider: Color(0xFFFFFFFF),
sliderHover: Color(0xFF111111),
track: Color(0xFF222222),
child: SizedBox.shrink(),
);
const a = ScrollbarTheme(slider: Color(0xFF000000), sliderHover: Color(0xFF111111), track: Color(0xFF222222), child: SizedBox.shrink());
const b = ScrollbarTheme(slider: Color(0xFFFFFFFF), sliderHover: Color(0xFF111111), track: Color(0xFF222222), child: SizedBox.shrink());
expect(a.updateShouldNotify(b), isTrue);
expect(a.updateShouldNotify(a), isFalse);
});
@@ -311,10 +280,16 @@ After.
testWidgets('renders Semantics live region wrapping a TerminalView', (tester) async {
final terminal = Terminal(maxLines: 100, onOutput: (_) {});
await tester.pumpWidget(harness(
f,
SizedBox(width: 400, height: 200, child: ClidePtyView(terminal: terminal, label: 'test-pane')),
));
await tester.pumpWidget(
harness(
f,
SizedBox(
width: 400,
height: 200,
child: ClidePtyView(terminal: terminal, label: 'test-pane'),
),
),
);
await tester.pumpAndSettle();
expect(find.byType(ClidePtyView), findsOneWidget);
// The TerminalView inside renders the actual viewport.