jpmschweitzer/clide
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: adopt Dart 3.9 toolchain — honest floor + tall-style reformat (T-353)

Browse Source 
Raise the declared minimums in pubspec.yaml to what our deps already
require: Flutter >=3.35.0 / Dart >=3.9.0 (was 3.19.0 / 3.5.0). alchemist
0.12 needs Flutter 3.32; Dart 3.9 first ships in Flutter 3.35, so 3.35 is
the binding floor. Pin the exact build toolchain in .fvmrc (Flutter
3.44.1).

Moving to the Dart 3.9 language level switches `dart format` to the new
"tall" style and enables two new lints. This commit is the resulting
mechanical churn, isolated from any behaviour change:
  - whole-tree `dart format` reformat (tall style)
  - `dart fix` for unnecessary_underscores + use_null_aware_elements

No runtime behaviour change; `make test` green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
jpmschweitzer
2026-06-11 12:11:53 +02:00
co-authored by Claude Opus 4.8
parent bcea5f15b7
commit 6d0ebab721
444 changed files with 7587 additions and 12849 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/pty/env_test.dart
+3 -12
View File
@@ -36,29 +36,20 @@ void main() {
test('on macOS, includes the well-known extras', () {
if (!Platform.isMacOS) return;
// Homebrew is the canonical one; at least one of these should appear.
expect(
expandedPath,
anyOf(contains('/opt/homebrew/bin'), contains('/usr/local/bin')),
);
expect(expandedPath, anyOf(contains('/opt/homebrew/bin'), contains('/usr/local/bin')));
});
});
group('mergePtyEnv', () {
test('clide defaults override the process env where they overlap', () {
final merged = mergePtyEnv(processEnv: {
'TERM': 'dumb',
'CUSTOM': 'preserved',
});
final merged = mergePtyEnv(processEnv: {'TERM': 'dumb', 'CUSTOM': 'preserved'});
expect(merged['TERM'], 'xterm-256color'); // clide default wins
expect(merged['COLORTERM'], 'truecolor');
expect(merged['CUSTOM'], 'preserved'); // process env retained
});
test('overrides win over both process env and clide defaults', () {
final merged = mergePtyEnv(
processEnv: {'TERM': 'dumb'},
overrides: {'TERM': 'screen-256color'},
);
final merged = mergePtyEnv(processEnv: {'TERM': 'dumb'}, overrides: {'TERM': 'screen-256color'});
expect(merged['TERM'], 'screen-256color');
});
test/pty/session_test.dart
+10 -40
View File
@@ -33,10 +33,7 @@ void main() {
columns: 80,
rows: 24,
workingDirectory: '/',
environment: {
...Platform.environment,
'TERM': 'xterm-256color',
},
environment: {...Platform.environment, 'TERM': 'xterm-256color'},
);
addTearDown(s.close);
@@ -51,10 +48,7 @@ void main() {
columns: 80,
rows: 24,
workingDirectory: '/',
environment: {
...Platform.environment,
'TERM': 'xterm-256color',
},
environment: {...Platform.environment, 'TERM': 'xterm-256color'},
);
addTearDown(s.close);
@@ -68,10 +62,7 @@ void main() {
});
addTearDown(sub.cancel);
await firstByte.future.timeout(
ioTimeout,
onTimeout: () => fail('shell never produced its first byte within ${ioTimeout.inSeconds}s'),
);
await firstByte.future.timeout(ioTimeout, onTimeout: () => fail('shell never produced its first byte within ${ioTimeout.inSeconds}s'));
s.write(utf8.encode('echo write-test-ok\n'));
@@ -86,20 +77,14 @@ void main() {
columns: 80,
rows: 24,
workingDirectory: '/',
environment: {
...Platform.environment,
'TERM': 'xterm-256color',
},
environment: {...Platform.environment, 'TERM': 'xterm-256color'},
);
final done = Completer<void>();
s.output.listen((_) {}, onDone: () => done.complete());
await s.close();
await done.future.timeout(
ioTimeout,
onTimeout: () => fail('output stream did not close within ${ioTimeout.inSeconds}s after s.close()'),
);
await done.future.timeout(ioTimeout, onTimeout: () => fail('output stream did not close within ${ioTimeout.inSeconds}s after s.close()'));
expect(s.isClosed, isTrue);
});
@@ -111,10 +96,7 @@ void main() {
columns: 80,
rows: 24,
workingDirectory: '/',
environment: {
...Platform.environment,
'TERM': 'xterm-256color',
},
environment: {...Platform.environment, 'TERM': 'xterm-256color'},
);
addTearDown(s.close);
@@ -133,10 +115,7 @@ void main() {
columns: 80,
rows: 24,
workingDirectory: '/tmp/clide-no-such-dir-${DateTime.now().microsecondsSinceEpoch}',
environment: {
...Platform.environment,
'TERM': 'xterm-256color',
},
environment: {...Platform.environment, 'TERM': 'xterm-256color'},
),
throwsA(isA<PtyException>().having((e) => e.errno, 'errno', 2)),
);
@@ -153,10 +132,7 @@ void main() {
columns: 80,
rows: 24,
workingDirectory: '/',
environment: {
...Platform.environment,
'TERM': 'xterm-256color',
},
environment: {...Platform.environment, 'TERM': 'xterm-256color'},
),
throwsA(isA<PtyException>().having((e) => e.errno, 'errno', 2)),
);
@@ -172,10 +148,7 @@ void main() {
columns: 80,
rows: 24,
workingDirectory: '/',
environment: {
...Platform.environment,
'TERM': 'xterm-256color',
},
environment: {...Platform.environment, 'TERM': 'xterm-256color'},
);
addTearDown(s.close);
expect(s.pid, greaterThan(0));
@@ -188,10 +161,7 @@ void main() {
columns: 80,
rows: 24,
workingDirectory: '/',
environment: {
...Platform.environment,
'TERM': 'xterm-256color',
},
environment: {...Platform.environment, 'TERM': 'xterm-256color'},
);
addTearDown(s.close);
s.resize(cols: 120, rows: 30);