chore: adopt Dart 3.9 toolchain — honest floor + tall-style reformat (T-353)
Raise the declared minimums in pubspec.yaml to what our deps already require: Flutter >=3.35.0 / Dart >=3.9.0 (was 3.19.0 / 3.5.0). alchemist 0.12 needs Flutter 3.32; Dart 3.9 first ships in Flutter 3.35, so 3.35 is the binding floor. Pin the exact build toolchain in .fvmrc (Flutter 3.44.1). Moving to the Dart 3.9 language level switches `dart format` to the new "tall" style and enables two new lints. This commit is the resulting mechanical churn, isolated from any behaviour change: - whole-tree `dart format` reformat (tall style) - `dart fix` for unnecessary_underscores + use_null_aware_elements No runtime behaviour change; `make test` green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -4,11 +4,7 @@ import 'package:test/test.dart';
|
||||
void main() {
|
||||
group('IpcRequest', () {
|
||||
test('encodes and decodes round-trip', () {
|
||||
final req = IpcRequest(
|
||||
id: '42',
|
||||
cmd: 'git.status',
|
||||
args: const {'path': '.'},
|
||||
);
|
||||
final req = IpcRequest(id: '42', cmd: 'git.status', args: const {'path': '.'});
|
||||
final line = req.encode();
|
||||
final decoded = IpcMessage.decode(line);
|
||||
expect(decoded, isA<IpcRequest>());
|
||||
@@ -49,32 +45,18 @@ void main() {
|
||||
test('encodes with error payload, no data', () {
|
||||
final r = IpcResponse.err(
|
||||
id: '9',
|
||||
error: IpcError(
|
||||
code: IpcExitCode.notFound,
|
||||
kind: IpcErrorKind.notFound,
|
||||
message: 'missing',
|
||||
hint: 'try --help',
|
||||
),
|
||||
error: IpcError(code: IpcExitCode.notFound, kind: IpcErrorKind.notFound, message: 'missing', hint: 'try --help'),
|
||||
);
|
||||
final json = r.toJson();
|
||||
expect(json['ok'], false);
|
||||
expect(json['error'], {
|
||||
'code': 3,
|
||||
'kind': 'not_found',
|
||||
'message': 'missing',
|
||||
'hint': 'try --help',
|
||||
});
|
||||
expect(json['error'], {'code': 3, 'kind': 'not_found', 'message': 'missing', 'hint': 'try --help'});
|
||||
expect(json.containsKey('data'), isFalse);
|
||||
});
|
||||
|
||||
test('decode preserves error fields', () {
|
||||
final original = IpcResponse.err(
|
||||
id: '9',
|
||||
error: IpcError(
|
||||
code: IpcExitCode.conflict,
|
||||
kind: IpcErrorKind.conflict,
|
||||
message: 'race',
|
||||
),
|
||||
error: IpcError(code: IpcExitCode.conflict, kind: IpcErrorKind.conflict, message: 'race'),
|
||||
);
|
||||
final r = IpcMessage.decode(original.encode()) as IpcResponse;
|
||||
expect(r.ok, false);
|
||||
@@ -89,12 +71,7 @@ void main() {
|
||||
group('IpcEvent', () {
|
||||
test('serializes subsystem + kind + ts + data', () {
|
||||
final ts = DateTime.utc(2026, 4, 21, 12, 0, 0);
|
||||
final e = IpcEvent(
|
||||
subsystem: 'git',
|
||||
kind: 'status-changed',
|
||||
timestamp: ts,
|
||||
data: const {'staged': 3},
|
||||
);
|
||||
final e = IpcEvent(subsystem: 'git', kind: 'status-changed', timestamp: ts, data: const {'staged': 3});
|
||||
final json = e.toJson();
|
||||
expect(json['type'], 'event');
|
||||
expect(json['subsystem'], 'git');
|
||||
@@ -110,10 +87,7 @@ void main() {
|
||||
});
|
||||
|
||||
test('throws on unknown type', () {
|
||||
expect(
|
||||
() => IpcMessage.decode('{"type":"bogus","id":"1"}'),
|
||||
throwsA(isA<FormatException>()),
|
||||
);
|
||||
expect(() => IpcMessage.decode('{"type":"bogus","id":"1"}'), throwsA(isA<FormatException>()));
|
||||
});
|
||||
|
||||
test('throws on malformed JSON', () {
|
||||
|
||||
Reference in New Issue
Block a user