chore: adopt Dart 3.9 toolchain — honest floor + tall-style reformat (T-353)

Raise the declared minimums in pubspec.yaml to what our deps already
require: Flutter >=3.35.0 / Dart >=3.9.0 (was 3.19.0 / 3.5.0). alchemist
0.12 needs Flutter 3.32; Dart 3.9 first ships in Flutter 3.35, so 3.35 is
the binding floor. Pin the exact build toolchain in .fvmrc (Flutter
3.44.1).

Moving to the Dart 3.9 language level switches `dart format` to the new
"tall" style and enables two new lints. This commit is the resulting
mechanical churn, isolated from any behaviour change:
  - whole-tree `dart format` reformat (tall style)
  - `dart fix` for unnecessary_underscores + use_null_aware_elements

No runtime behaviour change; `make test` green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-06-11 12:11:53 +02:00
co-authored by Claude Opus 4.8
parent bcea5f15b7
commit 6d0ebab721
444 changed files with 7587 additions and 12849 deletions
+31 -27
View File
@@ -12,9 +12,9 @@ import '../../helpers/kernel_fixture.dart';
IpcResponse _ok(Map<String, Object?> data) => IpcResponse.ok(id: '', data: data);
IpcResponse _err(String m) => IpcResponse.err(
id: '',
error: IpcError(code: IpcExitCode.toolError, kind: IpcErrorKind.toolError, message: m),
);
id: '',
error: IpcError(code: IpcExitCode.toolError, kind: IpcErrorKind.toolError, message: m),
);
void main() {
late KernelFixture f;
@@ -48,12 +48,13 @@ void main() {
test('search populates ranked results', () async {
f.ipc.stub(
'pql.search',
(args) async => _ok({
'results': [
{'path': 'a.md', 'score': 0.8},
],
}));
'pql.search',
(args) async => _ok({
'results': [
{'path': 'a.md', 'score': 0.8},
],
}),
);
await c.search('term');
expect(c.results.single['path'], 'a.md');
expect(c.error, isNull);
@@ -78,12 +79,13 @@ void main() {
test('runQuery populates rows; error surfaces', () async {
f.ipc.stub(
'pql.query',
(args) async => _ok({
'results': [
{'name': 'T-1'},
],
}));
'pql.query',
(args) async => _ok({
'results': [
{'name': 'T-1'},
],
}),
);
await c.runQuery("type = 'ticket'");
expect(c.results.single['name'], 'T-1');
@@ -95,12 +97,13 @@ void main() {
test('loadMarkdownFiles populates + errors', () async {
f.ipc.stub(
'pql.files',
(args) async => _ok({
'files': [
{'path': 'docs/x.md'},
],
}));
'pql.files',
(args) async => _ok({
'files': [
{'path': 'docs/x.md'},
],
}),
);
await c.loadMarkdownFiles();
expect(c.results.single['path'], 'docs/x.md');
@@ -126,12 +129,13 @@ void main() {
test('setSearchMode + toggleSearchMode flip the mode and clear results', () async {
f.ipc.stub(
'pql.search',
(_) async => _ok({
'results': [
{'path': 'a.md', 'score': 0.5},
],
}));
'pql.search',
(_) async => _ok({
'results': [
{'path': 'a.md', 'score': 0.5},
],
}),
);
await c.search('x');
expect(c.results, isNotEmpty);
c.setSearchMode(SearchMode.dsl);