chore: adopt Dart 3.9 toolchain — honest floor + tall-style reformat (T-353)

Raise the declared minimums in pubspec.yaml to what our deps already
require: Flutter >=3.35.0 / Dart >=3.9.0 (was 3.19.0 / 3.5.0). alchemist
0.12 needs Flutter 3.32; Dart 3.9 first ships in Flutter 3.35, so 3.35 is
the binding floor. Pin the exact build toolchain in .fvmrc (Flutter
3.44.1).

Moving to the Dart 3.9 language level switches `dart format` to the new
"tall" style and enables two new lints. This commit is the resulting
mechanical churn, isolated from any behaviour change:
  - whole-tree `dart format` reformat (tall style)
  - `dart fix` for unnecessary_underscores + use_null_aware_elements

No runtime behaviour change; `make test` green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-06-11 12:11:53 +02:00
co-authored by Claude Opus 4.8
parent bcea5f15b7
commit 6d0ebab721
444 changed files with 7587 additions and 12849 deletions
+31 -22
View File
@@ -16,18 +16,21 @@ import 'helpers/kernel_fixture.dart';
Finder _icon(PhosphorIconPainter p) => find.byWidgetPredicate((w) => w is ClideIcon && w.painter == p);
Widget _host(KernelFixture f, Widget child) => Directionality(
textDirection: TextDirection.ltr,
child: ClideKernel(
services: f.services,
child: ClideTheme(
controller: f.services.theme,
child: MediaQuery(
data: const MediaQueryData(size: Size(800, 200)),
child: Align(alignment: Alignment.topLeft, child: SizedBox(height: 26, child: child)),
),
textDirection: TextDirection.ltr,
child: ClideKernel(
services: f.services,
child: ClideTheme(
controller: f.services.theme,
child: MediaQuery(
data: const MediaQueryData(size: Size(800, 200)),
child: Align(
alignment: Alignment.topLeft,
child: SizedBox(height: 26, child: child),
),
),
);
),
),
);
void main() {
late KernelFixture f;
@@ -54,13 +57,17 @@ void main() {
testWidgets('the chevron flips live when the collapsed state changes', (tester) async {
var collapsed = false;
late StateSetter setOuter;
await tester.pumpWidget(_host(
f,
StatefulBuilder(builder: (ctx, setState) {
setOuter = setState;
return StatusbarCollapseToggle(slot: Slots.sidebar, collapsed: collapsed, visible: true);
}),
));
await tester.pumpWidget(
_host(
f,
StatefulBuilder(
builder: (ctx, setState) {
setOuter = setState;
return StatusbarCollapseToggle(slot: Slots.sidebar, collapsed: collapsed, visible: true);
},
),
),
);
await tester.pump();
expect(_icon(PhosphorIcons.byName('caret-line-left')), findsOneWidget);
@@ -78,11 +85,13 @@ void main() {
});
testWidgets('tapping fires the matching collapse command', (tester) async {
f.services.arrangement.applyPreset(const LayoutPresetContribution(
id: 'test',
displayName: 'test',
slots: [LayoutSlot(slot: Slots.sidebar, position: SlotPosition.left, visible: true)],
));
f.services.arrangement.applyPreset(
const LayoutPresetContribution(
id: 'test',
displayName: 'test',
slots: [LayoutSlot(slot: Slots.sidebar, position: SlotPosition.left, visible: true)],
),
);
f.services.extensions.register(DefaultLayoutExtension());
await f.services.extensions.activate('builtin.default-layout');