map POSIX errno to actionable IPC error kinds (T-79)

pane.spawn (via PtyException.errno) and editor.open (via FileSystemException.osError.errorCode) now route ENOENT to not_found, EACCES/EPERM to user_error with a permissions hint, EISDIR/ENOTDIR/EEXIST to distinct user-error/conflict, and EMFILE/ENFILE to tool_error with a "fd limit hit" hint. The mapping lives in lib/src/ipc/errno_mapping.dart so other handlers can adopt the same surface as they pick up errno-bearing failures. Co-Authored-By: Claude <noreply@anthropic.com>
2026-05-06 09:56:04 +02:00
parent 41fd586ca0
commit 5fb3df84ed
6 changed files with 224 additions and 5 deletions
@@ -0,0 +1,55 @@
+import 'package:clide/src/ipc/errno_mapping.dart';
+import 'package:clide/src/ipc/schema_v1.dart';
+import 'package:test/test.dart';
+
+void main() {
+  group('errnoToIpcError', () {
+    test('ENOENT → notFound with target', () {
+      final err = errnoToIpcError(errno: PosixErrno.enoent, op: 'pane.spawn', target: 'claude');
+      expect(err.kind, IpcErrorKind.notFound);
+      expect(err.code, IpcExitCode.notFound);
+      expect(err.message, contains('claude'));
+      expect(err.message, contains('not found'));
+    });
+
+    test('EACCES → userError with hint', () {
+      final err = errnoToIpcError(errno: PosixErrno.eacces, op: 'editor.open', target: '/etc/shadow');
+      expect(err.kind, IpcErrorKind.userError);
+      expect(err.code, IpcExitCode.userError);
+      expect(err.message, contains('permission denied'));
+      expect(err.hint, isNotNull);
+    });
+
+    test('EISDIR → userError', () {
+      final err = errnoToIpcError(errno: PosixErrno.eisdir, op: 'editor.open', target: 'src/');
+      expect(err.kind, IpcErrorKind.userError);
+      expect(err.message, contains('is a directory'));
+    });
+
+    test('EEXIST → conflict', () {
+      final err = errnoToIpcError(errno: PosixErrno.eexist, op: 'files.create', target: 'README.md');
+      expect(err.kind, IpcErrorKind.conflict);
+      expect(err.code, IpcExitCode.conflict);
+    });
+
+    test('EMFILE → toolError with hint', () {
+      final err = errnoToIpcError(errno: PosixErrno.emfile, op: 'pane.spawn');
+      expect(err.kind, IpcErrorKind.toolError);
+      expect(err.message, contains('too many open files'));
+      expect(err.hint, isNotNull);
+    });
+
+    test('unknown errno falls through to toolError', () {
+      final err = errnoToIpcError(errno: 999, op: 'pane.spawn');
+      expect(err.kind, IpcErrorKind.toolError);
+      expect(err.code, IpcExitCode.toolError);
+      expect(err.message, contains('errno=999'));
+    });
+
+    test('raw message overrides errno suffix in fallback', () {
+      final err = errnoToIpcError(errno: 999, op: 'pane.spawn', raw: 'kernel exploded');
+      expect(err.message, contains('kernel exploded'));
+      expect(err.message, isNot(contains('errno=999')));
+    });
+  });
+}