jpmschweitzer/clide
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

keep the clide.dart barrel Flutter-free

Browse Source 
`lib/kernel/src/toolchain.dart` is a `ChangeNotifier`, so it pulls in
`package:flutter/foundation.dart`. `GitClient` and `PqlClient` imported
it for the resolved binary paths, which leaked Flutter through the
`package:clide/clide.dart` barrel — breaking `dart test` on every core
subsystem suite (`ci/test_core.sh`), since pure Dart can't compile
Flutter packages.

Split the Flutter-free pieces into `toolchain_paths.dart`: `ResolvedPaths`,
`resolveToolchainPaths`, and a new read-only `ToolchainView` interface
with a `ToolchainView.resolved()` const factory. `Toolchain` now
implements `ToolchainView`; the clients depend on the interface. Core
test setups that built a `Toolchain` just to call `applyResolved`
switch to the factory.

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
jpmschweitzer
2026-05-14 21:21:09 +02:00
co-authored by Claude
parent a3a10cddf3
commit 5cad98224f
10 changed files with 172 additions and 170 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/git/client_test.dart
+3 -8
View File
@@ -5,16 +5,12 @@ library;
import 'dart:io';
import 'package:clide/kernel/src/toolchain.dart';
import 'package:clide/kernel/src/toolchain_paths.dart';
import 'package:clide/src/git/client.dart';
import 'package:clide/src/git/operations.dart' show GitException;
import 'package:test/test.dart';
Toolchain _toolchain() {
final t = Toolchain();
t.applyResolved(Toolchain.resolvePaths(workspaceRoot: Directory.current.path));
return t;
}
ToolchainView _toolchain() => ToolchainView.resolved(resolveToolchainPaths(Directory.current.path));
Future<Directory> _newRepo({String filename = 'file.txt', String contents = 'hello\n'}) async {
final dir = await Directory.systemTemp.createTemp('clide-git-client-');
@@ -195,8 +191,7 @@ void main() {
group('GitClient — error surface', () {
test('a bad git binary path makes _run throw GitException', () async {
final t = Toolchain();
t.applyResolved(const ResolvedPaths(git: '/tmp/clide-no-such-git-binary'));
final t = ToolchainView.resolved(const ResolvedPaths(git: '/tmp/clide-no-such-git-binary'));
final dir = await Directory.systemTemp.createTemp('clide-git-bad-');
addTearDown(() => dir.deleteSync(recursive: true));
final git = GitClient(toolchain: t, workDir: dir);