keep the clide.dart barrel Flutter-free

`lib/kernel/src/toolchain.dart` is a `ChangeNotifier`, so it pulls in
`package:flutter/foundation.dart`. `GitClient` and `PqlClient` imported
it for the resolved binary paths, which leaked Flutter through the
`package:clide/clide.dart` barrel — breaking `dart test` on every core
subsystem suite (`ci/test_core.sh`), since pure Dart can't compile
Flutter packages.

Split the Flutter-free pieces into `toolchain_paths.dart`: `ResolvedPaths`,
`resolveToolchainPaths`, and a new read-only `ToolchainView` interface
with a `ToolchainView.resolved()` const factory. `Toolchain` now
implements `ToolchainView`; the clients depend on the interface. Core
test setups that built a `Toolchain` just to call `applyResolved`
switch to the factory.

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
2026-05-14 21:21:09 +02:00
co-authored by Claude
parent a3a10cddf3
commit 5cad98224f
10 changed files with 172 additions and 170 deletions
+2 -3
View File
@@ -8,7 +8,7 @@ library;
import 'dart:io';
import 'package:clide/clide.dart';
import 'package:clide/kernel/src/toolchain.dart';
import 'package:clide/kernel/src/toolchain_paths.dart';
import 'package:clide/src/daemon/git_commands.dart';
import 'package:test/test.dart';
@@ -18,8 +18,7 @@ void main() {
setUp(() async {
sandbox = await Directory.systemTemp.createTemp('clide-git-cmd-err-');
final toolchain = Toolchain();
toolchain.applyResolved(const ResolvedPaths(git: '/tmp/clide-no-such-git-binary'));
final toolchain = ToolchainView.resolved(const ResolvedPaths(git: '/tmp/clide-no-such-git-binary'));
final git = GitClient(toolchain: toolchain, workDir: sandbox);
dispatcher = DaemonDispatcher();
final sink = RecordingEventSink();