jpmschweitzer/clide
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

run the PTY tests serially instead of retrying them

Browse Source 
The pty-tagged tests spawn real PTYs and flaked when dart test ran them in
parallel (fd contention) — papered over with retry: 2. Run that pass with
--concurrency=1 and drop the retries: serialization is the correct fix for
resource-bound tests. Verified stable across repeated runs.

T-193.

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
jpmschweitzer
2026-05-31 19:01:42 +02:00
co-authored by Claude
parent 89766df55c
commit 5b739ef6a7
3 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ci/test.sh
+5 -2
View File
@@ -24,8 +24,11 @@ flutter analyze
echo "==> dart format (whole tree)"
dart format --set-exit-if-changed .
echo "==> dart test (pty — unreliable under the flutter test runner)"
dart test --tags pty test/pty/session_test.dart test/panes/registry_test.dart
echo "==> dart test (pty — unreliable under the flutter test runner; serial)"
# --concurrency=1: these spawn real PTYs and compete for fds when run in
# parallel, which flaked them (registry/session). Serialize — the proper fix
# for resource-bound tests, vs. the old per-test `retry:` band-aid. (T-193)
dart test --concurrency=1 --tags pty test/pty/session_test.dart test/panes/registry_test.dart
if [[ "$coverage" == 1 ]]; then
echo "==> flutter test --coverage (gate; unit + widget + golden + a11y)"