add in-app "Install clide command in PATH" affordance (T-212)

A command-palette / `clide` CLI verb (`clide.installCli`) copies the bundled C client into ~/.local/bin, VS Code "Install code command" style, so a user who runs the app without `make install` can still reach the CLI from a shell. On launch the app detects when `clide` is missing from PATH or resolves to a stale symlink into the Flutter GUI bundle (the dogfood footgun: a bare `clide` launched a second app instead of querying the socket) and notifies with a pointer to the command. `make build` now ships the C client inside the app bundle so the affordance can self-install from it; `make run` points it at the dev-tree client via CLIDE_CLI_BIN. Detection and the copy live in the Flutter-free CliInstaller (kernel/src/cli_install.dart) so they run under unit tests without a real install. Closes epic T-209 (ship the clide CLI on PATH). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-06 12:05:41 +02:00
parent 02a19d10f5
commit 562c17c06d
10 changed files with 696 additions and 4 deletions
@@ -0,0 +1,84 @@
+import 'dart:io';
+
+import 'package:clide/clide.dart';
+import 'package:clide/extension/extension.dart';
+import 'package:clide/kernel/src/cli_install.dart';
+
+/// VS Code-style "Install 'clide' command in PATH" affordance (T-212).
+///
+/// Registers a palette/CLI command that copies the bundled C client into a
+/// PATH dir, and on activation proactively warns when `clide` is missing from
+/// PATH or — the dogfood footgun — resolves to a stale symlink into the
+/// Flutter GUI bundle instead of the C client. Detection and the copy live in
+/// the Flutter-free [CliInstaller]; this extension only wires it to the
+/// command and notification surfaces.
+class CliInstallExtension extends ClideExtension {
+  CliInstallExtension({CliInstaller? installer}) : _installer = installer;
+
+  CliInstaller? _installer;
+  ClideExtensionContext? _ctx;
+
+  CliInstaller get _resolved => _installer ??= CliInstaller(resolvedExecutable: Platform.resolvedExecutable);
+
+  @override
+  String get id => 'builtin.cli-install';
+  @override
+  String get title => 'CLI Install';
+  @override
+  String get version => '0.1.0';
+
+  @override
+  Future<void> activate(ClideExtensionContext ctx) async {
+    _ctx = ctx;
+    // Proactive launch-time detection (desktop only). Non-modal: we notify
+    // and point at the command rather than auto-installing — no surprise
+    // filesystem writes (interaction-zone discipline, D-78).
+    if (!(Platform.isLinux || Platform.isMacOS)) return;
+    switch (_resolved.inspect().state) {
+      case CliInstallState.missing:
+        ctx.notify.warn(
+          'The `clide` command is not on your PATH. Run "clide: Install '
+          'command in PATH" from the command palette to reach it from a shell.',
+          title: 'clide CLI not installed',
+        );
+      case CliInstallState.staleGui:
+        ctx.notify.warn(
+          '`clide` on your PATH points at the GUI app, not the CLI client — '
+          'a bare `clide` launches a second app. Run "clide: Install command '
+          'in PATH" to replace it.',
+          title: 'clide CLI is stale',
+        );
+      case CliInstallState.installed:
+        break;
+    }
+  }
+
+  @override
+  List<ContributionPoint> get contributions => [
+        CommandContribution(
+          id: 'clide.installCli',
+          command: 'clide.installCli',
+          title: "clide: Install 'clide' command in PATH",
+          run: (_) async {
+            final r = _resolved.install();
+            final ctx = _ctx;
+            if (r.ok) {
+              ctx?.notify.success(r.message, title: 'clide CLI installed');
+              return IpcResponse.ok(id: '', data: {
+                'installed': r.installedPath,
+                'onPath': r.onPath,
+              });
+            }
+            ctx?.notify.error(r.message, title: 'clide CLI install failed');
+            return IpcResponse.err(
+              id: '',
+              error: IpcError(
+                code: IpcExitCode.toolError,
+                kind: IpcErrorKind.toolError,
+                message: r.message,
+              ),
+            );
+          },
+        ),
+      ];
+}