add ClidePane primitive + focus-driven status-bar slot

Replace the MessageBus-based pane-context slot with a focus-driven one. Panes keep their status widget locally; the FocusTracker holds the focused pane's widget (activeStatusWidget) and ClidePane conveys it to the shared slot only while its contribution is focused, re-conveying on change and clearing on blur. The status-bar item just renders focus.activeStatusWidget, height-clamped and marquee-scrolled when it overflows. Removes the publish/subscribe race the bus version had. T-150. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-23 11:23:30 +02:00
parent 9590f555c9
commit 478cff6050
13 changed files with 492 additions and 116 deletions
@@ -0,0 +1,32 @@
+/// Tests for ClideMarquee (T-150): static when the child fits, scrolls
+/// (looped copy) when it overflows; clips its box.
+library;
+
+import 'package:clide/widgets/widgets.dart';
+import 'package:flutter/widgets.dart';
+import 'package:flutter_test/flutter_test.dart';
+
+Widget _boxed(double width, Widget child) => Directionality(
+      textDirection: TextDirection.ltr,
+      child: Center(
+        child: SizedBox(width: width, height: 16, child: child),
+      ),
+    );
+
+void main() {
+  testWidgets('shows the child statically when it fits', (tester) async {
+    await tester.pumpWidget(_boxed(300, const ClideMarquee(child: Text('short'))));
+    await tester.pump();
+    expect(find.text('short'), findsOneWidget);
+    await tester.pumpWidget(const SizedBox()); // tear down the ticker
+  });
+
+  testWidgets('renders a looped copy and runs without overflow when wider than the slot', (tester) async {
+    await tester.pumpWidget(_boxed(40, const ClideMarquee(child: Text('a long status line that overflows the slot'))));
+    await tester.pump(); // measure
+    await tester.pump(const Duration(milliseconds: 100)); // advance the ticker
+    expect(find.text('a long status line that overflows the slot'), findsWidgets);
+    expect(tester.takeException(), isNull);
+    await tester.pumpWidget(const SizedBox()); // dispose → stop ticker
+  });
+}
@@ -0,0 +1,78 @@
+/// Tests for ClidePane (T-150): it surfaces its statusWidget to the
+/// FocusTracker slot only while it is the shown (focused + active) pane.
+library;
+
+import 'package:clide/kernel/src/panels/slot_id.dart';
+import 'package:clide/widgets/widgets.dart';
+import 'package:flutter/widgets.dart';
+import 'package:flutter_test/flutter_test.dart';
+
+import '../../helpers/kernel_fixture.dart';
+import '../../helpers/widget_harness.dart';
+
+void main() {
+  late KernelFixture f;
+  setUp(() async => f = await KernelFixture.create());
+  tearDown(() => f.dispose());
+
+  testWidgets('conveys its status while its contribution is focused, clears on blur', (tester) async {
+    await tester.pumpWidget(harness(
+      f,
+      const ClidePane(
+        contributionId: 'pane.x',
+        statusWidget: Text('S', textDirection: TextDirection.ltr),
+        child: SizedBox(),
+      ),
+    ));
+    final focus = f.services.focus;
+    expect(focus.activeStatusWidget, isNull); // not focused yet
+
+    focus.setActive(slot: Slots.workspace, contributionId: 'pane.x');
+    await tester.pump();
+    expect(focus.activeStatusWidget, isA<Text>());
+
+    focus.setActive(slot: Slots.workspace, contributionId: 'other');
+    await tester.pump();
+    expect(focus.activeStatusWidget, isNull); // focus moved away → cleared
+  });
+
+  testWidgets('an inactive pane never conveys', (tester) async {
+    await tester.pumpWidget(harness(
+      f,
+      const ClidePane(
+        contributionId: 'pane.x',
+        active: false,
+        statusWidget: Text('S', textDirection: TextDirection.ltr),
+        child: SizedBox(),
+      ),
+    ));
+    f.services.focus.setActive(slot: Slots.workspace, contributionId: 'pane.x');
+    await tester.pump();
+    expect(f.services.focus.activeStatusWidget, isNull);
+  });
+
+  testWidgets('re-conveys when statusWidget changes while focused', (tester) async {
+    f.services.focus.setActive(slot: Slots.workspace, contributionId: 'pane.x');
+    var label = 'A';
+    late StateSetter setLabel;
+    await tester.pumpWidget(harness(
+      f,
+      StatefulBuilder(
+        builder: (ctx, setState) {
+          setLabel = setState;
+          return ClidePane(
+            contributionId: 'pane.x',
+            statusWidget: Text(label, textDirection: TextDirection.ltr),
+            child: const SizedBox(),
+          );
+        },
+      ),
+    ));
+    await tester.pump();
+    expect((f.services.focus.activeStatusWidget! as Text).data, 'A');
+
+    setLabel(() => label = 'B');
+    await tester.pump();
+    expect((f.services.focus.activeStatusWidget! as Text).data, 'B');
+  });
+}