add ClidePane primitive + focus-driven status-bar slot
Replace the MessageBus-based pane-context slot with a focus-driven one. Panes keep their status widget locally; the FocusTracker holds the focused pane's widget (activeStatusWidget) and ClidePane conveys it to the shared slot only while its contribution is focused, re-conveying on change and clearing on blur. The status-bar item just renders focus.activeStatusWidget, height-clamped and marquee-scrolled when it overflows. Removes the publish/subscribe race the bus version had. T-150. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -0,0 +1,83 @@
|
||||
/// Behaviour-only wrapper every pane uses (T-150). No chrome — that's
|
||||
/// [ClidePaneChrome]'s job. ClidePane handles cross-pane uniformity:
|
||||
/// surfacing the pane's [statusWidget] to the bottom status bar while the
|
||||
/// pane is focused, via [FocusTracker.setStatusWidget].
|
||||
///
|
||||
/// The widget lives with the pane; ClidePane only conveys it to the
|
||||
/// shared slot while this pane is the shown one (its contribution is
|
||||
/// focused and, for multi-pane contributions, it's the [active] sub-tab),
|
||||
/// and re-conveys whenever [statusWidget] changes. A backgrounded pane
|
||||
/// keeps its content locally and re-conveys on regaining focus.
|
||||
library;
|
||||
|
||||
import 'package:clide/kernel/src/facade.dart';
|
||||
import 'package:clide/kernel/src/focus.dart';
|
||||
import 'package:flutter/widgets.dart';
|
||||
|
||||
class ClidePane extends StatefulWidget {
|
||||
const ClidePane({
|
||||
super.key,
|
||||
required this.contributionId,
|
||||
required this.child,
|
||||
this.statusWidget,
|
||||
this.active = true,
|
||||
});
|
||||
|
||||
/// The workspace contribution id this pane belongs to (what
|
||||
/// [FocusTracker.activeContributionId] reports when it's focused).
|
||||
final String contributionId;
|
||||
|
||||
/// Status-bar content to surface while focused, or null for none.
|
||||
final Widget? statusWidget;
|
||||
|
||||
/// For contributions hosting multiple panes (e.g. Claude's sub-tabs),
|
||||
/// whether this is the visible one. Only the active pane conveys.
|
||||
final bool active;
|
||||
|
||||
final Widget child;
|
||||
|
||||
@override
|
||||
State<ClidePane> createState() => _ClidePaneState();
|
||||
}
|
||||
|
||||
class _ClidePaneState extends State<ClidePane> {
|
||||
FocusTracker? _focus;
|
||||
bool _wired = false;
|
||||
|
||||
@override
|
||||
void didChangeDependencies() {
|
||||
super.didChangeDependencies();
|
||||
if (!_wired) {
|
||||
_wired = true;
|
||||
_focus = ClideKernel.of(context).focus..addListener(_sync);
|
||||
}
|
||||
_sync();
|
||||
}
|
||||
|
||||
@override
|
||||
void didUpdateWidget(ClidePane old) {
|
||||
super.didUpdateWidget(old);
|
||||
if (old.statusWidget != widget.statusWidget || old.active != widget.active || old.contributionId != widget.contributionId) {
|
||||
_sync();
|
||||
}
|
||||
}
|
||||
|
||||
bool get _shown => widget.active && _focus?.activeContributionId == widget.contributionId;
|
||||
|
||||
// Convey our status while shown. Re-entrancy is bounded: setStatusWidget
|
||||
// notifies (→ _sync again), but the identical-widget guard there makes
|
||||
// the second pass a no-op.
|
||||
void _sync() {
|
||||
if (_shown) _focus?.setStatusWidget(widget.contributionId, widget.statusWidget);
|
||||
}
|
||||
|
||||
@override
|
||||
void dispose() {
|
||||
if (_shown) _focus?.setStatusWidget(widget.contributionId, null);
|
||||
_focus?.removeListener(_sync);
|
||||
super.dispose();
|
||||
}
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context) => widget.child;
|
||||
}
|
||||
Reference in New Issue
Block a user