dissolve app/ into repo root (D-056)
Single Flutter package at the repo root. All code, tests, assets, and platform directories moved from app/ to root. Package renamed from clide_app to clide — all imports rewritten. Merged pubspec combines core (ffi) and app (flutter, yaml, xterm) dependencies. Makefile simplified: no APP_PRESENT conditionals, no cd, no daemon lifecycle. 317 tests pass. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Claude Opus 4.6
@@ -0,0 +1,228 @@
|
||||
import 'dart:ui';
|
||||
|
||||
import 'package:clide/kernel/kernel.dart';
|
||||
import 'package:flutter_test/flutter_test.dart';
|
||||
|
||||
/// Fills fframe's test gap — every path through the lookup matrix is
|
||||
/// exercised here.
|
||||
void main() {
|
||||
group('I18n lookup & fallback', () {
|
||||
late Logger log;
|
||||
|
||||
setUp(() {
|
||||
log = Logger(minLevel: LogLevel.error); // silence warnings in tests
|
||||
});
|
||||
|
||||
I18n build({
|
||||
required Map<String, Map<Locale, Map<String, Object?>>> catalogs,
|
||||
Locale initial = const Locale('en', 'US'),
|
||||
Locale defaultLocale = const Locale('en', 'US'),
|
||||
}) {
|
||||
final loader = InMemoryCatalogLoader(catalogs);
|
||||
final i = I18n(
|
||||
loader: loader,
|
||||
log: log,
|
||||
defaultLocale: defaultLocale,
|
||||
initialLocale: initial,
|
||||
availableLocales: const [Locale('en', 'US'), Locale('nl', 'NL')],
|
||||
);
|
||||
return i;
|
||||
}
|
||||
|
||||
test('missing key with placeholder returns placeholder', () async {
|
||||
final i = build(catalogs: const {});
|
||||
await i.ensureNamespaceLoaded('builtin.x');
|
||||
expect(
|
||||
i.string('missing', namespace: 'builtin.x', placeholder: 'fallback'),
|
||||
'fallback',
|
||||
);
|
||||
});
|
||||
|
||||
test('missing key with null placeholder returns the key', () async {
|
||||
final i = build(catalogs: const {});
|
||||
await i.ensureNamespaceLoaded('builtin.x');
|
||||
expect(i.string('foo.bar', namespace: 'builtin.x'), 'foo.bar');
|
||||
});
|
||||
|
||||
test('unknown namespace still returns placeholder (no crash)', () {
|
||||
final i = build(catalogs: const {});
|
||||
expect(
|
||||
i.string('k', namespace: 'not.registered', placeholder: 'fb'),
|
||||
'fb',
|
||||
);
|
||||
});
|
||||
|
||||
test('exact locale hit beats fallback', () async {
|
||||
final i = build(catalogs: {
|
||||
'builtin.x': {
|
||||
const Locale('en', 'US'): {
|
||||
'greet': {'translation': 'Hello'},
|
||||
},
|
||||
const Locale('en'): {
|
||||
'greet': {'translation': 'Hi'},
|
||||
},
|
||||
},
|
||||
});
|
||||
await i.ensureNamespaceLoaded('builtin.x');
|
||||
expect(
|
||||
i.string('greet', namespace: 'builtin.x', placeholder: 'fb'),
|
||||
'Hello',
|
||||
);
|
||||
});
|
||||
|
||||
test('language-only locale hit falls through from exact', () async {
|
||||
final i = build(catalogs: {
|
||||
'builtin.x': {
|
||||
const Locale('nl'): {
|
||||
'greet': {'translation': 'Hoi'},
|
||||
},
|
||||
},
|
||||
}, initial: const Locale('nl', 'NL'));
|
||||
await i.ensureNamespaceLoaded('builtin.x');
|
||||
expect(
|
||||
i.string('greet', namespace: 'builtin.x', placeholder: 'fb'),
|
||||
'Hoi',
|
||||
);
|
||||
});
|
||||
|
||||
test('falls through to default-locale when current locale is empty',
|
||||
() async {
|
||||
final i = build(catalogs: {
|
||||
'builtin.x': {
|
||||
const Locale('en', 'US'): {
|
||||
'greet': {'translation': 'Hello'},
|
||||
},
|
||||
},
|
||||
}, initial: const Locale('nl', 'NL'));
|
||||
await i.ensureNamespaceLoaded('builtin.x');
|
||||
expect(
|
||||
i.string('greet', namespace: 'builtin.x', placeholder: 'fb'),
|
||||
'Hello',
|
||||
);
|
||||
});
|
||||
|
||||
test('interpolation replaces all replacers; missing ones silent', () async {
|
||||
final i = build(catalogs: {
|
||||
'builtin.x': {
|
||||
const Locale('en', 'US'): {
|
||||
'welcome': {'translation': 'Hi {name} at {path}'},
|
||||
},
|
||||
},
|
||||
});
|
||||
await i.ensureNamespaceLoaded('builtin.x');
|
||||
expect(
|
||||
i.interpolated(
|
||||
'welcome',
|
||||
namespace: 'builtin.x',
|
||||
placeholder: 'Hi {name} at {path}',
|
||||
replacers: const [
|
||||
I18nReplacer(from: '{name}', replace: 'Claude'),
|
||||
// {path} deliberately absent
|
||||
],
|
||||
),
|
||||
'Hi Claude at {path}',
|
||||
);
|
||||
});
|
||||
|
||||
test('namespace isolation — same key, different values', () async {
|
||||
final i = build(catalogs: {
|
||||
'a': {
|
||||
const Locale('en', 'US'): {
|
||||
'k': {'translation': 'A'},
|
||||
},
|
||||
},
|
||||
'b': {
|
||||
const Locale('en', 'US'): {
|
||||
'k': {'translation': 'B'},
|
||||
},
|
||||
},
|
||||
});
|
||||
await i.ensureNamespaceLoaded('a');
|
||||
await i.ensureNamespaceLoaded('b');
|
||||
expect(i.string('k', namespace: 'a', placeholder: '-'), 'A');
|
||||
expect(i.string('k', namespace: 'b', placeholder: '-'), 'B');
|
||||
});
|
||||
|
||||
test('setLocale refreshes cached namespaces and notifies listeners',
|
||||
() async {
|
||||
final i = build(catalogs: {
|
||||
'x': {
|
||||
const Locale('en', 'US'): {
|
||||
'k': {'translation': 'Hello'},
|
||||
},
|
||||
const Locale('nl'): {
|
||||
'k': {'translation': 'Hallo'},
|
||||
},
|
||||
},
|
||||
});
|
||||
await i.ensureNamespaceLoaded('x');
|
||||
var notified = 0;
|
||||
i.addListener(() => notified++);
|
||||
await i.setLocale(const Locale('nl'));
|
||||
expect(notified, greaterThanOrEqualTo(1));
|
||||
expect(i.string('k', namespace: 'x', placeholder: '-'), 'Hallo');
|
||||
});
|
||||
|
||||
test('registerCatalog merges third-party catalog', () async {
|
||||
final i = build(catalogs: const {});
|
||||
i.registerCatalog('ext.linear', const Locale('en', 'US'), const {
|
||||
'issue.title': {'translation': 'Issues'},
|
||||
});
|
||||
expect(
|
||||
i.string('issue.title', namespace: 'ext.linear', placeholder: '-'),
|
||||
'Issues',
|
||||
);
|
||||
});
|
||||
|
||||
test('unregisterCatalog forgets a namespace', () async {
|
||||
final i = build(catalogs: const {});
|
||||
i.registerCatalog('ext.x', const Locale('en', 'US'), const {
|
||||
'k': {'translation': 'v'},
|
||||
});
|
||||
expect(i.string('k', namespace: 'ext.x', placeholder: '-'), 'v');
|
||||
i.unregisterCatalog('ext.x');
|
||||
expect(i.string('k', namespace: 'ext.x', placeholder: '-'), '-');
|
||||
});
|
||||
|
||||
test('plain-string shape (no nested translation) is accepted', () async {
|
||||
// Forward-compat: if a catalog later switches to `"k": "v"`
|
||||
// instead of `"k": {"translation": "v"}`, lookup still works.
|
||||
final i = build(catalogs: {
|
||||
'x': {
|
||||
const Locale('en', 'US'): {'k': 'direct'},
|
||||
},
|
||||
});
|
||||
await i.ensureNamespaceLoaded('x');
|
||||
expect(i.string('k', namespace: 'x', placeholder: '-'), 'direct');
|
||||
});
|
||||
});
|
||||
|
||||
group('FallbackChain.resolve', () {
|
||||
test('ordering: exact, lang, default, default-lang', () {
|
||||
final chain = const FallbackChain(
|
||||
current: Locale('nl', 'NL'),
|
||||
defaultLocale: Locale('en', 'US'),
|
||||
).resolve();
|
||||
expect(chain.map((l) => l.toString()).toList(), [
|
||||
'nl_NL',
|
||||
'nl',
|
||||
'en_US',
|
||||
'en',
|
||||
]);
|
||||
});
|
||||
|
||||
test('deduplicates when current == default', () {
|
||||
final chain = const FallbackChain(
|
||||
current: Locale('en', 'US'),
|
||||
defaultLocale: Locale('en', 'US'),
|
||||
).resolve();
|
||||
expect(chain, ['en_US', 'en'].map((_) => isA<Locale>()));
|
||||
expect(chain.length, 2);
|
||||
});
|
||||
|
||||
test('filenameSuffix lowercases + omits empty country', () {
|
||||
expect(FallbackChain.filenameSuffix(const Locale('en', 'US')), 'en_us');
|
||||
expect(FallbackChain.filenameSuffix(const Locale('en')), 'en');
|
||||
});
|
||||
});
|
||||
}
|
||||
Reference in New Issue
Block a user