dissolve app/ into repo root (D-056)

Single Flutter package at the repo root. All code, tests, assets,
and platform directories moved from app/ to root. Package renamed
from clide_app to clide — all imports rewritten. Merged pubspec
combines core (ffi) and app (flutter, yaml, xterm) dependencies.
Makefile simplified: no APP_PRESENT conditionals, no cd, no daemon
lifecycle. 317 tests pass.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-04-23 00:37:20 +02:00
co-authored by Claude Opus 4.6
parent a526c5b9b7
commit 46329700d5
394 changed files with 978 additions and 1090 deletions
+40
View File
@@ -0,0 +1,40 @@
import 'package:clide/kernel/kernel.dart';
import 'package:flutter/services.dart' show rootBundle;
import 'package:flutter_test/flutter_test.dart';
/// WCAG-AA contrast gate. Every bundled theme's token pairs (listed in
/// [canonicalPairs]) must clear 4.5:1 for normal text / 3:1 for large
/// text. Failing pairs are printed with their computed ratio so a
/// theme-token regression shows exactly which pair broke.
void main() {
TestWidgetsFlutterBinding.ensureInitialized();
group('contrast — all bundled themes meet WCAG AA', () {
const bundledPaths = [
'lib/kernel/src/theme/themes/clide.yaml',
'lib/kernel/src/theme/themes/midnight.yaml',
'lib/kernel/src/theme/themes/paper.yaml',
'lib/kernel/src/theme/themes/terminal.yaml',
];
for (final path in bundledPaths) {
test('theme: $path', () async {
final def = await const ThemeLoader().fromAsset(rootBundle, path);
const resolver = ThemeResolver();
final tokens = resolver.resolve(
palette: def.palette,
semanticOverride: def.semanticOverride,
surfaceOverride: def.surfaceOverride,
extensionOverride: def.extensionOverride,
);
final failures = failingPairs(tokens);
if (failures.isNotEmpty) {
fail(
'Contrast failures in ${def.name}:\n'
'${failures.map((f) => ' - $f').join('\n')}',
);
}
});
}
});
}
+65
View File
@@ -0,0 +1,65 @@
import 'dart:ui';
import 'package:clide/kernel/kernel.dart';
import 'package:flutter/services.dart' show rootBundle;
import 'package:flutter_test/flutter_test.dart';
/// Asserts every bundled i18n catalog is well-formed and every key the
/// Tier-0 built-ins ask for actually resolves.
///
/// The second check is important: in a text-driven i18n system missing
/// keys show the placeholder, so a runtime lookup test wouldn't "fail"
/// on a typo — we have to assert the keys exist up front.
void main() {
TestWidgetsFlutterBinding.ensureInitialized();
/// (namespace, key) pairs referenced by Tier-0 built-ins. Extend when
/// new keys land.
const referenced = <String, List<String>>{
'builtin.welcome': [
'title',
'subtitle',
'open-project',
'open-project.hint',
'tab.title',
],
'builtin.ipc-status': [
'connected',
'connected.hint',
'disconnected',
'disconnected.hint',
],
'builtin.theme-picker': [
'modal.title',
'modal.cancel',
'modal.cancel.hint',
'row.select.hint',
],
'builtin.default-layout': [
'command.reset',
'preset.classic',
],
};
group('i18n coverage (Tier 0)', () {
for (final entry in referenced.entries) {
final ns = entry.key;
test('$ns catalog contains every referenced key', () async {
final loader = AssetCatalogLoader(bundle: rootBundle);
final catalog = await loader.load(ns, const Locale('en', 'US'));
expect(
catalog,
isNotEmpty,
reason: 'catalog for "$ns" failed to load (asset path wrong?)',
);
for (final key in entry.value) {
expect(
catalog.containsKey(key),
isTrue,
reason: 'namespace "$ns" catalog is missing key "$key"',
);
}
});
}
});
}
+48
View File
@@ -0,0 +1,48 @@
import 'package:clide/widgets/widgets.dart';
import 'package:flutter/semantics.dart';
import 'package:flutter/widgets.dart';
import 'package:flutter_test/flutter_test.dart';
import '../helpers/kernel_fixture.dart';
import '../helpers/widget_harness.dart';
/// Tier-0 smoke — each interactive primitive can *hold* focus when a
/// [Focus] wraps it, and Semantics reports the right tap action. Full
/// Tab-traversal order lives in `integration_test/app_starts_test.dart`
/// where the real WidgetsApp + DefaultFocusTraversal are present.
void main() {
group('keyboard focusability', () {
late KernelFixture f;
setUp(() async => f = await KernelFixture.create());
tearDown(() async => f.dispose());
testWidgets('ClideButton can be programmatically focused', (tester) async {
final node = FocusNode();
addTearDown(node.dispose);
await tester.pumpWidget(
harness(
f,
Focus(
focusNode: node,
child: ClideButton(label: 'Save', onPressed: () {}),
),
),
);
node.requestFocus();
await tester.pump();
expect(node.hasFocus, isTrue);
});
testWidgets('interactive widgets expose tap actions to a11y',
(tester) async {
await tester.pumpWidget(
harness(f, ClideButton(label: 'Save', onPressed: () {})),
);
final handle = tester.ensureSemantics();
final data =
tester.getSemantics(find.byType(ClideButton)).getSemanticsData();
expect(data.hasAction(SemanticsAction.tap), isTrue);
handle.dispose();
});
});
}
+66
View File
@@ -0,0 +1,66 @@
import 'package:clide/builtin/default_layout/default_layout.dart';
import 'package:clide/builtin/ipc_status/ipc_status.dart';
import 'package:clide/builtin/theme_picker/theme_picker.dart';
import 'package:clide/builtin/welcome/welcome.dart';
import 'package:clide/extension/extension.dart';
import 'package:flutter_test/flutter_test.dart';
/// Cross-extension contract check: every built-in extension declares a
/// non-empty title + version (so screen readers and the extensions-ui
/// surface can announce them) and every interactive contribution
/// carries enough data to build a Semantics node.
///
/// Per-widget Semantics-label checks live in each built-in's own
/// widget_test.dart (`test/builtin/**/widget_test.dart`) — they run
/// against a real pumped tree and assert the exact `label` + `hint`
/// reach the user. This file is the "nothing is missing from the
/// catalog" gate.
void main() {
group('Tier-0 built-in extensions — contract-level coverage', () {
final extensions = <ClideExtension>[
DefaultLayoutExtension(),
WelcomeExtension(),
IpcStatusExtension(),
ThemePickerExtension(),
];
for (final ext in extensions) {
group(ext.id, () {
test('has non-empty title + version', () {
expect(ext.title, isNotEmpty);
expect(ext.version, isNotEmpty);
});
test('tab contributions carry title + i18n key + namespace', () {
final tabs = ext.contributions.whereType<TabContribution>().toList();
for (final t in tabs) {
expect(t.title, isNotEmpty,
reason: '${ext.id} tab ${t.id} missing English title');
if (t.titleKey != null) {
expect(t.i18nNamespace, isNotNull,
reason:
'${ext.id} tab ${t.id} has titleKey but no namespace');
}
}
});
test('command contributions carry stable ids', () {
final cmds =
ext.contributions.whereType<CommandContribution>().toList();
for (final c in cmds) {
expect(c.command, isNotEmpty);
expect(c.id, isNotEmpty);
}
});
});
}
test('every registered tab hits a real slot', () {
for (final ext in extensions) {
for (final t in ext.contributions.whereType<TabContribution>()) {
expect(t.slot.value, isNotEmpty);
}
}
});
});
}