From 42d1d4acea2a0b41c6d881286fe85baa8d33c2ad Mon Sep 17 00:00:00 2001 From: Jeroen Schweitzer Date: Sun, 14 Jun 2026 22:28:07 +0200 Subject: [PATCH] ci(windows): drop redundant flutter analyze, reach the ConPTY tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The Windows job failed at `flutter analyze` on the missing (gitignored, generated) lib/src/build_info.g.dart — it never ran gen-build-info. But analyze is platform-agnostic: the Linux job already statically analyzes windows_pty.dart and everything else, and the flutter-build-windows release job catches Windows-specific compile errors. Dropping it unblocks the job's real purpose — running ConPTY under dart test — without needing build_info (the pty tests import the pty libraries directly, not the build_info-bearing barrel). Co-Authored-By: Claude Opus 4.8 (1M context) --- .github/workflows/windows.yml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml index 3d80aac3..8738a9df 100644 --- a/.github/workflows/windows.yml +++ b/.github/workflows/windows.yml @@ -26,7 +26,12 @@ jobs: channel: stable - run: flutter --version - run: flutter pub get - - run: flutter analyze + # No `flutter analyze` here: it's platform-agnostic — the Linux job already + # analyzes windows_pty.dart and everything else statically, and the + # `flutter build windows` release job catches Windows-specific compile + # errors. Skipping it also avoids needing `make gen-build-info`, since the + # pty tests import the pty libraries directly, not the build_info-bearing + # barrel (lib/clide.dart). This job's unique value is running real ConPTY. - name: ConPTY + Windows-arg unit tests # windows_pty_test.dart drives real ConPTY (it self-skips off-Windows); # the args/size suites are the pure-logic coverage. --timeout 60s so a