feat(svg): paint <image> via an injected resolver — completes the renderer (T-320)

paintSvg/SvgScenePainter/SvgView take an optional SvgImageResolver
(href → decoded ui.Image); image nodes draw into their dest rect. The
caller owns loading (file/asset/network), so the painter stays pure
rendering. Threaded marker + resolver through a small paint context.
Pixel-probe tested (image draws via the resolver; nothing without one).
The clide-owned SVG renderer is now feature-complete for T-320.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-06-28 22:18:53 +02:00
co-authored by Claude Opus 4.8
parent 718d2b39c2
commit 406da1e0c5
2 changed files with 82 additions and 29 deletions
+30 -2
View File
@@ -1,4 +1,6 @@
import 'dart:async';
import 'dart:io';
import 'dart:typed_data';
import 'dart:ui' as ui;
import 'package:clide/src/svg/svg_document.dart';
@@ -11,13 +13,26 @@ import 'package:flutter_test/flutter_test.dart';
void main() {
TestWidgetsFlutterBinding.ensureInitialized();
Future<ui.Image> render(String svg, double w, double h) async {
Future<ui.Image> render(String svg, double w, double h, {SvgImageResolver? images}) async {
final recorder = ui.PictureRecorder();
final canvas = ui.Canvas(recorder, Rect.fromLTWH(0, 0, w, h));
paintSvg(canvas, Size(w, h), buildSvgDocument(svg));
paintSvg(canvas, Size(w, h), buildSvgDocument(svg), images: images);
return recorder.endRecording().toImage(w.round(), h.round());
}
Future<ui.Image> solidImage(int w, int h, int argb) {
final px = Uint8List(w * h * 4);
for (var i = 0; i < w * h; i++) {
px[i * 4] = (argb >> 16) & 0xFF;
px[i * 4 + 1] = (argb >> 8) & 0xFF;
px[i * 4 + 2] = argb & 0xFF;
px[i * 4 + 3] = (argb >> 24) & 0xFF;
}
final c = Completer<ui.Image>();
ui.decodeImageFromPixels(px, w, h, ui.PixelFormat.rgba8888, c.complete);
return c.future;
}
Future<int> argbAt(ui.Image img, int x, int y) async {
final data = (await img.toByteData())!;
final i = (y * img.width + x) * 4;
@@ -82,6 +97,19 @@ void main() {
expect(greenDrawn, isTrue, reason: 'the green arrowhead should have been painted');
});
test('paints an <image> via the injected resolver, into its dest rect', () async {
final pic = await solidImage(4, 4, 0xFFFF00FF);
const svg = '<svg viewBox="0 0 10 10"><image x="0" y="0" width="10" height="10" href="pic"/></svg>';
final img = await render(svg, 10, 10, images: (href) => href == 'pic' ? pic : null);
expect(await argbAt(img, 5, 5), 0xFFFF00FF);
});
test('an <image> with no resolver paints nothing', () async {
const svg = '<svg viewBox="0 0 10 10"><image x="0" y="0" width="10" height="10" href="pic"/></svg>';
final img = await render(svg, 10, 10);
expect(alpha(await argbAt(img, 5, 5)), 0);
});
test('renders the real d2 fixture without error and draws ink', () async {
final svg = File('test/svg/fixtures/d2_pipeline.svg').readAsStringSync();
final img = await render(svg, 200, 120);