Phosphor icons: resolve by name via a generated map (T-314)

Replace the 49 hand-maintained named consts with one generated
label→codepoint map (phosphor_glyphs.g.dart, 1512 glyphs from the glyph
table via tool/gen_phosphor_glyphs.dart). Feature code now references
glyphs by their exact kebab-case name — PhosphorIcons.byName('folder') —
with no raw codepoints; this also lets a Lua extension name an icon
without crossing the FFI boundary with a codepoint.

byName is total: an unknown name degrades to the `placeholder` box so the
bug is visible (it's a real error), while phosphor_glyphs_test asserts
every byName('...') literal in lib/ resolves — recovering the typo check a
const gave. Migrated the 89 call sites. Adds EmptyIconPainter for an
intentional blank that still reserves the icon box; ClideFilterBox gains
showIcon to keep the slot aligned when blank.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-06-10 12:46:51 +02:00
co-authored by Claude Opus 4.8
parent b8d75230e8
commit 3833a41a9e
38 changed files with 1779 additions and 163 deletions
+9 -7
View File
@@ -296,11 +296,13 @@ void main() {
testWidgets('renders the hint as a placeholder (shown empty, hidden once typed); icon optional', (tester) async {
await tester.pumpWidget(harness(
f,
ClideFilterBox(onChanged: (_) {}, hint: 'Replace', icon: null),
ClideFilterBox(onChanged: (_) {}, hint: 'Replace', showIcon: false),
));
// Placeholder visible while empty; no leading search glyph (icon: null).
// Placeholder visible while empty; the icon slot is kept for alignment but
// draws a blank glyph (showIcon: false → EmptyIconPainter).
expect(find.text('Replace'), findsOneWidget);
expect(find.byType(ClideIcon), findsNothing);
expect(find.byType(ClideIcon), findsOneWidget);
expect(tester.widget<ClideIcon>(find.byType(ClideIcon)).painter, isA<EmptyIconPainter>());
// Typing hides the placeholder.
await tester.enterText(find.byType(EditableText), 'x');
await tester.pump();
@@ -349,9 +351,9 @@ void main() {
await tester.pumpWidget(harness(
f,
ClideIconRail(
items: const [
ClideIconRailItem(id: 'a', icon: PhosphorIcons.folder, tooltip: 'A'),
ClideIconRailItem(id: 'b', icon: PhosphorIcons.gitBranch, tooltip: 'B'),
items: [
ClideIconRailItem(id: 'a', icon: PhosphorIcons.byName('folder'), tooltip: 'A'),
ClideIconRailItem(id: 'b', icon: PhosphorIcons.byName('git-branch'), tooltip: 'B'),
],
activeId: 'a',
onSelect: (id) => selected = id,
@@ -373,7 +375,7 @@ void main() {
height: 30,
child: ClideIconRail(
items: [
for (var i = 0; i < 10; i++) ClideIconRailItem(id: '$i', icon: PhosphorIcons.folder, tooltip: 'Tab $i'),
for (var i = 0; i < 10; i++) ClideIconRailItem(id: '$i', icon: PhosphorIcons.byName('folder'), tooltip: 'Tab $i'),
],
activeId: '0',
onSelect: (_) {},