jpmschweitzer/clide
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Phosphor icons: resolve by name via a generated map (T-314)

Browse Source 
Replace the 49 hand-maintained named consts with one generated
label→codepoint map (phosphor_glyphs.g.dart, 1512 glyphs from the glyph
table via tool/gen_phosphor_glyphs.dart). Feature code now references
glyphs by their exact kebab-case name — PhosphorIcons.byName('folder') —
with no raw codepoints; this also lets a Lua extension name an icon
without crossing the FFI boundary with a codepoint.

byName is total: an unknown name degrades to the `placeholder` box so the
bug is visible (it's a real error), while phosphor_glyphs_test asserts
every byName('...') literal in lib/ resolves — recovering the typo check a
const gave. Migrated the 89 call sites. Adds EmptyIconPainter for an
intentional blank that still reserves the icon box; ClideFilterBox gains
showIcon to keep the slot aligned when blank.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
jpmschweitzer
2026-06-10 12:46:51 +02:00
co-authored by Claude Opus 4.8
parent b8d75230e8
commit 3833a41a9e
38 changed files with 1779 additions and 163 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/app_collapse_toggle_test.dart
+9 -9
View File
@@ -38,17 +38,17 @@ void main() {
// Sidebar open → action is collapse (leftward) → caret-line-left.
await tester.pumpWidget(_host(f, const StatusbarCollapseToggle(slot: Slots.sidebar, collapsed: false, visible: true)));
await tester.pump();
expect(_icon(PhosphorIcons.caretLineLeft), findsOneWidget);
expect(_icon(PhosphorIcons.byName('caret-line-left')), findsOneWidget);
// Sidebar collapsed → action is expand (rightward) → caret-line-right.
await tester.pumpWidget(_host(f, const StatusbarCollapseToggle(slot: Slots.sidebar, collapsed: true, visible: true)));
await tester.pump();
expect(_icon(PhosphorIcons.caretLineRight), findsOneWidget);
expect(_icon(PhosphorIcons.byName('caret-line-right')), findsOneWidget);
// The context toggle mirrors it: open → collapse rightward, collapsed → expand leftward.
await tester.pumpWidget(_host(f, const StatusbarCollapseToggle(slot: Slots.contextPanel, collapsed: false, visible: true)));
await tester.pump();
expect(_icon(PhosphorIcons.caretLineRight), findsOneWidget);
expect(_icon(PhosphorIcons.byName('caret-line-right')), findsOneWidget);
});
testWidgets('the chevron flips live when the collapsed state changes', (tester) async {
@@ -62,19 +62,19 @@ void main() {
}),
));
await tester.pump();
expect(_icon(PhosphorIcons.caretLineLeft), findsOneWidget);
expect(_icon(PhosphorIcons.byName('caret-line-left')), findsOneWidget);
setOuter(() => collapsed = true);
await tester.pump();
expect(_icon(PhosphorIcons.caretLineRight), findsOneWidget, reason: 'rebuilds and flips on state change');
expect(_icon(PhosphorIcons.caretLineLeft), findsNothing);
expect(_icon(PhosphorIcons.byName('caret-line-right')), findsOneWidget, reason: 'rebuilds and flips on state change');
expect(_icon(PhosphorIcons.byName('caret-line-left')), findsNothing);
});
testWidgets('a hidden pane reserves the cell but shows no chevron', (tester) async {
await tester.pumpWidget(_host(f, const StatusbarCollapseToggle(slot: Slots.sidebar, collapsed: false, visible: false)));
await tester.pump();
expect(_icon(PhosphorIcons.caretLineLeft), findsNothing);
expect(_icon(PhosphorIcons.caretLineRight), findsNothing);
expect(_icon(PhosphorIcons.byName('caret-line-left')), findsNothing);
expect(_icon(PhosphorIcons.byName('caret-line-right')), findsNothing);
});
testWidgets('tapping fires the matching collapse command', (tester) async {
@@ -90,7 +90,7 @@ void main() {
await tester.pump();
expect(f.services.arrangement.isCollapsed(Slots.sidebar), isFalse);
await tester.tap(_icon(PhosphorIcons.caretLineLeft));
await tester.tap(_icon(PhosphorIcons.byName('caret-line-left')));
await tester.pump();
expect(f.services.arrangement.isCollapsed(Slots.sidebar), isTrue);