jpmschweitzer/clide
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Phosphor icons: resolve by name via a generated map (T-314)

Browse Source 
Replace the 49 hand-maintained named consts with one generated
label→codepoint map (phosphor_glyphs.g.dart, 1512 glyphs from the glyph
table via tool/gen_phosphor_glyphs.dart). Feature code now references
glyphs by their exact kebab-case name — PhosphorIcons.byName('folder') —
with no raw codepoints; this also lets a Lua extension name an icon
without crossing the FFI boundary with a codepoint.

byName is total: an unknown name degrades to the `placeholder` box so the
bug is visible (it's a real error), while phosphor_glyphs_test asserts
every byName('...') literal in lib/ resolves — recovering the typo check a
const gave. Migrated the 89 call sites. Adds EmptyIconPainter for an
intentional blank that still reserves the icon box; ClideFilterBox gains
showIcon to keep the slot aligned when blank.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
jpmschweitzer
2026-06-10 12:46:51 +02:00
co-authored by Claude Opus 4.8
parent b8d75230e8
commit 3833a41a9e
38 changed files with 1779 additions and 163 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.claude/skills/ui-design/references/icons.md
+18 -20
View File
@@ -6,32 +6,30 @@ The app bundles Phosphor Icons (v2.0.8, MIT) as TTF fonts at
`assets/fonts/phosphor/` (regular, bold, fill weights).
**Glyph reference:** [`phosphor-glyphs.md`](phosphor-glyphs.md) — the full
1512-glyph table (codepoint · kebab name · Pascal name) with an **In clide**
column flagging the ~45 already wired into `PhosphorIcons`. Read/grep this to
pick a glyph; reach for an already-defined one first. (It mirrors
`assets/fonts/phosphor/codepoints.csv`; regenerate with
`python3 .claude/skills/ui-design/scripts/gen-phosphor-glyphs.py` after a font
bump.)
### Adding an icon
Find the codepoint in [`phosphor-glyphs.md`](phosphor-glyphs.md), then add a
`static const` entry to `PhosphorIcons` in
`lib/widgets/src/icons/phosphor.dart`:
```dart
static const arrowClockwise = PhosphorIconPainter(0xe036);
```
Only add icons we actually use — don't bulk-import the full set.
1512-glyph table (codepoint · kebab name · Pascal name). Grep it for the exact
kebab name; **all 1512 are available** — no per-icon wiring (T-314).
### Using an icon
Reference a glyph by its **exact kebab-case name** — no codepoints in feature
code; the label→codepoint table lives only in the generated
`lib/widgets/src/icons/phosphor_glyphs.g.dart`:
```dart
ClideIcon(PhosphorIcons.arrowClockwise, size: 13)
ClideIcon(PhosphorIcons.byName('arrow-clockwise'), size: 13)
```
Or as a `TabContribution` icon field: `icon: PhosphorIcons.lightbulb`.
Or as a `TabContribution` icon field: `icon: PhosphorIcons.byName('lightbulb')`.
- An **unknown name** is a bug — it degrades to the `placeholder` error box so
the mistake is visible. `phosphor_glyphs_test` asserts every `byName('…')`
literal in `lib/` resolves, recovering the typo check a const would give.
- For an **intentional blank** that still reserves the icon's box (alignment),
use `const EmptyIconPainter()` — *not* a missing name.
- Regenerate the map after a font bump: `dart run tool/gen_phosphor_glyphs.dart`.
**Bold weight:** pass `family: 'Phosphor-Bold'` to `PhosphorIconPainter`.
**Fill weight:** `family: 'Phosphor-Fill'`.
**Bold weight:** pass `family: 'Phosphor-Bold'` to `PhosphorIconPainter`.
**Fill weight:** `family: 'Phosphor-Fill'`.