From 257a33390458f57b5b4ed3b8be8f777f20e0ee04 Mon Sep 17 00:00:00 2001 From: Jeroen Schweitzer Date: Wed, 6 May 2026 23:37:13 +0200 Subject: [PATCH] drop debug main() from keytab_default.dart The file's only purpose is to expose the default-keytab string constant, but it carried a `void main()` at the end that parsed that constant and printed the result. That entry point: - doesn't belong in `lib/` (Dart entry points live in `bin/` or `tool/`), - pulls in `keytab_parse` and `keytab_token` imports that are unused everywhere else in the file, - emits one of the pre-existing `avoid_print` analyze infos, - only ever ran when a contributor manually invoked `dart lib/src/terminal/src/core/input/keytab/keytab_default.dart`, which the build never does. Removing it unblocks the file from the coverage report (no executable lines remain, just the string constant), drops the unused imports, and shaves an analyze info off the pre-existing total. If the dump-to-stdout helper turns out to be useful again, the right home is a `tool/dump_keytab.dart` outside the package's runtime surface. Co-Authored-By: Claude --- .pql/pql-plan.json | 2 +- .../terminal/src/core/input/keytab/keytab_default.dart | 9 --------- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/.pql/pql-plan.json b/.pql/pql-plan.json index 3de73249..6709ae7b 100644 --- a/.pql/pql-plan.json +++ b/.pql/pql-plan.json @@ -1,5 +1,5 @@ { - "exported_at": "2026-05-06T21:37:05Z", + "exported_at": "2026-05-06T21:37:13Z", "decisions": [ { "id": "D-1", diff --git a/lib/src/terminal/src/core/input/keytab/keytab_default.dart b/lib/src/terminal/src/core/input/keytab/keytab_default.dart index 92b18f67..3059738b 100644 --- a/lib/src/terminal/src/core/input/keytab/keytab_default.dart +++ b/lib/src/terminal/src/core/input/keytab/keytab_default.dart @@ -1,8 +1,5 @@ // Based on xterm.dart v4.0.0 by xuty (MIT). See LICENSE in this directory. -import 'package:clide/src/terminal/src/core/input/keytab/keytab_parse.dart'; -import 'package:clide/src/terminal/src/core/input/keytab/keytab_token.dart'; - const kDefaultKeytab = r''' # [README.default.Keytab] Default Keyboard Table # @@ -207,9 +204,3 @@ key Down +Shift-AppScreen : scrollLineDown key PgDown +Shift-AppScreen : scrollPageDown key End +Shift-AppScreen : scrollDownToBottom '''; - -void main() { - final tokens = tokenize(kDefaultKeytab).toList(); - final parser = KeytabParser()..addTokens(tokens); - print(parser.result); -}