sweep remaining analyze infos to zero

Clears the 19 misc lint hits left after the test_app print sweep
+ libc.dart suppression. By rule:

- `withOpacity(α)` → `withValues(alpha: α)` (deprecated_member_use)
  in `painter.dart:187` and `terminal_view.dart:318`.
- `Pointer.elementAt(n)` → `Pointer + n` (deprecated_member_use)
  in `native_pty.dart:306` and `session.dart:187`.
- Brace single-statement for/if bodies in `native_pty.dart`
  (×3) and `decisions_view.dart` (curly_braces_in_flow_control_
  structures).
- `IsolateClient` and `InProcessClient` constructors switched to
  `super.log` / `super.events` parameters (use_super_parameters);
  associated unused imports of `kernel/src/log.dart` and
  `kernel/src/events/bus.dart` removed in the same files.
- `InProcessClient._dispatcher` field + getter/setter pair folded
  into a single mutable public `dispatcher` field
  (unnecessary_getters_setters).
- `_buildDispatcher` local in `lib/main.dart` renamed to
  `buildDispatcher` (no_leading_underscores_for_local_identifiers).
- `_onTapDown(_)` in `terminal_view.dart` typed as
  `TapDownDetails _` (strict_top_level_inference).
- `operator []=(...)` in `circular_buffer.dart` given an explicit
  `void` return type (strict_top_level_inference).
- `CustomKeyboardListener` and `TerminalGestureDetector` callsites
  reordered so `child:` lands last (sort_child_properties_last).
- `CustomTextEdit` constructor declared `const`
  (prefer_const_constructors_in_immutables).
- `LinkedHashMap<K, V>()` in `paragraph_cache.dart` collapsed to a
  `<K, V>{}` literal (prefer_collection_literals); the now-unused
  `dart:collection` import dropped.

Project analyze: 19 → 0 issues. `make test` stays green; coverage
unchanged at 52.72%.

Co-Authored-By: Claude <noreply@anthropic.com>

lib/src/pty/native_pty.dart

@@ -216,9 +216,13 @@ class NativePty {
     ffi.Pointer ws,
   ) {
     malloc.free(shell);
-    for (var i = 0; i < argc; i++) malloc.free(argv[i]);
+    for (var i = 0; i < argc; i++) {
+      malloc.free(argv[i]);
+    }
     malloc.free(argv);
-    for (var i = 0; i < envc; i++) malloc.free(envp[i]);
+    for (var i = 0; i < envc; i++) {
+      malloc.free(envp[i]);
+    }
     malloc.free(envp);
     malloc.free(wd);
     calloc.free(fdOut);
@@ -298,12 +302,14 @@ class NativePty {
     if (_dead || bytes.isEmpty) return 0;
     final buf = malloc<ffi.Uint8>(bytes.length);
     try {
-      for (var i = 0; i < bytes.length; i++) buf[i] = bytes[i];
+      for (var i = 0; i < bytes.length; i++) {
+        buf[i] = bytes[i];
+      }
       var written = 0;
       while (written < bytes.length) {
         final n = _nativeWrite(
           _fd,
-          buf.elementAt(written).cast(),
+          (buf + written).cast(),
           bytes.length - written,
         );
         if (n < 0) {

lib/src/pty/session.dart

@@ -184,7 +184,7 @@ class PtySession {
       while (written < bytes.length) {
         final n = libc.write(
           _masterFd,
-          buf.elementAt(written),
+          buf + written,
           bytes.length - written,
         );
         if (n < 0) {