jpmschweitzer/clide
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(i18n): stop warning on missing tool.name.* keys for proper-name tools (T-493)

Browse Source 
Tool display names are open-ended (Bash, Grep, Glob, ScheduleWakeup, MCP tools,
…) — they intentionally have no catalog key and fall back to the raw name, so a
miss isn't a gap to fix. The conversation pane was logging an i18n "missing key"
warning for each, cluttering the output dock.

Adds a `warnIfMissing` flag to I18nService.string (default true, so fixed UI
strings still warn on a real gap) threaded through the ClideSettings facade;
_toolNameLabel passes false. Display is unchanged — the placeholder already
rendered the raw name.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
jpmschweitzer
2026-06-28 14:58:12 +02:00
co-authored by Claude Opus 4.8
parent e5976ad6b1
commit 066197c5e1
7 changed files with 55 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/kernel/src/i18n/i18n.dart
+10 -3
View File
@@ -92,10 +92,15 @@ class I18n extends ChangeNotifier {
/// Look up a key, walking the locale fallback chain. Returns the
/// placeholder if nothing hits; returns the key itself when placeholder
/// is null (developer fallback — keys are more useful than blanks).
String string(String key, {required String namespace, String? placeholder}) {
/// [warnIfMissing] false suppresses the missing-key warning for OPEN-ENDED
/// lookups where a miss is the normal case, not a bug — e.g. tool display
/// names (`tool.name.Bash`, `tool.name.ScheduleWakeup`, MCP tools), which are
/// proper-name identifiers that intentionally fall back to the raw name. Keep
/// the warning on for fixed UI strings, where a miss is a real translation gap.
String string(String key, {required String namespace, String? placeholder, bool warnIfMissing = true}) {
final byLocale = _cache[namespace];
if (byLocale == null) {
_warnOnce('$namespace::MISSING_NAMESPACE::$key', 'i18n: namespace not registered: $namespace (key: $key)');
if (warnIfMissing) _warnOnce('$namespace::MISSING_NAMESPACE::$key', 'i18n: namespace not registered: $namespace (key: $key)');
return placeholder ?? key;
}
@@ -108,7 +113,9 @@ class I18n extends ChangeNotifier {
if (hit != null) return hit;
}
_warnOnce('$namespace::${_current.languageCode}::$key', 'i18n: missing key "$key" in namespace "$namespace" (locale ${_current.toString()})');
if (warnIfMissing) {
_warnOnce('$namespace::${_current.languageCode}::$key', 'i18n: missing key "$key" in namespace "$namespace" (locale ${_current.toString()})');
}
return placeholder ?? key;
}