jpmschweitzer/clide
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(env): one login-shell-derived PATH for every spawned tool (T-439)

Browse Source 
Desktop/dock-launched clide inherits a sparse PATH (no ~/.local/bin, brew,
nvm, …), so pql/git/claude and PTY tools went missing. T-347 fixed only the
toolchain/pql path on Linux; env.dart's expander was still macOS-only and
claude/PTY/git used the raw PATH — the breakage recurred per spawn site
because there were three divergent expanders.

Consolidate into one resolver (lib/src/env/shell_env.dart):
- primeLoginShellPath(): probe the user's real login shell once at startup
  (`$SHELL -l -c`, sentinel-framed, bounded timeout, graceful fallback to the
  process PATH). Captures the user's actual PATH, not a hardcoded guess.
- expandToolPath(): the canonical merge (moved from toolchain_paths, which
  re-exports it for its tests) — unions the well-known user/local bin dirs.
- resolvedToolPath(): currentSearchPath() + expandToolPath, the single call
  every spawn site uses.

Routed through it: PTY children (registry.dart now overrides PATH), git
(env.dart → operations.dart), the toolchain probe (toolchain_paths), and
hosted claude (agent_bootstrap). Primed in main.dart's !kIsWeb boot. Deleted
the macOS-only env.dart copy and the cli_install copy.

Tests: new shell_env_test (probe + every fallback + merge); env_test and
cli_install_test updated to the consolidated surface. analyze clean, web wasm
build still green, make test green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
jpmschweitzer
2026-06-15 17:46:11 +02:00
co-authored by Claude Opus 4.8
parent ca08c2a17d
commit 03d053274e
13 changed files with 269 additions and 87 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/kernel/cli_install_test.dart
+2 -17
View File
@@ -130,23 +130,8 @@ void main() {
});
});
group('expandedPath', () {
test('non-macOS returns PATH unchanged', () {
expect(expandedPath('/a:/b', macOS: false, home: '/home/x'), '/a:/b');
});
test('macOS prepends missing user + homebrew bins', () {
final out = expandedPath('/usr/bin', macOS: true, home: '/home/x').split(':');
expect(out, contains('/home/x/.local/bin'));
expect(out, contains('/opt/homebrew/bin'));
expect(out.last, '/usr/bin');
});
test('macOS does not duplicate entries already on PATH', () {
final out = expandedPath('/opt/homebrew/bin:/usr/bin', macOS: true, home: '');
expect('/opt/homebrew/bin'.allMatches(out).length, 1);
});
});
// PATH expansion moved to the shared resolver (T-439); its logic is covered by
// expandToolPath in toolchain_paths_test + shell_env_test.
group('install', () {
test('fails clearly when no bundled client is present', () {